- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: aaa: Fix UserGroups list model
by yzaslavs＠redhat.com 13 Oct '14

13 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Fix UserGroups list model ...................................................................... aaa: Fix UserGroups list model The previous code populated the groups sub tab of users by using information from the user entity (namespace and group names), but the namespace may vary between user and the groups it belongs to Change-Id: I39387d68687d530008a2114057d30fc04f27f0ce Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDbGroupsByUserIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbGroupDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbGroupDAODbFacadeImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserGroupListModel.java M packaging/dbscripts/ad_groups_sp.sql 7 files changed, 72 insertions(+), 7 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33936 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39387d68687d530008a2114057d30fc04f27f0ce Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: Fix size update in pools of ppc64 VMs
by tnisan＠redhat.com 13 Oct '14

13 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Fix size update in pools of ppc64 VMs ...................................................................... restapi: Fix size update in pools of ppc64 VMs The size of VM pools could not be increased in ppc64 due to a problem reading templates and inheriting properties from them. This patch fixes this issue by correctly reading the VM template used in the pool and using some of its properties as parameters. Change-Id: I2c4a2a510cc96f6081f72af56ad84d6d54707677 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1148706 Signed-off-by: Vitor de Lima <vdelima(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResource.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Vitor de Lima: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34012 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c4a2a510cc96f6081f72af56ad84d6d54707677 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: removed ugly if-else chain
by lvernia＠redhat.com 13 Oct '14

13 Oct '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: removed ugly if-else chain ...................................................................... webadmin: removed ugly if-else chain most of given 'rules' can be replaced by polymorphism. Remaining ones(VmPool, DbUser and DbGroup) are probably only badly created and should be fixed to remove this chain altogether. Returning Guid.Empty is not apropriate and should be removed as well. Change-Id: Ic716dc67b90c1d575de14c40b504c984bf0467f2 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 1 file changed, 20 insertions(+), 66 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33619 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic716dc67b90c1d575de14c40b504c984bf0467f2 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix dependency issues caused by log refactoring
by yzaslavs＠redhat.com 13 Oct '14

13 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fix dependency issues caused by log refactoring ...................................................................... core: Fix dependency issues caused by log refactoring Fixes dependency issues caused by log refactoring Change-Id: I02f3de8ea133a7ee4ccb95ff5bba42d0d28a706b Bug-Url: https://bugzilla.redhat.com/1109871 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- D backend/manager/dependencies/src/main/modules/org/antlr/antlr4-runtime/main/module.xml M backend/manager/modules/utils/src/main/modules/org/ovirt/engine/core/utils/main/module.xml M backend/manager/modules/uutils/src/main/modules/org/ovirt/engine/core/uutils/main/module.xml 3 files changed, 3 insertions(+), 13 deletions(-) Approvals: Martin Peřina: Verified Juan Hernandez: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02f3de8ea133a7ee4ccb95ff5bba42d0d28a706b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Add ballooning to RSDL metadata
by juan.hernandez＠redhat.com 13 Oct '14

13 Oct '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add ballooning to RSDL metadata ...................................................................... restapi: Add ballooning to RSDL metadata This patch adds the documentation of the ballooning parameter to the RSDL metadata. Change-Id: Idc73af8bc7b2dc74196f247f464dd31622b8797d Bug-Url: https://bugzilla.redhat.com/1149188 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Gilad Chaplik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33772 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc73af8bc7b2dc74196f247f464dd31622b8797d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: remote_engine: support older paramiko
by tnisan＠redhat.com 13 Oct '14

13 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: remote_engine: support older paramiko ...................................................................... packaging: setup: remote_engine: support older paramiko Support el6's version of paramiko in which SFTPFile is not a context manager. Change-Id: I730d15670bd9aa5dc68d6d1f93157c5895429491 Bug-Url: https://bugzilla.redhat.com/1150498 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 9c29b4c4224927a079c0fab75502c52feaaa1e1d) --- M packaging/setup/plugins/ovirt-engine-common/base/remote_engine/remote_engine_root_ssh.py 1 file changed, 15 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/34055 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I730d15670bd9aa5dc68d6d1f93157c5895429491 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: using engine-common in websocketproxy plugins
by tnisan＠redhat.com 13 Oct '14

13 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: using engine-common in websocketproxy plugins ...................................................................... packaging: setup: using engine-common in websocketproxy plugins Loosen up engine-common requirements in order to use it from wsp plugins. Change-Id: I7cb1245105f913f0c82fb3b909f14584053e8a0f Bug-Url: https://bugzilla.redhat.com/1125188 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt-engine.spec.in M packaging/setup/ovirt_engine_setup/engine_common/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/config/java.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/jboss.py 4 files changed, 14 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/33940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7cb1245105f913f0c82fb3b909f14584053e8a0f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[ovirt-engine-reports-3.5]: build: post ovirt-engine-reports-3.5_rc5
by sradco＠redhat.com 13 Oct '14

13 Oct '14

Shirly Radco has submitted this change and it was merged. Change subject: build: post ovirt-engine-reports-3.5_rc5 ...................................................................... build: post ovirt-engine-reports-3.5_rc5 Change-Id: I1ade35573067e88d62ea95eb93f3475a50d316ca Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34059 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ade35573067e88d62ea95eb93f3475a50d316ca Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[ovirt-engine-reports-3.5]: build: ovirt-engine-reports-3.5_rc5
by sradco＠redhat.com 13 Oct '14

13 Oct '14

Shirly Radco has submitted this change and it was merged. Change subject: build: ovirt-engine-reports-3.5_rc5 ...................................................................... build: ovirt-engine-reports-3.5_rc5 Added release notes. Change-Id: Ic95bb9618c125e70e07b13d8f35ca887f19da25f Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-reports.spec.in M version.mak 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34058 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic95bb9618c125e70e07b13d8f35ca887f19da25f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: aaa: remove group should not depend on existence of provider
by yzaslavs＠redhat.com 13 Oct '14

13 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: remove group should not depend on existence of provider ...................................................................... aaa: remove group should not depend on existence of provider Change-Id: Idd8a5a35816a530dbb7405eedefe4936b7e91c4f Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/AdGroupsHandlingCommandBase.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 2 files changed, 19 insertions(+), 40 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34008 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd8a5a35816a530dbb7405eedefe4936b7e91c4f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0