- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core : Add custom error page for reports
by oourfali＠redhat.com 05 Oct '14

05 Oct '14

Oved Ourfali has submitted this change and it was merged. Change subject: core : Add custom error page for reports ...................................................................... core : Add custom error page for reports Custom error page for reports not installed error message Change-Id: Ic4489ef8a5a7d07734094e3c974fdaa215f44bef Bug-Url: https://bugzilla.redhat.com/1143998 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- A backend/manager/modules/welcome/src/main/webapp/WEB-INF/ReportsNotInstalled.jsp 1 file changed, 43 insertions(+), 0 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33730 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4489ef8a5a7d07734094e3c974fdaa215f44bef Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: VmSnapshotList - filter LunDisks on getVmDiskList
by tnisan＠redhat.com 05 Oct '14

05 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: VmSnapshotList - filter LunDisks on getVmDiskList ...................................................................... webadmin: VmSnapshotList - filter LunDisks on getVmDiskList VmSnapshotList -> updatePreviewedDiskSnapshots: filer LunDisks from 'getVmDiskList' result. Change-Id: Iaf983d1a8095b8739cd0e4ff4a872100f3e2c921 Bug-Url: https://bugzilla.redhat.com/1148424 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 1 file changed, 11 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/33723 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf983d1a8095b8739cd0e4ff4a872100f3e2c921 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Log error correctly when connecting domain for removal
by tnisan＠redhat.com 05 Oct '14

05 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Log error correctly when connecting domain for removal ...................................................................... core: Log error correctly when connecting domain for removal When connecting to a storage domain as a part of its removal (or format in case of ISO domains) if the connection fails, the error is not logged correctly and instead we get a generic error, this was fixed and instead the generic error we will get the real cause Change-Id: Idd7435336acbec41edbdd70568f1dfdce664f875 Bug-Url: https://bugzilla.redhat.com/1003266 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseFsStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FCPStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommandTest.java 7 files changed, 56 insertions(+), 25 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33442 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd7435336acbec41edbdd70568f1dfdce664f875 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: VmSnapshotList - filter LunDisks on getVmDiskList
by derez＠redhat.com 05 Oct '14

05 Oct '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: VmSnapshotList - filter LunDisks on getVmDiskList ...................................................................... webadmin: VmSnapshotList - filter LunDisks on getVmDiskList VmSnapshotList -> updatePreviewedDiskSnapshots: filer LunDisks from 'getVmDiskList' result. Change-Id: Iaf983d1a8095b8739cd0e4ff4a872100f3e2c921 Bug-Url: https://bugzilla.redhat.com/1148424 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 1 file changed, 11 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/33722 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf983d1a8095b8739cd0e4ff4a872100f3e2c921 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: frontend: Fix disk creation NPE on diskprofile selection
by tnisan＠redhat.com 05 Oct '14

05 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Fix disk creation NPE on diskprofile selection ...................................................................... frontend: Fix disk creation NPE on diskprofile selection I was getting a NullPointer Exception when adding disks in oVirt 3.5 prerelease. Bug-Url: https://bugzilla.redhat.com/1149442 Change-Id: Ia3338051ae3888fb672419c6a4a9cb1cc03e6fde Signed-off-by: Antoni S. Puimedon <asegurap(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33802 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3338051ae3888fb672419c6a4a9cb1cc03e6fde Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: avoid sending NUMA values if not specified
by tnisan＠redhat.com 05 Oct '14

05 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: avoid sending NUMA values if not specified ...................................................................... core: avoid sending NUMA values if not specified Currently NUMA Tune Mode is sent even if VM doesn't have virtual NUMA nodes configured. Change-Id: I306a3004861295a6743288e5ed3a70cfdd49398d Bug-Url: https://bugzilla.redhat.com/1147261 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I306a3004861295a6743288e5ed3a70cfdd49398d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Handle NUMA preferred tune mode
by tnisan＠redhat.com 05 Oct '14

05 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Handle NUMA preferred tune mode ...................................................................... core: Handle NUMA preferred tune mode This patch addresses 3 issues: - 5892ef11 added NumaTuneMode to VmBase, so we need to update all VmStatic elements (VM templates) that was added since. - libvirt failure when running in preferred mode without specifying numa nodes. Added validation to add/edit VM to fail command when preferred numa tune set and there is no single VM node configured pinned to NUMA node. Change-Id: I637fb996d06e97d55bdd8309a668307cac8bb546 Bug-Url: https://bugzilla.redhat.com/1146445 Bug-Url: https://bugzilla.redhat.com/1147261 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java A packaging/dbscripts/upgrade/03_05_1080_set_interleave_default_value_for_numa_tune_mode.sql 8 files changed, 58 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I637fb996d06e97d55bdd8309a668307cac8bb546 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Move cpu_over_commit from VdsDynamic to VdsStatistics
by tnisan＠redhat.com 05 Oct '14

05 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Move cpu_over_commit from VdsDynamic to VdsStatistics ...................................................................... core: Move cpu_over_commit from VdsDynamic to VdsStatistics cpu_over_commit field is rapidly changing, and should be located in VdsStatistics. This patch moves it to vds_statistics and updates the relevant stored procedures and DAOs Change-Id: I604132f9f05c8470ff09196db77eea2957899e2a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1114285 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatistics.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStatisticsDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializationEntitiesTest.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_05_1070_move_cpu_over_commit_to_vds_stats.sql M packaging/dbscripts/vds_sp.sql 10 files changed, 47 insertions(+), 44 deletions(-) Approvals: Roy Golan: Looks good to me, approved Liran Zelkha: Verified -- To view, visit http://gerrit.ovirt.org/33794 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I604132f9f05c8470ff09196db77eea2957899e2a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Handle NUMA preferred tune mode
by rgolan＠redhat.com 05 Oct '14

05 Oct '14

Roy Golan has submitted this change and it was merged. Change subject: core: Handle NUMA preferred tune mode ...................................................................... core: Handle NUMA preferred tune mode This patch addresses 3 issues: - 5892ef11 added NumaTuneMode to VmBase, so we need to update all VmStatic elements (VM templates) that was added since. - libvirt failure when running in preferred mode without specifying numa nodes. Added validation to add/edit VM to fail command when preferred numa tune set and there is no single VM node configured pinned to NUMA node. Change-Id: I637fb996d06e97d55bdd8309a668307cac8bb546 Bug-Url: https://bugzilla.redhat.com/1146445 Bug-Url: https://bugzilla.redhat.com/1147261 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java A packaging/dbscripts/upgrade/03_06_0420_set_interleave_default_value_for_numa_tune_mode.sql 8 files changed, 58 insertions(+), 0 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Gilad Chaplik: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33517 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I637fb996d06e97d55bdd8309a668307cac8bb546 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: avoid sending NUMA values if not specified
by rgolan＠redhat.com 05 Oct '14

05 Oct '14

Roy Golan has submitted this change and it was merged. Change subject: core: avoid sending NUMA values if not specified ...................................................................... core: avoid sending NUMA values if not specified Currently NUMA Tune Mode is sent even if VM doesn't have virtual NUMA nodes configured. Change-Id: I306a3004861295a6743288e5ed3a70cfdd49398d Bug-Url: https://bugzilla.redhat.com/1147261 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33731 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I306a3004861295a6743288e5ed3a70cfdd49398d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0