- Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.2]: build: post ovirt-hosted-engine-ha-1.2.2
by sbonazzo＠redhat.com 03 Oct '14

03 Oct '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-ha-1.2.2 ...................................................................... build: post ovirt-hosted-engine-ha-1.2.2 Change-Id: I30117140101b77f9b63d6d8518c80f2ac3b31b0e Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 9 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jiří Moskovčák: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33747 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30117140101b77f9b63d6d8518c80f2ac3b31b0e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Added "status" to the "Virtual Machine" entity obj...
by piotr.kliczewski＠gmail.com 03 Oct '14

03 Oct '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Added "status" to the "Virtual Machine" entity object. ...................................................................... webadmin: Added "status" to the "Virtual Machine" entity object. Added the "status" property to the "Virtual Machine" entity object to be used by the fix for the ui plugin ovirt-optimizer. Change-Id: I5801fe4bd1dffb3d39d122db6e66deb5c7cee385 Bug-Url: https://bugzilla.redhat.com/1140723 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> (cherry picked from commit 2ab2fcd8631068e3e7da1b58371d46c4f6d4c5ec) --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/entity/EntityObject.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33419 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5801fe4bd1dffb3d39d122db6e66deb5c7cee385 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: Replace "storage_manager" with "spm"
by piotr.kliczewski＠gmail.com 03 Oct '14

03 Oct '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: restapi: Replace "storage_manager" with "spm" ...................................................................... restapi: Replace "storage_manager" with "spm" Currently the SPM priority of a host is modeled in the RESTAPI as an attribute of an element that also has text content: <host> <storage_manager priority="5">true</storage_manager> </host> This means that it is impossible to send an udpate containing only the priority and not the text content. For example, a document like the following: <host> <storage_manager priority="5"/> </host> Is not valid because the text is declared as xs:boolean, and an empty text isn't a valid value. To avoid this issue this patch removes the "storage_manager" element from the RSDL metadata and introduces a new "spm" element that contains inner elements for the priority and the SPM status. For example: <host> <spm> <priority>5</priority> <status> <state>spm</state> </status> </spm> </host> This way clients can send updates for only the priority: <host> <spm> <priority>6</priority> </spm> </host> The previous "storage_manager" element and its behaviour are preserved for backwards compatibility, but removed from the RSDL metadata. Change-Id: I9bb8dba2385b1219f6d90fa99692a79fc7cb36b7 Bug-Url: https://bugzilla.redhat.com/1146457 Related-To: https://bugzilla.redhat.com/1136061 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 978491cf412c9a33b9fb8624a7d5c4592dc73c73) --- A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/SpmState.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java 6 files changed, 120 insertions(+), 6 deletions(-) Approvals: Juan Hernandez: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33364 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9bb8dba2385b1219f6d90fa99692a79fc7cb36b7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: Validate QoS type
by piotr.kliczewski＠gmail.com 03 Oct '14

03 Oct '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: restapi: Validate QoS type ...................................................................... restapi: Validate QoS type Currently when a QoS is added to a data center we don't validate that the mandatory type is specified. This eventually triggers a NPE when validating the value. To avoid this this patch adds the validation and modifies the type validator so that it won't fail if no type is provided. Change-Id: I90b62c4f4499dcc4abec5495a9907102e213df0e Bug-Url: https://bugzilla.redhat.com/1148773 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit ba3dbd7a4e7e8f516445a9717c9f7a74ddbfe90b) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQossResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/QosValidator.java 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Gilad Chaplik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33727 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90b62c4f4499dcc4abec5495a9907102e213df0e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: boot-protocol for VmInitNetwork
by piotr.kliczewski＠gmail.com 03 Oct '14

03 Oct '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: boot-protocol for VmInitNetwork ...................................................................... engine: boot-protocol for VmInitNetwork Needs to return STATIC instead of STATIC_IP Validate BootProtocol input. Bug-Url: https://bugzilla.redhat.com/1144005 Change-Id: I21f8a9cf509dd4d3d6e73a83ce9f66b183605161 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmInitNetwork.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/GuestNicConfigurationValidator.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/VmValidator.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 4 files changed, 33 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Shahar Havivi: Verified Omer Frenkel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21f8a9cf509dd4d3d6e73a83ce9f66b183605161 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Corrected ownership of the directories
by sbonazzo＠redhat.com 03 Oct '14

03 Oct '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: engine: Corrected ownership of the directories ...................................................................... engine: Corrected ownership of the directories Added entries for directories for correct ownership Change-Id: I946b446a908e4189e30fe60946e7946e4be384f7 Bug-Url: https://bugzilla.redhat.com/1104128 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31136 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I946b446a908e4189e30fe60946e7946e4be384f7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: build: ovirt-hosted-engine-setup-1.2.1
by sbonazzo＠redhat.com 03 Oct '14

03 Oct '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-setup-1.2.1 ...................................................................... build: ovirt-hosted-engine-setup-1.2.1 Change-Id: I00c599f202a071fb9336271b49216180ce55a66c Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-setup.spec.in 2 files changed, 9 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33748 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00c599f202a071fb9336271b49216180ce55a66c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: reduce autocompleter time in chrome
by awels＠redhat.com 02 Oct '14

02 Oct '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: reduce autocompleter time in chrome ...................................................................... webadmin: reduce autocompleter time in chrome - The profiler in chrome was indicating that the autocompleter was taking significant amounts of time during login. This time was taken mostly loading the exception handlers. I modified the code to not throw exceptions during the time of day lookup. Running the profiler in FF didn't seem to be affected by this. Change-Id: I3f9f0e26274caef5745d2adae9d573498ca6cf4c Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseAutoCompleter.java 1 file changed, 10 insertions(+), 6 deletions(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33683 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f9f0e26274caef5745d2adae9d573498ca6cf4c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Validate QoS type
by juan.hernandez＠redhat.com 02 Oct '14

02 Oct '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Validate QoS type ...................................................................... restapi: Validate QoS type Currently when a QoS is added to a data center we don't validate that the mandatory type is specified. This eventually triggers a NPE when validating the value. To avoid this this patch adds the validation and modifies the type validator so that it won't fail if no type is provided. Change-Id: I90b62c4f4499dcc4abec5495a9907102e213df0e Bug-Url: https://bugzilla.redhat.com/1148773 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQossResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/QosValidator.java 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Gilad Chaplik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90b62c4f4499dcc4abec5495a9907102e213df0e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core : Add custom error page for reports
by oourfali＠redhat.com 02 Oct '14

02 Oct '14

Oved Ourfali has submitted this change and it was merged. Change subject: core : Add custom error page for reports ...................................................................... core : Add custom error page for reports Custom error page for reports not installed error message Change-Id: Ic4489ef8a5a7d07734094e3c974fdaa215f44bef Bug-Url: https://bugzilla.redhat.com/1143998 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- A backend/manager/modules/welcome/src/main/webapp/WEB-INF/ReportsNotInstalled.jsp 1 file changed, 43 insertions(+), 0 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33724 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4489ef8a5a7d07734094e3c974fdaa215f44bef Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0