- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: aaa: filters: cleanup: use profile object directly
by yzaslavs＠redhat.com 14 Sep '14

14 Sep '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: filters: cleanup: use profile object directly ...................................................................... aaa: filters: cleanup: use profile object directly Change-Id: I2ba90ceadbcca5e63c85bf6b6f913dd0f5a147b0 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java 1 file changed, 6 insertions(+), 9 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32856 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ba90ceadbcca5e63c85bf6b6f913dd0f5a147b0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: cleanup: remove unused function
by yzaslavs＠redhat.com 14 Sep '14

14 Sep '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: cleanup: remove unused function ...................................................................... aaa: cleanup: remove unused function Topic: AAA Change-Id: I03ce61dbddc74704e641c43b0aa037c1b49c5319 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32805 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03ce61dbddc74704e641c43b0aa037c1b49c5319 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: ImportVmCommand storage allocation checks
by tnisan＠redhat.com 14 Sep '14

14 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: ImportVmCommand storage allocation checks ...................................................................... core: ImportVmCommand storage allocation checks This patch is a part of a series of patches, adding storage allocation validations to the system when they're missing, and replacing old verification usage with unified, new, correct and tested verification. This patch did this for ImportVmCommand, while added new space allocation validation to storage domain validators regarding snapshoted disks to be cloned with the spnapshots. Tests were amended accordingly. Change-Id: Ifbb1d985f9afa476452d1d2b78be1fd18c128c8f Bug-Url: https://bugzilla.redhat.com/1053746 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/StorageDomainValidatorFreeSpaceTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImageBase.java 9 files changed, 322 insertions(+), 62 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/32898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbb1d985f9afa476452d1d2b78be1fd18c128c8f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Add AddVmTemplateCommand to command executer framework
by shavivi＠redhat.com 14 Sep '14

14 Sep '14

Shahar Havivi has submitted this change and it was merged. Change subject: engine: Add AddVmTemplateCommand to command executer framework ...................................................................... engine: Add AddVmTemplateCommand to command executer framework By adding AddVmTemplateCommand we can determine whether we need to delete the template if the command failed. Bug-Url: https://bugzilla.redhat.com/1105211 Change-Id: Ib47982264f535dcf38cd4f9319f842d75ebccd5d Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java 1 file changed, 8 insertions(+), 5 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Shahar Havivi: Verified Omer Frenkel: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib47982264f535dcf38cd4f9319f842d75ebccd5d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: ImportVmCommand storage allocation checks
by amureini＠redhat.com 14 Sep '14

14 Sep '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImportVmCommand storage allocation checks ...................................................................... core: ImportVmCommand storage allocation checks This patch is a part of a series of patches, adding storage allocation validations to the system when they're missing, and replacing old verification usage with unified, new, correct and tested verification. This patch did this for ImportVmCommand, while added new space allocation validation to storage domain validators regarding snapshoted disks to be cloned with the spnapshots. Tests were amended accordingly. Change-Id: Ifbb1d985f9afa476452d1d2b78be1fd18c128c8f Bug-Url: https://bugzilla.redhat.com/1053746 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/StorageDomainValidatorFreeSpaceTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImageBase.java 9 files changed, 324 insertions(+), 64 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/32258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbb1d985f9afa476452d1d2b78be1fd18c128c8f Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fixing bug no validation AddSubnetToProvider
by lvernia＠redhat.com 14 Sep '14

14 Sep '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: fixing bug no validation AddSubnetToProvider ...................................................................... webadmin: fixing bug no validation AddSubnetToProvider validating subnet fields are valid before preforming command Change-Id: Iaac8748c9b47dfc7a622efaa887980333f5bc56d Bug-Url: https://bugzilla.redhat.com/1138981 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eliraz Levi: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32565 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaac8748c9b47dfc7a622efaa887980333f5bc56d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: positive affinity breaks maintenancing a host
by gchaplik＠redhat.com 14 Sep '14

14 Sep '14

Gilad Chaplik has submitted this change and it was merged. Change subject: core: positive affinity breaks maintenancing a host ...................................................................... core: positive affinity breaks maintenancing a host I feel that this is best to describe with an example: vm1, vm2 running with enforcing positive affinity group on host A. When putting host A to maintenance, both VMs will try to migrate, and fail because they're violating the affinity constraints. the host is stuck on preparing for maint. The fix ignores the host when it's in preparing for maint status. Change-Id: I7282a9e1c87b30c14869170ed7fb5b9276fad33e Bug-Url: https://bugzilla.redhat.com/1084794 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityFilterPolicyUnit.java 1 file changed, 9 insertions(+), 6 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Gilad Chaplik: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26623 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7282a9e1c87b30c14869170ed7fb5b9276fad33e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Add missing VDSM error message
by tnisan＠redhat.com 14 Sep '14

14 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Add missing VDSM error message ...................................................................... core: Add missing VDSM error message Added StorageDomainTargetUnsupported message which was missing from the VDSM error message in core and webadmin Change-Id: Icef1c04f1252722f12431000d8464359efb72a92 Bug-Url: https://bugzilla.redhat.com/985437 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 4 files changed, 5 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32887 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icef1c04f1252722f12431000d8464359efb72a92 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add missing VDSM error message
by tnisan＠redhat.com 14 Sep '14

14 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Add missing VDSM error message ...................................................................... core: Add missing VDSM error message Added StorageDomainTargetUnsupported message which was missing from the VDSM error message in core and webadmin Change-Id: Icef1c04f1252722f12431000d8464359efb72a92 Bug-Url: https://bugzilla.redhat.com/985437 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 4 files changed, 5 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32813 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icef1c04f1252722f12431000d8464359efb72a92 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Represent slave's mac in lower case
by tnisan＠redhat.com 14 Sep '14

14 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: Represent slave's mac in lower case ...................................................................... engine: Represent slave's mac in lower case slave's mac in older vdsm versions, is in upper case, resulting slave's mac is saved and represented in upper case Change-Id: Ibfebc2aea4bc3605253bfb072fc4ad19c0fd2270 Bug-Url: https://bugzilla.redhat.com/1132422 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Eliraz Levi: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32885 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibfebc2aea4bc3605253bfb072fc4ad19c0fd2270 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0