- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Parameterize ImportNetworksModel and related classes
by lvernia＠redhat.com 14 Sep '14

14 Sep '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Parameterize ImportNetworksModel and related classes ...................................................................... webadmin: Parameterize ImportNetworksModel and related classes Parameterized generic instances of ListModel in ImportNetworksModel, as well as the corresponding view and widget used in that view (and nowhere else at the moment, which made things easier). ExternalNetwork is changed to extend Model instead of EntityModel (as it used no special capabilities of EntityModel). Change-Id: I4d1e6e409edc794baa799807268755105f8e21fa Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HorizontalSplitTable.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/DiscoverNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ExternalNetwork.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ImportNetworksPopupView.java 5 files changed, 91 insertions(+), 92 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/31351 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d1e6e409edc794baa799807268755105f8e21fa Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Cleanup around Setup Networks events
by lvernia＠redhat.com 14 Sep '14

14 Sep '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Cleanup around Setup Networks events ...................................................................... webadmin: Cleanup around Setup Networks events * Removed NetworksChanged event that wasn't used for anything. * Parameterized generic events. * Fixed typo in OperationCandidateEventArgs name. Change-Id: I23945cb33eea895b216ab78fbbca5a6a26300c7c Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java R frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/OperationCandidateEventArgs.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.java 3 files changed, 23 insertions(+), 36 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/31509 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I23945cb33eea895b216ab78fbbca5a6a26300c7c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Disable buttons on ghost entry
by lvernia＠redhat.com 14 Sep '14

14 Sep '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Disable buttons on ghost entry ...................................................................... webadmin: Disable buttons on ghost entry A relatively recent refactoring/enhancement caused a small regression in several widgets, this is now fixed by calling superclass implementation of toggleGhost() (or not overriding it to do nothing). That patch wasn't pushed to ovirt-engine-3.5, so this is not an issue there. Change-Id: Iafe35b1f4bdbee8068ea79629342518ca3405a62 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/DnsServersWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfilesEditor.java 3 files changed, 1 insertion(+), 10 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/32404 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iafe35b1f4bdbee8068ea79629342518ca3405a62 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-node-plugin-vdsm[ovirt-3.5]: engine_page: augeas set copy_if_rename_fails
by dougsland＠redhat.com 12 Sep '14

12 Sep '14

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: engine_page: augeas set copy_if_rename_fails ...................................................................... engine_page: augeas set copy_if_rename_fails Avoid issues with bind mounting before editing files. Change-Id: Ic500a92aaff60a24d5d1dbd444b3397e9706a198 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32878 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic500a92aaff60a24d5d1dbd444b3397e9706a198 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-node-plugin-vdsm[master]: engine_page: augeas set copy_if_rename_fails
by rbarry＠redhat.com 12 Sep '14

12 Sep '14

Ryan Barry has submitted this change and it was merged. Change subject: engine_page: augeas set copy_if_rename_fails ...................................................................... engine_page: augeas set copy_if_rename_fails Avoid issues with bind mounting before editing files. Change-Id: Ic500a92aaff60a24d5d1dbd444b3397e9706a198 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Ryan Barry: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32877 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic500a92aaff60a24d5d1dbd444b3397e9706a198 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-live[ovirt-live-3.5]: Revert "drop post chroot install of yad"
by sbonazzo＠redhat.com 12 Sep '14

12 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: Revert "drop post chroot install of yad" ...................................................................... Revert "drop post chroot install of yad" This reverts commit 56ac3262dbdee9dc533bbca62adc7d1a7d67147a. Looks like jenkins job fails with this also if local build works fine for me. Change-Id: Id1c3f89d51752c4849a81b9b9ae28035dbeefb99 --- M centos/kickstart/ovirt-live-ovirt-custom.ks.in A centos/oVirtLiveFiles/rpms/repodata/283c3ad68f6590ab7be9b55d6cbcec4f8801c7fc9d6a3a029aef282a15cca8bc-filelists.sqlite.bz2 A centos/oVirtLiveFiles/rpms/repodata/5f443c702d353ece1e70fb6fdcd957f8b51ca48d377285bd7e5deaf4fcb8e527-filelists.xml.gz A centos/oVirtLiveFiles/rpms/repodata/61e4ecd65729eea3ea701911223debda48c620c0a31958e89ca1c3fd7b6910ef-other.sqlite.bz2 A centos/oVirtLiveFiles/rpms/repodata/80a0c9d20118ed501861cc4dfd635020d432e212ade5611d14f7f461e2e911ce-other.xml.gz A centos/oVirtLiveFiles/rpms/repodata/89b0b69ff746917b3c41818919953e694b15aff5a5c8bb963d275ffd3c49c03c-primary.xml.gz A centos/oVirtLiveFiles/rpms/repodata/dea2d8919301bd2ac8b65441596d06f69c551f380b5c99ba42fac792896438c8-primary.sqlite.bz2 A centos/oVirtLiveFiles/rpms/repodata/repomd.xml A centos/oVirtLiveFiles/rpms/yad-0.14.2-1.fc14.x86_64.rpm 9 files changed, 56 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1c3f89d51752c4849a81b9b9ae28035dbeefb99 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[master]: Revert "drop post chroot install of yad"
by sbonazzo＠redhat.com 12 Sep '14

12 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: Revert "drop post chroot install of yad" ...................................................................... Revert "drop post chroot install of yad" This reverts commit a5adfd1e06c079324db765b31eb73bc39f73f590. Looks like jenkins job fails with this also if local build works fine for me. Change-Id: Ifa281a1716283ea338019d050080a0e3fbc32f79 --- M centos/kickstart/ovirt-live-ovirt-custom.ks.in A centos/oVirtLiveFiles/rpms/repodata/283c3ad68f6590ab7be9b55d6cbcec4f8801c7fc9d6a3a029aef282a15cca8bc-filelists.sqlite.bz2 A centos/oVirtLiveFiles/rpms/repodata/5f443c702d353ece1e70fb6fdcd957f8b51ca48d377285bd7e5deaf4fcb8e527-filelists.xml.gz A centos/oVirtLiveFiles/rpms/repodata/61e4ecd65729eea3ea701911223debda48c620c0a31958e89ca1c3fd7b6910ef-other.sqlite.bz2 A centos/oVirtLiveFiles/rpms/repodata/80a0c9d20118ed501861cc4dfd635020d432e212ade5611d14f7f461e2e911ce-other.xml.gz A centos/oVirtLiveFiles/rpms/repodata/89b0b69ff746917b3c41818919953e694b15aff5a5c8bb963d275ffd3c49c03c-primary.xml.gz A centos/oVirtLiveFiles/rpms/repodata/dea2d8919301bd2ac8b65441596d06f69c551f380b5c99ba42fac792896438c8-primary.sqlite.bz2 A centos/oVirtLiveFiles/rpms/repodata/repomd.xml A centos/oVirtLiveFiles/rpms/yad-0.14.2-1.fc14.x86_64.rpm 9 files changed, 56 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32872 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa281a1716283ea338019d050080a0e3fbc32f79 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[ovirt-live-3.5]: build: oVirt Live 3.5.0 RC2
by sbonazzo＠redhat.com 12 Sep '14

12 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: oVirt Live 3.5.0 RC2 ...................................................................... build: oVirt Live 3.5.0 RC2 Change-Id: I1ac2d096f96e05857d7b0f616f831f3003ce1f90 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/Makefile M centos/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 4 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32862 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ac2d096f96e05857d7b0f616f831f3003ce1f90 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[ovirt-live-3.5]: drop post chroot install of yad
by sbonazzo＠redhat.com 12 Sep '14

12 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: drop post chroot install of yad ...................................................................... drop post chroot install of yad yad is already installed by the kickstart using 0.27.0. No reason to try to update to a legacy version. Change-Id: I4fc06e99b86778f1829882b195282d53916e44db Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/kickstart/ovirt-live-ovirt-custom.ks.in D centos/oVirtLiveFiles/rpms/repodata/283c3ad68f6590ab7be9b55d6cbcec4f8801c7fc9d6a3a029aef282a15cca8bc-filelists.sqlite.bz2 D centos/oVirtLiveFiles/rpms/repodata/5f443c702d353ece1e70fb6fdcd957f8b51ca48d377285bd7e5deaf4fcb8e527-filelists.xml.gz D centos/oVirtLiveFiles/rpms/repodata/61e4ecd65729eea3ea701911223debda48c620c0a31958e89ca1c3fd7b6910ef-other.sqlite.bz2 D centos/oVirtLiveFiles/rpms/repodata/80a0c9d20118ed501861cc4dfd635020d432e212ade5611d14f7f461e2e911ce-other.xml.gz D centos/oVirtLiveFiles/rpms/repodata/89b0b69ff746917b3c41818919953e694b15aff5a5c8bb963d275ffd3c49c03c-primary.xml.gz D centos/oVirtLiveFiles/rpms/repodata/dea2d8919301bd2ac8b65441596d06f69c551f380b5c99ba42fac792896438c8-primary.sqlite.bz2 D centos/oVirtLiveFiles/rpms/repodata/repomd.xml D centos/oVirtLiveFiles/rpms/yad-0.14.2-1.fc14.x86_64.rpm 9 files changed, 0 insertions(+), 56 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32866 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fc06e99b86778f1829882b195282d53916e44db Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[ovirt-live-3.5]: network: updated network configuration
by sbonazzo＠redhat.com 12 Sep '14

12 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: network: updated network configuration ...................................................................... network: updated network configuration Updated network configuration for matching new requirements for vdsm and ovirt-engine. Fixes permissions on network scripts files. Change-Id: I17f6df9a8fa5c74b8110d9db593601aad1b7af32 Bug-Url: https://bugzilla.redhat.com/1139687 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/kickstart/ovirt-live-ovirt-custom.ks.in M centos/oVirtLiveFiles/root/etc/sysconfig/network-scripts/ifcfg-dummy0 M centos/oVirtLiveFiles/root/etc/sysconfig/network-scripts/ifcfg-ovirtmgmt A centos/oVirtLiveFiles/root/etc/sysconfig/network-scripts/route-ovirtmgmt A centos/oVirtLiveFiles/root/etc/sysconfig/network-scripts/rule-ovirtmgmt 5 files changed, 17 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32861 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17f6df9a8fa5c74b8110d9db593601aad1b7af32 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0