- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Data storage domain does not always activate when ...
by tnisan＠redhat.com 10 Sep '14

10 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Data storage domain does not always activate when created ...................................................................... webadmin: Data storage domain does not always activate when created When importing an ISO storage domain without the activation flag and then immediately creating a data storage domain, the data storage domain is added in maintenance mode Bug-Url: https://bugzilla.redhat.com/1116572 Change-Id: I70eaabbfd1453276219c0e0f8f0cbf4ca5df1a55 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 6 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70eaabbfd1453276219c0e0f8f0cbf4ca5df1a55 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin, userportal: fixed spacing for grids
by awels＠redhat.com 10 Sep '14

10 Sep '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin, userportal: fixed spacing for grids ...................................................................... webadmin, userportal: fixed spacing for grids CSS for first columns in all grids was broken such that left padding wasn't applied. Fixed. Also added a bit more padding between cells to prevent text in adjacent cells from being 0 pixels apart. Also noticed that icons in grids (comment icon, VM circle icon, etc.) were not centered. Fixed. Change-Id: Id5a759b8208b17bb9378a8b3f3362c20ca02add9 Bug-Url: https://bugzilla.redhat.com/1131975 Bug-Url: https://bugzilla.redhat.com/1127674 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/TabCellTable.css 1 file changed, 13 insertions(+), 9 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/32022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5a759b8208b17bb9378a8b3f3362c20ca02add9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: check storage domains status on master deactivation
by amureini＠redhat.com 10 Sep '14

10 Sep '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: check storage domains status on master deactivation ...................................................................... core: check storage domains status on master deactivation When deactivating the master storage domain we should make sure that the other domains are not in transition. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1128824 Change-Id: I28228f2ad3ce555aafc9ea03d44aebeb12bbf0cf Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Federico Simoncelli: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32517 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28228f2ad3ce555aafc9ea03d44aebeb12bbf0cf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Fix typo for QoS
by tnisan＠redhat.com 10 Sep '14

10 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix typo for QoS ...................................................................... webadmin: Fix typo for QoS Fixed the "Write IOps" column from "Read IOps" -> "Write IOps". Change-Id: Ic65a15815cc276cd3ec9d0290946a97813c7a434 Bug-Url: https://bugzilla.redhat.com/1139731 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Looks good to me, approved Tomer Saban: Verified -- To view, visit http://gerrit.ovirt.org/32777 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic65a15815cc276cd3ec9d0290946a97813c7a434 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine : Persist Async Task root command in command_entities
by tnisan＠redhat.com 10 Sep '14

10 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: engine : Persist Async Task root command in command_entities ...................................................................... engine : Persist Async Task root command in command_entities Persist async task's root command information in command entities table. Modifies the async tasks table and store the root command id and action type in the async_tasks table and all other information needs to rebuild the root command in the command entities table. The action type is left in the async task table to enable upgrading from 3.4 to 3.5.1 or later Change-Id: I7ec5c072c6f3153c9396b0ce0be8e7c59cbefea1 Bug-Url: https://bugzilla.redhat.com/1133041 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandAsyncTask.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorUtil.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/SPMAsyncTask.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/AsyncTaskCRUDOperations.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCRUDOperations.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/TaskHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/AsyncTaskParameters.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AsyncTask.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AsyncTaskDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M packaging/dbscripts/async_tasks_sp.sql A packaging/dbscripts/upgrade/03_05_1050_async_tasks_add_root_command_id.sql 22 files changed, 355 insertions(+), 303 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ec5c072c6f3153c9396b0ce0be8e7c59cbefea1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine : Add custom json deserializer for VdcActionType
by tnisan＠redhat.com 10 Sep '14

10 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: engine : Add custom json deserializer for VdcActionType ...................................................................... engine : Add custom json deserializer for VdcActionType If a VdcActionType is removed json deserialization of VdcActionType fails leading to exceptions in Commands Cache initialization. Change-Id: Ia8236c4f57ceea557b1e60aa7c40e180c0a43b98 Bug-Url: https://bugzilla.redhat.com/1133041 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonVdcActionParametersBaseMixIn.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/VdcActionTypeDeserializer.java 2 files changed, 38 insertions(+), 0 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32719 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8236c4f57ceea557b1e60aa7c40e180c0a43b98 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Report unreachable domain names when setting host as n...
by tnisan＠redhat.com 10 Sep '14

10 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Report unreachable domain names when setting host as non operational ...................................................................... core: Report unreachable domain names when setting host as non operational When setting a host as non operational because an error reaching one storage domain, the audit log will now report the name of the unreachable storage domains Change-Id: I6b68d1c2a387c84e97137b27f00956870fd96357 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1116820 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32712 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b68d1c2a387c84e97137b27f00956870fd96357 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix typo for QoS
by gchaplik＠redhat.com 10 Sep '14

10 Sep '14

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Fix typo for QoS ...................................................................... webadmin: Fix typo for QoS Fixed the "Write IOps" column from "Read IOps" -> "Write IOps". Change-Id: Ic65a15815cc276cd3ec9d0290946a97813c7a434 Bug-Url: https://bugzilla.redhat.com/1139731 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomer Saban: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32755 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic65a15815cc276cd3ec9d0290946a97813c7a434 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: Fix group name issues for legacy provider
by yzaslavs＠redhat.com 10 Sep '14

10 Sep '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Fix group name issues for legacy provider ...................................................................... aaa: Fix group name issues for legacy provider Chagning format from: authz/a/b/c/d to: a/b/c/d@authz to conform to the users format. Removed specific code at rest-api that handled old format. Change-Id: I8c1feed08e33156c794b230fa04f33f2ebd82240 Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthz.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapBrokerUtils.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendGroupsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUsersResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/aaa/BackendGroupsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUsersResourceTest.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/aaa/AuthzUtils.java 7 files changed, 125 insertions(+), 58 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32652 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c1feed08e33156c794b230fa04f33f2ebd82240 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.2]: use blank storage pool when connecting the volumes
by msivak＠redhat.com 10 Sep '14

10 Sep '14

Martin Sivák has submitted this change and it was merged. Change subject: use blank storage pool when connecting the volumes ...................................................................... use blank storage pool when connecting the volumes We're not connected to a pool. To prepare an image when you're not connected to a pool (general HE use case) you should specify a blank pool uuid (00000000-0000-0000-0000-000000000000) Change-Id: I3d7683b8dd10097344cb1d5fd036e549fc25ef8c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1129261 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/storage_backends.py 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jiří Moskovčák: Verified -- To view, visit http://gerrit.ovirt.org/32689 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d7683b8dd10097344cb1d5fd036e549fc25ef8c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.2 Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0