- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: RegisterVmInfoPanel - getAppList nullity check
by derez＠redhat.com 10 Sep '14

10 Sep '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: RegisterVmInfoPanel - getAppList nullity check ...................................................................... webadmin: RegisterVmInfoPanel - getAppList nullity check RegisterVmInfoPanel -> updateTabsData -> vm.getAppList() might return null on new VMs. Change-Id: I78346b1df26b203e5075385c0c7e67e8bd4c3344 Related-To-Bug-Url: https://bugzilla.redhat.com/1136756 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/RegisterVmInfoPanel.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/32578 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78346b1df26b203e5075385c0c7e67e8bd4c3344 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: register VM dialog - select first VM
by derez＠redhat.com 10 Sep '14

10 Sep '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: register VM dialog - select first VM ...................................................................... webadmin: register VM dialog - select first VM Register VM/Template dialog: select first entity by default. Change-Id: I55411454fedbc97deed2b4a30c759be69e198fc7 Bug-Url: https://bugzilla.redhat.com/1136756 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/RegisterEntityPopupView.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/32579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55411454fedbc97deed2b4a30c759be69e198fc7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: explicit warning on live snapshot failure
by derez＠redhat.com 10 Sep '14

10 Sep '14

Daniel Erez has submitted this change and it was merged. Change subject: core: explicit warning on live snapshot failure ...................................................................... core: explicit warning on live snapshot failure On live snapshot failure, added an explicit warning stating that using the created snapshot might cause data inconsistency. Change-Id: Ib91c9d947a90e3b8fdd872bb3996dfb839e7767a Bug-Url: https://bugzilla.redhat.com/1119203 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32580 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib91c9d947a90e3b8fdd872bb3996dfb839e7767a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: optional parameter storageFormatType not sent to vdsm
by oourfali＠redhat.com 10 Sep '14

10 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: optional parameter storageFormatType not sent to vdsm ...................................................................... core: optional parameter storageFormatType not sent to vdsm storageFormatType is marked in jsonrpc schema as optional but it was not sent when the value was provided. Bug-Url: https://bugzilla.redhat.com/1139817 Change-Id: Ia09978bcd9228591735a15a8d4a827db9f1b3ef2 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> (cherry picked from commit f0e4080195417f062dcb19923ed405962a756cbf) --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia09978bcd9228591735a15a8d4a827db9f1b3ef2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>

1 0

Change in ovirt-engine[master]: core: optional parameter storageFormatType not sent to vdsm
by oourfali＠redhat.com 10 Sep '14

10 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: optional parameter storageFormatType not sent to vdsm ...................................................................... core: optional parameter storageFormatType not sent to vdsm storageFormatType is marked in jsonrpc schema as optional but it was not sent when the value was provided. Bug-Url: https://bugzilla.redhat.com/1139817 Change-Id: Ia09978bcd9228591735a15a8d4a827db9f1b3ef2 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Piotr Kliczewski: Verified Allon Mureinik: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32739 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia09978bcd9228591735a15a8d4a827db9f1b3ef2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: introduce AddVmParameters
by ahadas＠redhat.com 10 Sep '14

10 Sep '14

Arik Hadas has submitted this change and it was merged. Change subject: core: introduce AddVmParameters ...................................................................... core: introduce AddVmParameters As a step in the way for having one parameters class for AddVmCommand + AddVmFromTemplate + AddVmFromScratch, AddVmFromScratchParameters is renamed to AddVmParameters. Change-Id: Ia5b2f28897c6017a38e30db88918af6225e1cb3d Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmAndAttachToPoolParameters.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 9 files changed, 25 insertions(+), 26 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Juan Hernandez: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/32640 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5b2f28897c6017a38e30db88918af6225e1cb3d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: extmgr: raise config exception if requested extension is null
by tnisan＠redhat.com 10 Sep '14

10 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: extmgr: raise config exception if requested extension is null ...................................................................... extmgr: raise config exception if requested extension is null Topic: AAA Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1139671 Change-Id: Ie32e829d4a8c0790b2769169e0c8c793d4d71ba3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie32e829d4a8c0790b2769169e0c8c793d4d71ba3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fixing fencing flow for blocked proxy
by oourfali＠redhat.com 10 Sep '14

10 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: fixing fencing flow for blocked proxy ...................................................................... core: fixing fencing flow for blocked proxy This patch fixes the following scenario : DC1 with H1 (with PM) and H2 on cluster C1 another host H3 on DC1 cluster C2 When we are blocking the communication with iptables from H2 to H1 PM card and use the default proxy preferences (cluster, dc) a Restart operation will always fail. The fix relies on the return code from the script that was executed by VDSM rather than the proceedProxyReturnValue call that throws an exception and also set the execution result according to that code. In addition a missing initialization of the 'count' variable in the 'for' loop has been added. This BZ depends also in a VDSM fix that makes stop/start operation sync instead of fire-and-forget. Change-Id: I70d35967554c88c943c4653a26642e6e21cc54d2 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1129381 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FenceVdsVDSCommand.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32692 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70d35967554c88c943c4653a26642e6e21cc54d2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: avoid duplicate keys in answerfile
by tnisan＠redhat.com 10 Sep '14

10 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: avoid duplicate keys in answerfile ...................................................................... packaging: setup: avoid duplicate keys in answerfile Avoiding duplicate keys in answerfile. Change-Id: I96504ec0fc6112dfeb539294f84ce2294d1b2850 Bug-Url: https://bugzilla.redhat.com/1118335 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/base/core/answerfile.py 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/32655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96504ec0fc6112dfeb539294f84ce2294d1b2850 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Re-assign roles when network is detached
by tnisan＠redhat.com 10 Sep '14

10 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Re-assign roles when network is detached ...................................................................... webadmin: Re-assign roles when network is detached When a network is detached from a cluster, we make sure to visibly re-assign those roles to the management network. Change-Id: I72a9b4a46a32014b31f8981fbe0e8750352dd80e Bug-Url: https://bugzilla.redhat.com/1135785 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkManageModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java 2 files changed, 54 insertions(+), 16 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/32638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72a9b4a46a32014b31f8981fbe0e8750352dd80e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0