- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Fixing events search with from keyword
by oourfali＠redhat.com 04 Sep '14

04 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Fixing events search with from keyword ...................................................................... core: Fixing events search with from keyword using from filter in an event search doesn't work Restoring support of 'from' clause for event search. Change-Id: I1c31ae7953fa4921fd912e4a7b94d3081d4e09a1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1131030 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32486 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c31ae7953fa4921fd912e4a7b94d3081d4e09a1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Added tests for validation on managed custom mount option
by tnisan＠redhat.com 04 Sep '14

04 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Added tests for validation on managed custom mount option ...................................................................... core: Added tests for validation on managed custom mount option Change-Id: I678e116b8a534b69f87be59f9be8813b08cb6910 Bug-Url: https://bugzilla.redhat.com/1129597 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageServerConnectionTestCommon.java 3 files changed, 92 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32373 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I678e116b8a534b69f87be59f9be8813b08cb6910 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Added validation on managed custom mount option
by tnisan＠redhat.com 04 Sep '14

04 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Added validation on managed custom mount option ...................................................................... core: Added validation on managed custom mount option When adding a new NFS/Posix storage server connection, if the custom mount options contains a managed option (i.e. property that the engine is managing directly), the command will fail with a CDA Change-Id: Icc5a74379de55aa81194298be634f689efd331d5 Bug-Url: https://bugzilla.redhat.com/1129597 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 40 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32372 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc5a74379de55aa81194298be634f689efd331d5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Consolidated common test of add/update storage connection
by tnisan＠redhat.com 04 Sep '14

04 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Consolidated common test of add/update storage connection ...................................................................... core: Consolidated common test of add/update storage connection AddStorageServerConnection and UpdateStorageServerConnection command tests contained simiar tests, those common tests were extracted to a parent test class for better readability and easier maintenance Change-Id: Iad571ca0c5788c375200847e8872706a8dfd7f3e Bug-Url: https://bugzilla.redhat.com/1129597 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageServerConnectionTestCommon.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommandTest.java 3 files changed, 148 insertions(+), 195 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32371 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad571ca0c5788c375200847e8872706a8dfd7f3e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Consolidated similar validations in add/update storage...
by tnisan＠redhat.com 04 Sep '14

04 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Consolidated similar validations in add/update storage connection CDA ...................................................................... core: Consolidated similar validations in add/update storage connection CDA AddStorageServerConnection & UpdateStorageServerConnection command both contained a lot of similar validations in the CDA part, all those validations were extracted to the parent class for better readability and easier maintenance Change-Id: Id90cea934e0a9c10c5df435f564530b8658a64bb Bug-Url: https://bugzilla.redhat.com/1129597 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java 3 files changed, 31 insertions(+), 45 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32202 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id90cea934e0a9c10c5df435f564530b8658a64bb Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: fixed context-sensitive help icon
by tnisan＠redhat.com 04 Sep '14

04 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: fixed context-sensitive help icon ...................................................................... webadmin: fixed context-sensitive help icon commit 42e9396 broke the context-sensitive help icon. Fixed. Also moved the header text up one pixel to align with the fixed icon. Bug-Url: https://bugzilla.redhat.com/1119027 Change-Id: Iff8f6605a89dad1f57b15a63de2ffa8e67825418 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.ui.xml M packaging/branding/ovirt.brand/common.css M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 4 files changed, 22 insertions(+), 10 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/32426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff8f6605a89dad1f57b15a63de2ffa8e67825418 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: call validation when creating/editing Provider URL for Netwo...
by tnisan＠redhat.com 04 Sep '14

04 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: call validation when creating/editing Provider URL for Network Provider ...................................................................... call validation when creating/editing Provider URL for Network Provider added call to validate connection details when testing settings from ProviderModel. Change-Id: I0b9e9a6b66d800c973334629fa34b3b5443290df Bug-Url: https://bugzilla.redhat.com/1111974 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java 1 file changed, 18 insertions(+), 3 deletions(-) Approvals: Martin Mucha: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32220 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b9e9a6b66d800c973334629fa34b3b5443290df Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: fix alignment in New Cluster dialog / Optimization
by tnisan＠redhat.com 04 Sep '14

04 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: fix alignment in New Cluster dialog / Optimization ...................................................................... webadmin: fix alignment in New Cluster dialog / Optimization New Cluster dialog / Optimization tab had alignment and spacing issues. Fixed. Change-Id: Iae1712442dec2988e51312461df4c8669441f4ea Bug-Url: https://bugzilla.redhat.com/1123319 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml 3 files changed, 18 insertions(+), 15 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/32433 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae1712442dec2988e51312461df4c8669441f4ea Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Adjust network panel height to fit arrows
by tnisan＠redhat.com 04 Sep '14

04 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Adjust network panel height to fit arrows ...................................................................... webadmin: Adjust network panel height to fit arrows The network panels were a little short compared to the arrows in the Setup Networks dialog, which caused them to go out of alignment (more noticeable as more networks are attached to the same interface). Change-Id: I55a74d41c71e7153169e077fb61813b916e5d7c6 Bug-Url: https://bugzilla.redhat.com/1120660 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> (cherry picked from commit fa4138234896897c96db904e6863fee44f7cd4df) --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/arrow_right_bottom.png M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/arrow_right_top.png 3 files changed, 2 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/32386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55a74d41c71e7153169e077fb61813b916e5d7c6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: correctly writing pg_hba.conf
by sbonazzo＠redhat.com 04 Sep '14

04 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: correctly writing pg_hba.conf ...................................................................... packaging: setup: correctly writing pg_hba.conf Fixing the parameter order writing pg_hba.conf Change-Id: I6a75084ec5134570f0c27b60214db00813651370 Bug-Url: http://bugzilla.redhat.com/1134444 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine_common/postgres.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32042 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a75084ec5134570f0c27b60214db00813651370 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0