- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core: Remove remains of version 2.2 from FencingPolicyHelper
by tnisan＠redhat.com 04 Sep '14

04 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove remains of version 2.2 from FencingPolicyHelper ...................................................................... core: Remove remains of version 2.2 from FencingPolicyHelper Removes unnecessary condtions from FencingPolicyHelper class which was needed when 2.2 was containt in Version.ALL list. Change-Id: Iba815fc8a35969917360fea1eccc646e679426b8 Bug-Url: https://bugzilla.redhat.com/1127590 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/FencingPolicyHelper.java 1 file changed, 2 insertions(+), 6 deletions(-) Approvals: Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32432 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba815fc8a35969917360fea1eccc646e679426b8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Remove version 2.2 from Version and VersionStorageForm...
by tnisan＠redhat.com 04 Sep '14

04 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove version 2.2 from Version and VersionStorageFormatUtil ...................................................................... core: Remove version 2.2 from Version and VersionStorageFormatUtil Remove last usage of version 2.2 from VersionStorageFormatUtil and Version classes. Change-Id: Id43f292215cf35c1e2834c2a2fdac6b08a3bdb2b Bug-Url: https://bugzilla.redhat.com/1127590 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VersionStorageFormatUtil.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java 2 files changed, 1 insertion(+), 3 deletions(-) Approvals: Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32431 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id43f292215cf35c1e2834c2a2fdac6b08a3bdb2b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Remove version 2.2 checks in DataCenterStorageListModel
by tnisan＠redhat.com 04 Sep '14

04 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove version 2.2 checks in DataCenterStorageListModel ...................................................................... core: Remove version 2.2 checks in DataCenterStorageListModel Removes version 2.2 checks related to storage format type in DataCenterStorageListModel. Change-Id: Ida6c034172e797ab4460cd954958663e4d112c12 Bug-Url: https://bugzilla.redhat.com/1127590 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32430 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida6c034172e797ab4460cd954958663e4d112c12 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Use version 3.0 instead of 2.2 UpdateVmCommandTest
by tnisan＠redhat.com 04 Sep '14

04 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Use version 3.0 instead of 2.2 UpdateVmCommandTest ...................................................................... core: Use version 3.0 instead of 2.2 UpdateVmCommandTest Uses version 3.0 instead of 2.2 for minimal supported cluster level version in UpdateVmCommandTest. Change-Id: I7caebd147a47e1874e3327ce99df4a2de25c51f0 Bug-Url: https://bugzilla.redhat.com/1127590 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32429 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7caebd147a47e1874e3327ce99df4a2de25c51f0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Use version 3.0 instead of 2.2 in GetCommandsCompatibi...
by tnisan＠redhat.com 04 Sep '14

04 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Use version 3.0 instead of 2.2 in GetCommandsCompatibilityVersionsQueryTest ...................................................................... core: Use version 3.0 instead of 2.2 in GetCommandsCompatibilityVersionsQueryTest Uses version 3.0 instead of 2.2 for testing minimal compatibility version in GetCommandsCompatibilityVersionsQueryTest. Change-Id: I8b0236bf3ca6360d3fa483df9f23e5a1fe37457d Bug-Url: https://bugzilla.redhat.com/1127590 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetCommandsCompatibilityVersionsQueryTest.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32428 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b0236bf3ca6360d3fa483df9f23e5a1fe37457d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: StoragePoolValidatorTest config mocking
by tnisan＠redhat.com 04 Sep '14

04 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: StoragePoolValidatorTest config mocking ...................................................................... core: StoragePoolValidatorTest config mocking Removed redundant mocking that's not used in the test and streamlined the existing mocking to use two version - 3.0 as an "old" version which does not support new features and 3.1 and a "new" version which does. Bug-Url: https://bugzilla.redhat.com/1127590 Change-Id: If916e1080686ec037dba6f79264307e73b1502d2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StoragePoolValidatorTest.java 1 file changed, 12 insertions(+), 13 deletions(-) Approvals: Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32427 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If916e1080686ec037dba6f79264307e73b1502d2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Decrease updates to VdsDynamic
by oourfali＠redhat.com 04 Sep '14

04 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Decrease updates to VdsDynamic ...................................................................... core: Decrease updates to VdsDynamic VdsDynamic updates are heavy on the database. This patch minimizes these writes by fixing some issues with VdsDynamic equals method and improving the RowMapper of VdsDynamic to include all fields. A future patch will move cpu_over_ commitment to VdsStatistics Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1136345 Change-Id: I30711bc02adcc6ebbcac95d609da0fbc54f49cb2 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java 2 files changed, 4 insertions(+), 5 deletions(-) Approvals: Omer Frenkel: Looks good to me, but someone else must approve Liran Zelkha: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30711bc02adcc6ebbcac95d609da0fbc54f49cb2 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Calculate Vds name from VdsStatic not VDS
by oourfali＠redhat.com 04 Sep '14

04 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Calculate Vds name from VdsStatic not VDS ...................................................................... core: Calculate Vds name from VdsStatic not VDS Change getVdsName to use VdsStatic which loads faster than Vds which loads slower Change-Id: I5b5f5445c4a7b986bfb983051a850b3794d25bfe Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java 2 files changed, 36 insertions(+), 7 deletions(-) Approvals: Omer Frenkel: Looks good to me, but someone else must approve Liran Zelkha: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b5f5445c4a7b986bfb983051a850b3794d25bfe Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: reports: provide reports.xml to engine over http
by ydary＠redhat.com 04 Sep '14

04 Sep '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: provide reports.xml to engine over http ...................................................................... reports: provide reports.xml to engine over http this is to support reports integration to webadmin on separate servers. Creates a single servlet ReportsServlet that takes commands as quert string and returns the Status of the deployment or the reports.xml file Change-Id: Ifa975703496318f10a73845a94f86b3966ad13da Bug-Url: https://bugzilla.redhat.com/1116851 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M build.xml M ovirt-engine-reports.spec.in R ovirt-engine-reports/ReportsServlet/build.xml A ovirt-engine-reports/ReportsServlet/src/main/java/org/ovirt/servlet/ReportsServlet.java D ovirt-engine-reports/ReportsStatus/src/main/java/org/ovirt/status/StatusServlet.java A packaging/jasper-war-patches/ce/200_002_web-inf_add-reports-servlet.patch D packaging/jasper-war-patches/ce/200_002_web-inf_add-reports-status-servlet.patch M packaging/jasper-war-patches/ce/200_005_web-inf_remove_error_on_jboss_start.patch A packaging/jasper-war-patches/pro/200_002_web-inf_add-reports-servlet.patch D packaging/jasper-war-patches/pro/200_002_web-inf_add-reports-status-servlet.patch M packaging/jasper-war-patches/pro/200_005_web-inf_remove_error_on_jboss_start.patch M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py 12 files changed, 96 insertions(+), 75 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30724 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa975703496318f10a73845a94f86b3966ad13da Gerrit-PatchSet: 13 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: aaa: reduce findbugs non useful warning
by yzaslavs＠redhat.com 03 Sep '14

03 Sep '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: reduce findbugs non useful warning ...................................................................... aaa: reduce findbugs non useful warning Vacuous ior operation on AuthzUtils.java:[line 47] in org.ovirt.engine.core.aaa.AuthzUtils.fetchPrincipalRecordImpl(ExtensionProxy, ExtKey, Object, boolean, boolean) This is an integer bit operation (and, or, or exclusive or) that doesn't do any useful work (e.g., v & 0xffffffff). Topic: AAA Change-Id: Icbcfe4e43c276ee561c526b30afdd0780f3bb5ca Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32443 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbcfe4e43c276ee561c526b30afdd0780f3bb5ca Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0