- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: engine: Change reorder vNIC action's permissions
by tnisan＠redhat.com 02 Sep '14

02 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: Change reorder vNIC action's permissions ...................................................................... engine: Change reorder vNIC action's permissions Changed the aforementioned action to belong to ActionGroup.CREATE_VM rather than ActionGroup.CONFIGURE_VM_NETWORK, as it's an integral part of the process of creating a VM (it shouldn't be called in the context of a pre-existing VM in order to re-arrange its NICs). This might seem askew - this whole command can (and likely should) be a part of the Create VM command, if that is changed to receive as a parameter a list of NICs to create. Change-Id: Iaef9b2e9ae9258210f48b59d89467247ff9a2468 Bug-Url: https://bugzilla.redhat.com/1134554 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Lior Vernia: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32259 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaef9b2e9ae9258210f48b59d89467247ff9a2468 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove BusinessEntityGuidComparator class
by ofrenkel＠redhat.com 02 Sep '14

02 Sep '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: Remove BusinessEntityGuidComparator class ...................................................................... core: Remove BusinessEntityGuidComparator class Remove BusinessEntityGuidComparator that can be replaced in all cases with the more generic BusinessEntityComparator with inferred types. Change-Id: I733bfbfdee01aa4c0bef344319e1dd471a3f2d79 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImageDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/BusinessEntityGuidComparator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeOptionEntity.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNetworkStatistics.java 6 files changed, 10 insertions(+), 23 deletions(-) Approvals: Martin Betak: Verified Allon Mureinik: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32134 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I733bfbfdee01aa4c0bef344319e1dd471a3f2d79 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Parameterize commonly used events
by lvernia＠redhat.com 02 Sep '14

02 Sep '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Parameterize commonly used events ...................................................................... webadmin: Parameterize commonly used events Parameterized the common events in EntityModel and in ListModel, to help people get rid of warnings if they properly parameterize their own listeners. Change-Id: I3fb6f78d9b917635108c2ca4dac5af2338ee4dc0 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/EntityModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListModel.java 2 files changed, 16 insertions(+), 17 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/32283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3fb6f78d9b917635108c2ca4dac5af2338ee4dc0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: tools: Make "No transport ..." error more understandable
by tnisan＠redhat.com 02 Sep '14

02 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: tools: Make "No transport ..." error more understandable ...................................................................... tools: Make "No transport ..." error more understandable Makes current error message "No transport is enabled, nothing to do" more understandable to users: "No transport is enabled, please enable SMTP (using MAIL_SERVER option) or SNMP (using SNMP_MANAGERS option)." Change-Id: I8aa720ff3d15ed45ec59035926bd2db8b7f2d020 Bug-Url: https://bugzilla.redhat.com/1136026 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32305 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8aa720ff3d15ed45ec59035926bd2db8b7f2d020 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: NPE when getVMFullList returns no vm information
by oourfali＠redhat.com 02 Sep '14

02 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: NPE when getVMFullList returns no vm information ...................................................................... core: NPE when getVMFullList returns no vm information When getVMFullList fetches no information the code fails with NPE. Bug-Url: https://bugzilla.redhat.com/1135959 Change-Id: Ifa1971f1181489e50877d080aec36ebc6d715f74 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VMListReturnForXmlRpc.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Piotr Kliczewski: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32276 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa1971f1181489e50877d080aec36ebc6d715f74 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: update vms on update of instance type
by ofrenkel＠redhat.com 02 Sep '14

02 Sep '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: update vms on update of instance type ...................................................................... core: update vms on update of instance type when instance type values are updated, we need to update also all the vms that are using this instance type. also, added audit log for vm update that is done internaly (by system) otherwise log will show "user <unknown>" Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1136372 Change-Id: Ic229a677bdd61a7f522548d9abf68476fbe219e7 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 27 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic229a677bdd61a7f522548d9abf68476fbe219e7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: use instance type values on update vm
by ofrenkel＠redhat.com 02 Sep '14

02 Sep '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: use instance type values on update vm ...................................................................... core: use instance type values on update vm When updating vm which is using instance-type, the instance-type values cannot be override by the user. this patch use the same code we have for add-vm that use instance-type, to override the correct values. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1136372 Change-Id: Ib3ed838af7052f744dccd015f90032fdfc18cc55 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java 3 files changed, 70 insertions(+), 33 deletions(-) Approvals: Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31299 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3ed838af7052f744dccd015f90032fdfc18cc55 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: remove un-needed null check
by ahadas＠redhat.com 02 Sep '14

02 Sep '14

Arik Hadas has submitted this change and it was merged. Change subject: core: remove un-needed null check ...................................................................... core: remove un-needed null check since we lock the template exclusively, and there is a null check in can-do-action, there is no need with another check in execute. Change-Id: Ic8b3097caf4daae52037752be196da8948641a5e Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java 1 file changed, 7 insertions(+), 9 deletions(-) Approvals: Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8b3097caf4daae52037752be196da8948641a5e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: minor cleanup in change disk can-do-action msgs
by ahadas＠redhat.com 02 Sep '14

02 Sep '14

Arik Hadas has submitted this change and it was merged. Change subject: core: minor cleanup in change disk can-do-action msgs ...................................................................... core: minor cleanup in change disk can-do-action msgs Change-Id: Ie957998df27982196ee0280ca2aa2971775acc29 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeDiskCommand.java 1 file changed, 7 insertions(+), 13 deletions(-) Approvals: Martin Betak: Looks good to me, but someone else must approve Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32127 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie957998df27982196ee0280ca2aa2971775acc29 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: allow no QoS for Profile element
by tnisan＠redhat.com 02 Sep '14

02 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi: allow no QoS for Profile element ...................................................................... restapi: allow no QoS for Profile element When there's no qos for profile, the generated profile doesn't contain is, so minOccurs of qos ref should be 0. Change-Id: I6262103d38376003ffe1b98d17400eaf5c5e387b Bug-Url: https://bugzilla.redhat.com/1135761 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/32312 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6262103d38376003ffe1b98d17400eaf5c5e387b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0