- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: tools: Make "No transport ..." error more understandable
by oourfali＠redhat.com 02 Sep '14

02 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: tools: Make "No transport ..." error more understandable ...................................................................... tools: Make "No transport ..." error more understandable Makes current error message "No transport is enabled, nothing to do" more understandable to users: "No transport is enabled, please enable SMTP (using MAIL_SERVER option) or SNMP (using SNMP_MANAGERS option)." Change-Id: I8aa720ff3d15ed45ec59035926bd2db8b7f2d020 Bug-Url: https://bugzilla.redhat.com/1136026 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Verified mooli tayer: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8aa720ff3d15ed45ec59035926bd2db8b7f2d020 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Use VmDevice.id to identify the vm device instance
by oourfali＠redhat.com 02 Sep '14

02 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Use VmDevice.id to identify the vm device instance ...................................................................... engine: Use VmDevice.id to identify the vm device instance The VmDevice.Id is sufficient to identify the existence of the device within a map, rather using the entire device which could be modified by other flows in the system (i.e. update boot sequence). Change-Id: Id0a976e31e97c1f250e29db9166e60ccba4b4a94 Bug-Url: https://bugzilla.redhat.com/1105842 Bug-Url: https://bugzilla.redhat.com/1136031 Signed-off-by: Moti Asayag <masayag(a)redhat.com> (cherry picked from commit 06e1857bf4b2a3f8c81c4399c5799e9beb6e67c7) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonVmMixIn.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 5 files changed, 9 insertions(+), 8 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/32275 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0a976e31e97c1f250e29db9166e60ccba4b4a94 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: net_config: use vdscli and setupNetworks
by sbonazzo＠redhat.com 02 Sep '14

02 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: net_config: use vdscli and setupNetworks ...................................................................... net_config: use vdscli and setupNetworks This patch replaces the usage of the vdsm command line interface with the python vdsm.vdscli and, in the process, switches from the non-rolling-back (and deprecated) addNetwork API verb to th rolling-back setupNetworks. Change-Id: Ic1923870adcb81f4e6bb5c6c1cc819d2e6e49aa2 Signed-off-by: Antoni S. Puimedon <asegurap(a)redhat.com> (cherry picked from commit 25962a34d1bf9251cbef2c49199c3e029f722f8f) --- M src/plugins/ovirt-hosted-engine-setup/network/bridge.py 1 file changed, 59 insertions(+), 86 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32297 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1923870adcb81f4e6bb5c6c1cc819d2e6e49aa2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: net_config: use vdscli and setupNetworks
by sbonazzo＠redhat.com 02 Sep '14

02 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: net_config: use vdscli and setupNetworks ...................................................................... net_config: use vdscli and setupNetworks This patch replaces the usage of the vdsm command line interface with the python vdsm.vdscli and, in the process, switches from the non-rolling-back (and deprecated) addNetwork API verb to th rolling-back setupNetworks. Change-Id: Ic1923870adcb81f4e6bb5c6c1cc819d2e6e49aa2 Signed-off-by: Antoni S. Puimedon <asegurap(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/network/bridge.py 1 file changed, 59 insertions(+), 86 deletions(-) Approvals: Martin Pavlik: Verified Sandro Bonazzola: Looks good to me, approved Antoni Segura Puimedon: Verified -- To view, visit http://gerrit.ovirt.org/28595 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1923870adcb81f4e6bb5c6c1cc819d2e6e49aa2 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Martin Pavlik <xpavli44(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: packaging: fixed wrong date
by ydary＠redhat.com 02 Sep '14

02 Sep '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: fixed wrong date ...................................................................... packaging: fixed wrong date Change-Id: I249eab7c0317ebb8504214eaad8be03d2118b2f5 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-dwh.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32177 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I249eab7c0317ebb8504214eaad8be03d2118b2f5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: userportal, webadmin: don't enable balloon on ppc arch (part2)
by oourfali＠redhat.com 02 Sep '14

02 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: userportal, webadmin: don't enable balloon on ppc arch (part2) ...................................................................... userportal, webadmin: don't enable balloon on ppc arch (part2) The memory ballooning doesn't work on ppc so neither portal nor admin should allow to set it. This patch fixes problem introduced by the first patch which prevents user from enabling the baloon on x86 arch. Bug-Url: https://bugzilla.redhat.com/1127677 Change-Id: Iea925ae11f1a05e857e102e932876d8b5a9fb0fc Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Jiří Moskovčák: Verified -- To view, visit http://gerrit.ovirt.org/32242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea925ae11f1a05e857e102e932876d8b5a9fb0fc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: engine-manads-domains always tries to look for KDC in DNS
by yzaslavs＠redhat.com 02 Sep '14

02 Sep '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: engine-manads-domains always tries to look for KDC in DNS ...................................................................... aaa: engine-manads-domains always tries to look for KDC in DNS The bug was caused due to the fact that the kdcs are always being validated, regardless of their "source" Change-Id: Ib3bb7cc049ad5b23127a505ff891b2d489a2caca Topic: AAA Bug-Url: https://bugzilla.redhat.com/1136087 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomains.java 1 file changed, 23 insertions(+), 17 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3bb7cc049ad5b23127a505ff891b2d489a2caca Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Fix NPE in Host dialog
by tnisan＠redhat.com 02 Sep '14

02 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix NPE in Host dialog ...................................................................... webadmin: Fix NPE in Host dialog Fixed NPE caused by http://gerrit.ovirt.org/#/c/32021/ Change-Id: I6d060d60a9ebd793d48275283741fabfee600224 Bug-Url: https://bugzilla.redhat.com/1133540 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Yaniv Bronhaim: Looks good to me, but someone else must approve Daniel Erez: Looks good to me, approved Vojtech Szocs: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32273 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d060d60a9ebd793d48275283741fabfee600224 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix NPE in Host dialog
by oourfali＠redhat.com 02 Sep '14

02 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Fix NPE in Host dialog ...................................................................... webadmin: Fix NPE in Host dialog Fixed NPE caused by http://gerrit.ovirt.org/#/c/32021/ Change-Id: I6d060d60a9ebd793d48275283741fabfee600224 Bug-Url: https://bugzilla.redhat.com/1133540 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Yaniv Bronhaim: Verified; Looks good to me, but someone else must approve Vojtech Szocs: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d060d60a9ebd793d48275283741fabfee600224 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: snapshot custom preview - excluded disks warning
by tnisan＠redhat.com 01 Sep '14

01 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: snapshot custom preview - excluded disks warning ...................................................................... webadmin: snapshot custom preview - excluded disks warning Snapshot custom preview dialog: Display warning when excluding disks from the snapshot (in order to emphasize that these disks will be removed). Change-Id: I1fd866d6553d73233f0bb590d47c370d11ddd8f5 Bug-Url: https://bugzilla.redhat.com/1111983 Bug-Url: https://bugzilla.redhat.com/1111984 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCustomPreviewPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCustomPreviewPopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PreviewSnapshotModel.java 4 files changed, 57 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/32272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1fd866d6553d73233f0bb590d47c370d11ddd8f5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0