- Engine-commits - oVirt List Archives

Change in ovirt-log-collector[ovirt-log-collector-3.4]: ux: added disclaimer on collected data
by sbonazzo＠redhat.com 26 Aug '14

26 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: ux: added disclaimer on collected data ...................................................................... ux: added disclaimer on collected data Change-Id: Ia65a0b37553026471279f67f50c4657441db673e Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit 62fbb525648c1a9992f13bc5f442403bfefed676) --- M src/__main__.py 1 file changed, 17 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31719 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia65a0b37553026471279f67f50c4657441db673e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.4]: archive: allow access only to the user
by sbonazzo＠redhat.com 26 Aug '14

26 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: archive: allow access only to the user ...................................................................... archive: allow access only to the user Change mode permission bits to 600 Change-Id: I90a69f1ea9d09915d04bd84339d64ec6d9e6c05a Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit 77d69d24c46207a16ecb5fc732cc1c84de0ca947) --- M src/__main__.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90a69f1ea9d09915d04bd84339d64ec6d9e6c05a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: wrong name is shown in event log when cloning a VM
by tjelinek＠redhat.com 26 Aug '14

26 Aug '14

Tomas Jelinek has submitted this change and it was merged. Change subject: core: wrong name is shown in event log when cloning a VM ...................................................................... core: wrong name is shown in event log when cloning a VM The problem was that the VM name in CloneVmCommand was set to the source VM while it was supposed to be set to the VM beeing created. Change-Id: Ic1e09991269b3efc9b2f8f3befa95eb00efe19c7 Bug-Url: https://bugzilla.redhat.com/1128239 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31903 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1e09991269b3efc9b2f8f3befa95eb00efe19c7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: removal of comments with developer names/usernames
by oourfali＠redhat.com 26 Aug '14

26 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: removal of comments with developer names/usernames ...................................................................... core: removal of comments with developer names/usernames Change-Id: Icd7cf60b05972bbe98a68fe1c7216812d8790927 Topic: cleanup Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ejb/EjbUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/linq/Aggregator.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/linq/All.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/linq/Function.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/linq/LinqUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/linq/Mapper.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/linq/Predicate.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/transaction/RollbackHandler.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/transaction/TransactionMethod.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/linq/LinqUtilsTest.java 13 files changed, 3 insertions(+), 43 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31939 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd7cf60b05972bbe98a68fe1c7216812d8790927 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: LUN disk creation - storage is not applicable
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi: LUN disk creation - storage is not applicable ...................................................................... restapi: LUN disk creation - storage is not applicable Storage domain is not applicable for DirectLUN disks, hence, removed from 'optionalArguments' on rsdl. Change-Id: Ie1a28b47096016b4a5293c349399c98862978d4a Bug-Url: https://bugzilla.redhat.com/1083096 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/31923 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1a28b47096016b4a5293c349399c98862978d4a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: LUN disk creation - format is not required
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi: LUN disk creation - format is not required ...................................................................... restapi: LUN disk creation - format is not required 'format' is not applicable for DirectLUN disks, hence, removed from parameters validation. Change-Id: I35078fb62e5506a51e96d4c99223b8dadd29e5a2 Bug-Url: https://bugzilla.redhat.com/1083096 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDisksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResourceTest.java 4 files changed, 7 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/31922 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35078fb62e5506a51e96d4c99223b8dadd29e5a2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: accept action in remove storage connection
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi: accept action in remove storage connection ...................................................................... restapi: accept action in remove storage connection Storage connections delete operation now takes an Action as optional parameter. The Action object should contain a Host element from which the connection would be unmounted. Change-Id: I19a0047ee14962eb8a6d0ab2c4e981913d062612 Bug-Url: https://bugzilla.redhat.com/1117278 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StorageServerConnectionsResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondStorageConnectionsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionsResourceTest.java 5 files changed, 30 insertions(+), 18 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/31921 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19a0047ee14962eb8a6d0ab2c4e981913d062612 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: fix client sorting for size columns
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: fix client sorting for size columns ...................................................................... webadmin: fix client sorting for size columns Currently, size columns are sorted using LexoNumericComparator, which is fine for most cases except for '< 1 GB' value... Hence, overridden 'makeSortable' method to compare the size values numerically. Screenshot: http://i.imgur.com/KfJjdq8.png Change-Id: Iab8cdc171ff8f652ec0747212f6fd846cf95540e Bug-Url: https://bugzilla.redhat.com/1133264 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractSizeColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/DiskSizeColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StorageSizeColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java 4 files changed, 31 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/31920 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab8cdc171ff8f652ec0747212f6fd846cf95540e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: storage disks subtab - fix status column
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: storage disks subtab - fix status column ...................................................................... webadmin: storage disks subtab - fix status column Storage > Disks: 'Status' column should be fetched using 'getStatusColumn' method. Change-Id: Ia373c40f696ce080dbfd09252fc96a5b59b3a80c Bug-Url: https://bugzilla.redhat.com/1133265 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageDiskView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/31919 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia373c40f696ce080dbfd09252fc96a5b59b3a80c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: missing disks link in SD VMs resource
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi: missing disks link in SD VMs resource ...................................................................... restapi: missing disks link in SD VMs resource Added missing 'disks' link for vms/templates under an export storage domain resource (i.e. on locations [1] and [2]). [1] /api/storagedomains/{storagedomain:id}/vms [2] /api/storagedomains/{storagedomain:id}/templates Change-Id: Ic8b7fe696f66eb02f2d402985e845f746ccb2095 Bug-Url: https://bugzilla.redhat.com/1130182 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendStorageDomainContentsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplatesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmsResource.java 3 files changed, 14 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/31918 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8b7fe696f66eb02f2d402985e845f746ccb2095 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0