- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Remove redundant header splitter
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Remove redundant header splitter ...................................................................... webadmin: Remove redundant header splitter The styling of ResizableHeader added a right border, which is redundant in the case of an EntityModelCellTable because there's always the left border of the next column header (as opposed to ActionCellTable whose styling works differently). Change-Id: Ied14df6f093514e26bbeb3dc60e509d58d056dae Bug-Url: https://bugzilla.redhat.com/1125192 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> (cherry picked from commit 034ea2168126a63c2fd4cf629581ef3a438fbbc0) --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeCellTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ResizableHeader.java 3 files changed, 27 insertions(+), 6 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/31860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied14df6f093514e26bbeb3dc60e509d58d056dae Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: Expose effective SPICE proxy in VM.display
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Expose effective SPICE proxy in VM.display ...................................................................... restapi: Expose effective SPICE proxy in VM.display Change-Id: I0bc84f39c8b6a2da742baae9b0874c2f36c3738d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1054948 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java 4 files changed, 61 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Martin Betak: Verified -- To view, visit http://gerrit.ovirt.org/31907 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0bc84f39c8b6a2da742baae9b0874c2f36c3738d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: userportal, webadmin: fix popup dialog header text spacing
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: userportal, webadmin: fix popup dialog header text spacing ...................................................................... userportal, webadmin: fix popup dialog header text spacing Changed popup dialog header text to be spaced with CSS only. Popup dialog header text was shifting left over the icon. This was a regression. Hopefully permanently fixed by restructuring the layout of the dialog header bar. Now when an icon is present, CSS takes care of moving the header text over. Also cleaned up some CSS class names for the dialog header. Bug-Url: https://bugzilla.redhat.com/1119027 Change-Id: I28ffde8e344b1bedc10310f6eb814a37a7aecefe Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.ui.xml M packaging/branding/ovirt.brand/common.css R packaging/branding/ovirt.brand/images/dialog/dialog_header_TL.png A packaging/branding/ovirt.brand/images/dialog/dialog_header_TR.png R packaging/branding/ovirt.brand/images/dialog/dialog_header_background_repetitive.png D packaging/branding/ovirt.brand/images/dialog/dialog_header_image.png M packaging/branding/ovirt.brand/images/dialog/error.png M packaging/branding/ovirt.brand/images/dialog/guide.png M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css M packaging/branding/ovirt.brand/web_admin.css 12 files changed, 94 insertions(+), 85 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/31844 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28ffde8e344b1bedc10310f6eb814a37a7aecefe Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin, userportal: stop special handling of '@' in user name
by awels＠redhat.com 25 Aug '14

25 Aug '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin, userportal: stop special handling of '@' in user name ...................................................................... webadmin, userportal: stop special handling of '@' in user name Simplify login page behavior: send user-name as is (don't parse by '@', etc.), don't disable the Domain drop-down. Change-Id: If7568c98c34e6edbd011949c5bad397aeba7b4ae Bug-Url: https://bugzilla.redhat.com/1112252 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/LoginModel.java 1 file changed, 4 insertions(+), 45 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified Yair Zaslavsky: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7568c98c34e6edbd011949c5bad397aeba7b4ae Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix height of EntityModelWidgetWithInfo
by lvernia＠redhat.com 25 Aug '14

25 Aug '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Fix height of EntityModelWidgetWithInfo ...................................................................... webadmin: Fix height of EntityModelWidgetWithInfo Fixed the height to be the same as most other widgets, to correct all sorts of layout issues. Also removed references to styles that no longer exist. Change-Id: Ia3a8381cf747609389f6c2ec806bef65d9248ee1 Bug-Url: https://bugzilla.redhat.com/1115524 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/EntityModelWidgetWithInfo.ui.xml 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Looks good to me, but someone else must approve Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/31861 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3a8381cf747609389f6c2ec806bef65d9248ee1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core, restapi: DirectLUN disk - validate LUN visibilty
by derez＠redhat.com 25 Aug '14

25 Aug '14

Daniel Erez has submitted this change and it was merged. Change subject: core,restapi: DirectLUN disk - validate LUN visibilty ...................................................................... core,restapi: DirectLUN disk - validate LUN visibilty Validate LUN visibility on DirectLUN disk creation: * core - Added a validation method to DiskValidator that verifies visibility of a LUN by querying GetDeviceList. - Execute the validation on AddDiskCommand only when a host is specified in parameters. - Added relevant AppError messages. * REST-API - When optional 'host' element is specified within the 'lun_storage' element, pass it to the parameters object. - Updated rsdl yaml accordingly. Change-Id: I339c999ebdfa69b8e2cbe4f55f8fe12e455810e4 Bug-Url: https://bugzilla.redhat.com/1123754 Buf-Url: https://bugzilla.redhat.com/1096217 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/DiskValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmDiskOperationParameterBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDisksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 13 files changed, 169 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31676 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I339c999ebdfa69b8e2cbe4f55f8fe12e455810e4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: Add vm.disks.disk collection to RSDL schema
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Add vm.disks.disk collection to RSDL schema ...................................................................... restapi: Add vm.disks.disk collection to RSDL schema Change-Id: I789144e1a51817bb268c0467943bba1d6a9c8889 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1132078 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Martin Betak: Verified -- To view, visit http://gerrit.ovirt.org/31906 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I789144e1a51817bb268c0467943bba1d6a9c8889 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: Make OsType enum consistent with OsRepository
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Make OsType enum consistent with OsRepository ...................................................................... restapi: Make OsType enum consistent with OsRepository The restapi enum OsType contained WINDOWS_2008R2 which was not one of the os' supported in OsRepository (only the windows_2008r2x64 is supported). Change-Id: I636de81217db51aaf122d0851f9102e7406e8531 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1109546 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/OsType.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Looks good to me, approved Martin Betak: Verified -- To view, visit http://gerrit.ovirt.org/31904 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I636de81217db51aaf122d0851f9102e7406e8531 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Don't configure kdump when PM is disabled
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Don't configure kdump when PM is disabled ...................................................................... core: Don't configure kdump when PM is disabled Kudmp integration is enabled by default for new host. But there's no sense to configure kdump integration without PM enabled. So this patch disable kdump integration during host deploy if PM is disabled. Change-Id: Ib05b2ce0ae512787f7b5d113f3a4ee1a1f05544b Bug-Url: https://bugzilla.redhat.com/1126854 Signed-off-by: Martin Perina <mperina(a)redhat.com> (cherry picked from commit 0e2d74c41f76089de1b3a145d7ca75fc7a4d1c81) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31899 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib05b2ce0ae512787f7b5d113f3a4ee1a1f05544b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Show warning when kdump integration required but not c...
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Show warning when kdump integration required but not configured ...................................................................... core: Show warning when kdump integration required but not configured Show warning when updating host configuration if PM and kdump integration are enabled, but VDSM doesn't report kdump status as enabled. Change-Id: I1c9a89daa1a106206bf581bb0f996bb84c203cfa Bug-Url: https://bugzilla.redhat.com/1126854 Signed-off-by: Martin Perina <mperina(a)redhat.com> (cherry picked from commit 1f3805353493ac28e820025d1d493d7854fe4b1e) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java 1 file changed, 17 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31900 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c9a89daa1a106206bf581bb0f996bb84c203cfa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0