- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core, db: Adding Cpu Qos DB config
by ahadas＠redhat.com 20 Aug '14

20 Aug '14

Arik Hadas has submitted this change and it was merged. Change subject: core, db: Adding Cpu Qos DB config ...................................................................... core, db: Adding Cpu Qos DB config Adding the Cpu Qos db config, the Cpu Qos consists of one parameter: cpu_limit. The parameter will be added to the qos table. support for this feature is for all 3.x versions. Also changed Storage Qos insert and update stored proc to fit common behavior ("insert"+"storage"/"cpu"+"qos"). Change-Id: I533bcc601ac44289c51f5d56a6da0dd2455116d6 Bug-Url: https://bugzilla.redhat.com/1084930 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DefaultGenericDaoDbFacade.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/qos/AllQosBaseDaoFacadeImpl.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/qos/CpuQosDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/qos/CpuQosDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/qos/QosBaseDaoFacadeImpl.java M backend/manager/modules/dal/src/main/jdbc-resources/engine-daos.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/qos/CpuQosDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/qos_sp.sql A packaging/dbscripts/upgrade/03_06_0280_add_cpu_limit_to_qos_table.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 16 files changed, 250 insertions(+), 6 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27686 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I533bcc601ac44289c51f5d56a6da0dd2455116d6 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: change cancel-migration command to be non transactive
by ahadas＠redhat.com 20 Aug '14

20 Aug '14

Arik Hadas has submitted this change and it was merged. Change subject: core: change cancel-migration command to be non transactive ...................................................................... core: change cancel-migration command to be non transactive Change-Id: Icec037c56f4681462cf53ead2dd7224b3621b237 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CancelMigrateVmCommand.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/31618 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icec037c56f4681462cf53ead2dd7224b3621b237 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: fixed dialog padding
by awels＠redhat.com 20 Aug '14

20 Aug '14

Alexander Wels has submitted this change and it was merged. Change subject: userportal, webadmin: fixed dialog padding ...................................................................... userportal, webadmin: fixed dialog padding The error and remove dialogs were missing padding. Fixed. Change-Id: Ie4bce0700dc8de218d9fafbf674eb03481219499 Bug-Url: https://bugzilla.redhat.com/1127333 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/DefaultConfirmationPopupView.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ErrorPopupView.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ForceRemoveConfirmationPopupView.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/RemoveConfirmationPopupView.ui.xml 4 files changed, 11 insertions(+), 4 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/31161 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4bce0700dc8de218d9fafbf674eb03481219499 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Update COW preallocated images to COW sparse
by tnisan＠redhat.com 20 Aug '14

20 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Update COW preallocated images to COW sparse ...................................................................... core: Update COW preallocated images to COW sparse Update the volume type of COW images that were imported from export domain to a block storage domain from preallocated to sparse since COW preallocated is not not a legal image configuration Change-Id: Ia50e78021369b6143c028af08742521bbdeb07fe Bug-Url: https://bugzilla.redhat.com/1132084 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- A packaging/dbscripts/upgrade/03_05_0930_convert_cow_preallocated_to_cow_sparse.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31727 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia50e78021369b6143c028af08742521bbdeb07fe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Update COW preallocated images to COW sparse
by tnisan＠redhat.com 20 Aug '14

20 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Update COW preallocated images to COW sparse ...................................................................... core: Update COW preallocated images to COW sparse Update the volume type of COW images that were imported from export domain to a block storage domain from preallocated to sparse since COW preallocated is not not a legal image configuration Change-Id: Ia50e78021369b6143c028af08742521bbdeb07fe Bug-Url: https://bugzilla.redhat.com/1132084 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- A packaging/dbscripts/upgrade/03_06_0270_convert_cow_preallocated_to_cow_sparse.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia50e78021369b6143c028af08742521bbdeb07fe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-guest-agent[ovirt-3.5]: Support for mapping image ids to physical devices
by vfeenstr＠redhat.com 20 Aug '14

20 Aug '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Support for mapping image ids to physical devices ...................................................................... Support for mapping image ids to physical devices This patch uses libudev through ctypes for systems providing libudev due to the instable nature of sysfs. While on RHEL5 we're using sysfs we cannot for example use it on Fedora 20 with kernel 3.15 since the serial values seem not to be exposed by sysfs. This patch extends the disks-usage message with the 'mapping' field. The value of the mapping field is an object {'$serial': {'name': '$devname'}} Change-Id: Ie8961b3703703df573dbf2f0fca2143b463ae76b Bug-Url: https://bugzilla.redhat.com/1127607 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> (cherry picked from commit 692b3ea13a7b4ea5a5426424d6aaf13a0f45ba32) --- M configure.ac M ovirt-guest-agent.rhel6.spec M ovirt-guest-agent.spec M ovirt-guest-agent/GuestAgentLinux2.py M ovirt-guest-agent/GuestAgentWin32.py M ovirt-guest-agent/Makefile.el5 M ovirt-guest-agent/OVirtAgentLogic.py M scripts/Makefile.am A scripts/diskmapper/Makefile.am A scripts/diskmapper/diskmapper.el5 A scripts/diskmapper/diskmapper.libudev 11 files changed, 239 insertions(+), 5 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31724 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8961b3703703df573dbf2f0fca2143b463ae76b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-guest-agent[master]: Support for mapping image ids to physical devices
by vfeenstr＠redhat.com 20 Aug '14

20 Aug '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Support for mapping image ids to physical devices ...................................................................... Support for mapping image ids to physical devices This patch uses libudev through ctypes for systems providing libudev due to the instable nature of sysfs. While on RHEL5 we're using sysfs we cannot for example use it on Fedora 20 with kernel 3.15 since the serial values seem not to be exposed by sysfs. This patch extends the disks-usage message with the 'mapping' field. The value of the mapping field is an object {'$serial': {'name': '$devname'}} Change-Id: Ie8961b3703703df573dbf2f0fca2143b463ae76b Bug-Url: https://bugzilla.redhat.com/1127607 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M configure.ac M ovirt-guest-agent.rhel6.spec M ovirt-guest-agent.spec M ovirt-guest-agent/GuestAgentLinux2.py M ovirt-guest-agent/GuestAgentWin32.py M ovirt-guest-agent/Makefile.el5 M ovirt-guest-agent/OVirtAgentLogic.py M scripts/Makefile.am A scripts/diskmapper/Makefile.am A scripts/diskmapper/diskmapper.el5 A scripts/diskmapper/diskmapper.libudev 11 files changed, 239 insertions(+), 5 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31465 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8961b3703703df573dbf2f0fca2143b463ae76b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: engine vdc error codes for vdsm sparsify
by amureini＠redhat.com 20 Aug '14

20 Aug '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: engine vdc error codes for vdsm sparsify ...................................................................... core: engine vdc error codes for vdsm sparsify VDSM virt-sparsify integration added two new errors in storage_exception.py. This patch adds the respective errors on the engine side. Change-Id: If787a4980d6a01bb58ad1646e38ef08090b59f37 Signed-off-by: Utkarsh <utkarshsins(a)gmail.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Federico Simoncelli: Looks good to me, but someone else must approve Utkarsh Singh: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31634 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If787a4980d6a01bb58ad1646e38ef08090b59f37 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Utkarsh Singh <utkarshsins(a)gmail.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Utkarsh Singh <utkarshsins(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: ENTER does not execute default command
by tnisan＠redhat.com 20 Aug '14

20 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: ENTER does not execute default command ...................................................................... webadmin: ENTER does not execute default command Pressing the enter key does not execute the default command for all models that extend SearchableListModel Change-Id: I4ebfa08d2d3bcd0d2089febbe19e54c76cef25ec Bug-Url: https://bugzilla.redhat.com/1126324 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/DeferredModelCommandInvoker.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionStackPanelItem.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java 5 files changed, 16 insertions(+), 14 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31722 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ebfa08d2d3bcd0d2089febbe19e54c76cef25ec Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk[sdk_3.5]: codegen: Disconnect-at-constructor only if proxy found
by juan.hernandez＠redhat.com 20 Aug '14

20 Aug '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Disconnect-at-constructor only if proxy found ...................................................................... codegen: Disconnect-at-constructor only if proxy found Change-Id: I14e8e8ca00a99263227053a47129b93bcb27b7d1 Related: https://bugzilla.redhat.com/996021 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit c625968c014cbf00535c83fad2e960a9597615e3) --- M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/EntryPointTemplate 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14e8e8ca00a99263227053a47129b93bcb27b7d1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0