- Engine-commits - oVirt List Archives

Change in ovirt-engine-cli[cli_3.5]: cli: No regular expression for IP, UUID or number
by juan.hernandez＠redhat.com 20 Aug '14

20 Aug '14

Juan Hernandez has submitted this change and it was merged. Change subject: cli: No regular expression for IP, UUID or number ...................................................................... cli: No regular expression for IP, UUID or number Currently the command line lexer uses regular expressions to match IP addresses, UUIDs and numbers. But in the parser grammar there is no production that accepts those terminal symbols and doesn't accept also plain words. The only special treatment is that numeric values are converted to "int". This behaviour means that some words that happen to start like IP addresses, UUIDS or numbers are split into two tokens. For example, the following command line: update host 10.10.10.10a --name 10.10.10.10 Will be split into the following tokens: WORD: update WORD: host IPADDR: 10.10.10.10 WORD: a OPTION: --name IPADDR: 10.10.10.10 But it should have been as follows: WORD: update WORD: host WORD: 10.10.10.10a OPTION: --name IPADDR: 10.10.10.10 To avoid this issue, and simplify the lexer, this patch removes these regular expressions for IP addresses, UUIDs and numbers, and replaces them with a single expression that matches words. The action for this expression will check if the value is actually an integer and convert it to "int". Change-Id: If670144751fdb9564380a12fb73596ecbaa47ee9 Bug-Url: https://bugzilla.redhat.com/1110366 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit e160c941231e84638253fae0e90df4dc976ad980) --- M src/cli/parser.py 1 file changed, 17 insertions(+), 24 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31710 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If670144751fdb9564380a12fb73596ecbaa47ee9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-cli[master]: cli: No regular expression for IP, UUID or number
by juan.hernandez＠redhat.com 20 Aug '14

20 Aug '14

Juan Hernandez has submitted this change and it was merged. Change subject: cli: No regular expression for IP, UUID or number ...................................................................... cli: No regular expression for IP, UUID or number Currently the command line lexer uses regular expressions to match IP addresses, UUIDs and numbers. But in the parser grammar there is no production that accepts those terminal symbols and doesn't accept also plain words. The only special treatment is that numeric values are converted to "int". This behaviour means that some words that happen to start like IP addresses, UUIDS or numbers are split into two tokens. For example, the following command line: update host 10.10.10.10a --name 10.10.10.10 Will be split into the following tokens: WORD: update WORD: host IPADDR: 10.10.10.10 WORD: a OPTION: --name IPADDR: 10.10.10.10 But it should have been as follows: WORD: update WORD: host WORD: 10.10.10.10a OPTION: --name IPADDR: 10.10.10.10 To avoid this issue, and simplify the lexer, this patch removes these regular expressions for IP addresses, UUIDs and numbers, and replaces them with a single expression that matches words. The action for this expression will check if the value is actually an integer and convert it to "int". Change-Id: If670144751fdb9564380a12fb73596ecbaa47ee9 Bug-Url: https://bugzilla.redhat.com/1110366 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/cli/parser.py 1 file changed, 17 insertions(+), 24 deletions(-) Approvals: Michael Pasternak: Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Juan Hernandez: Verified Ilia Meerovich: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29722 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If670144751fdb9564380a12fb73596ecbaa47ee9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Ilia Meerovich <imeerovi(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Don't store Neutron physical network on import
by tnisan＠redhat.com 20 Aug '14

20 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Don't store Neutron physical network on import ...................................................................... core: Don't store Neutron physical network on import This allowed Neutron physical network entries to sneak into our DB. Except for eliminating that possibility, such existing entries are cleared from the DB. Change-Id: Icb8751f06690ffb34cc72f1f2e5e14e66b4d40f1 Bug-Url: https://bugzilla.redhat.com/1127687 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java A packaging/dbscripts/upgrade/03_05_0920_remove_external_network_labels.sql 2 files changed, 3 insertions(+), 1 deletion(-) Approvals: Lior Vernia: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb8751f06690ffb34cc72f1f2e5e14e66b4d40f1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-guest-agent[ovirt-3.5]: Fix username handling on Windows
by vfeenstr＠redhat.com 20 Aug '14

20 Aug '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Fix username handling on Windows ...................................................................... Fix username handling on Windows We forcibly encoded the unicode string to UTF-8 right after retrieval which broke the encoding later on. This patch fixes this issue. Change-Id: I65b33e4f38f801f1770cf94a5ed36234c2fae90d Bug-Url: https://bugzilla.redhat.com/1010201 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> (cherry picked from commit 6fc1a18b2be2e93070fce2cd3cb0d5e23e2ecc5e) --- M ovirt-guest-agent/GuestAgentWin32.py M ovirt-guest-agent/OVirtAgentLogic.py 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31537 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65b33e4f38f801f1770cf94a5ed36234c2fae90d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: setting default protocol to XMLRPC
by oourfali＠redhat.com 20 Aug '14

20 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: setting default protocol to XMLRPC ...................................................................... core: setting default protocol to XMLRPC Due to some unresolved issues, changing the default back to XMLRPC, by setting json as not-supported in 3.5. Once the issues are resolved we will change it back. This patch doesn't block you from working with JSONRPC, just setting the default. Change-Id: Ic9e298bf2d00ff63f40af65e97d9326135bfbc6a Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31704 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9e298bf2d00ff63f40af65e97d9326135bfbc6a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: setting default protocol to XMLRPC
by oourfali＠redhat.com 20 Aug '14

20 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: setting default protocol to XMLRPC ...................................................................... core: setting default protocol to XMLRPC Due to some unresolved issues, changing the default back to XMLRPC, by setting json as not-supported in 3.5. Once the issues are resolved we will change it back. This patch doesn't block you from working with JSONRPC, just setting the default. Change-Id: Ic9e298bf2d00ff63f40af65e97d9326135bfbc6a Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31685 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9e298bf2d00ff63f40af65e97d9326135bfbc6a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Enabled WAD for File Domains in the UI
by tnisan＠redhat.com 20 Aug '14

20 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Enabled WAD for File Domains in the UI ...................................................................... webadmin: Enabled WAD for File Domains in the UI This patch enables the "Wipe After Delete" check box for file domains in the windows "Add Virtual Disk" and "Edit Virtual Disk". Change-Id: Ib8b9f2860fd186651311814d0087c47f4083c863 Bug-Url: https://bugzilla.redhat.com/1122510 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 4 files changed, 1 insertion(+), 44 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31212 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8b9f2860fd186651311814d0087c47f4083c863 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk[sdk_3.5]: sdk: Prepare for next development iteration
by juan.hernandez＠redhat.com 20 Aug '14

20 Aug '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Prepare for next development iteration ...................................................................... sdk: Prepare for next development iteration In preparation for the next development iteration this patch increases the version number and sets the RPM relase number to 0.1. Change-Id: Ifc7be67220b6a7165e2bca0311b49f4b1f9a2edb Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M Makefile M setup.py 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Ravi Nori: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31469 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc7be67220b6a7165e2bca0311b49f4b1f9a2edb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: require tty over ssh
by sbonazzo＠redhat.com 20 Aug '14

20 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: require tty over ssh ...................................................................... packaging: setup: require tty over ssh Running ssh -lroot hostname "hosted-engine --deploy" cause an error while testing storage. Added a check to ensure tty is available. Change-Id: I8ecf0248ea6120acd8d6e624cf8114cc0a29efa8 Bug-Url: https://bugzilla.redhat.com/1105249 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/core/shell.py 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31698 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ecf0248ea6120acd8d6e624cf8114cc0a29efa8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: nit: fixed typos
by dcaroest＠redhat.com 20 Aug '14

20 Aug '14

David Caro has submitted this change and it was merged. Change subject: nit: fixed typos ...................................................................... nit: fixed typos Change-Id: I558e52059ca812beec6e1879f99916bcf79e5f8c Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/shell-scripts/build_mock_srcrpm_releng.sh M jobs/confs/shell-scripts/mock_build_onlyrpm.sh M jobs/confs/shell-scripts/mock_install.sh 3 files changed, 6 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified David Caro: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31658 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I558e52059ca812beec6e1879f99916bcf79e5f8c Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0