- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Added short term history of VM cpu/memory/network usage
by tjelinek＠redhat.com 18 Aug '14

18 Aug '14

Tomas Jelinek has submitted this change and it was merged. Change subject: core: Added short term history of VM cpu/memory/network usage ...................................................................... core: Added short term history of VM cpu/memory/network usage The purpose is to have a simple way to remember a short term history of cpu/mem/network usage. The amount of data remembered is configurable by UsageHistoryLimit option in vdc_options (by default set to 40 values). The specific fields in which this data are remembered are in vm_statistics, namely: memory_usage_history, cpu_usage_history and network_usage_history. The data are stored as comma separated list. Change-Id: Id5275c224df83caf5078062e14121847940eac44 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=803251 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/VmStatisticsTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStatisticsDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStatisticsDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_06_0220_add_history_data_to_vm_statistics.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/dbscripts/vms_sp.sql 12 files changed, 267 insertions(+), 5 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29710 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5275c224df83caf5078062e14121847940eac44 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: ENTER does not execute default command
by oourfali＠redhat.com 18 Aug '14

18 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: ENTER does not execute default command ...................................................................... webadmin: ENTER does not execute default command Pressing the enter key does not execute the default command for all models that extend SearchableListModel Change-Id: I4ebfa08d2d3bcd0d2089febbe19e54c76cef25ec Bug-Url: https://bugzilla.redhat.com/1126324 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/DeferredModelCommandInvoker.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionStackPanelItem.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java 5 files changed, 16 insertions(+), 14 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31167 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ebfa08d2d3bcd0d2089febbe19e54c76cef25ec Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: UI:Adding support for host with connectivity..
by emesika＠redhat.com 18 Aug '14

18 Aug '14

Eli Mesika has submitted this change and it was merged. Change subject: UI:Adding support for host with connectivity.. ...................................................................... UI:Adding support for host with connectivity.. Adding support for host with connectivity issues Change-Id: I7d300b37a49261744d81fd397772f70e56e7a688 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120829 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 6 files changed, 121 insertions(+), 4 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31305 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d300b37a49261744d81fd397772f70e56e7a688 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Skip fencing if host has connectivity issues
by emesika＠redhat.com 18 Aug '14

18 Aug '14

Eli Mesika has submitted this change and it was merged. Change subject: core: Skip fencing if host has connectivity issues ...................................................................... core: Skip fencing if host has connectivity issues Change-Id: I7a9c7db43b50421414ce9596137767b00cbfc2ae Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120829 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/FencingPolicy.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/dal/src/test/resources/fixtures.xml A packaging/dbscripts/upgrade/03_06_0210_skip_fencing_when_connectivity_broken.sql M packaging/dbscripts/vds_groups_sp.sql 8 files changed, 114 insertions(+), 8 deletions(-) Approvals: Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a9c7db43b50421414ce9596137767b00cbfc2ae Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: don't expect the engine to be up right after starting it's g...
by msivak＠redhat.com 18 Aug '14

18 Aug '14

Martin Sivák has submitted this change and it was merged. Change subject: don't expect the engine to be up right after starting it's guest ...................................................................... don't expect the engine to be up right after starting it's guest - there were states which went directly from Down to Up not giving the engine enough time to start which lead agent to go to BadHealth state, this is wrong and we should give the guest and engine some time to settle Change-Id: Ie68360fe883d5d05db4974f73381da5386453845 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1130173 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/states.py 1 file changed, 9 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Jiří Moskovčák: Verified -- To view, visit http://gerrit.ovirt.org/31519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie68360fe883d5d05db4974f73381da5386453845 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.2]: try to start the vm even if other hosts have the same score
by msivak＠redhat.com 18 Aug '14

18 Aug '14

Martin Sivák has submitted this change and it was merged. Change subject: try to start the vm even if other hosts have the same score ...................................................................... try to start the vm even if other hosts have the same score if there are hosts with the same best score all should try to start the VM otherwise we might end up in the situation when every host thinks the others are better and no one will start the VM Change-Id: Ib1ab72dfd8c4f07268eabe3e6fdc7a74929d9308 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1093638 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> (cherry picked from commit 3b3fdf2e3b56f61d76d0073ed5a24d8833dc6302) --- M ovirt_hosted_engine_ha/agent/states.py 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Martin Sivák: Looks good to me, approved Jiří Moskovčák: Verified -- To view, visit http://gerrit.ovirt.org/31513 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1ab72dfd8c4f07268eabe3e6fdc7a74929d9308 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.2 Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: cannot edit description of a VM from pool
by shavivi＠redhat.com 18 Aug '14

18 Aug '14

Shahar Havivi has submitted this change and it was merged. Change subject: ui: cannot edit description of a VM from pool ...................................................................... ui: cannot edit description of a VM from pool Bug-Url: https://bugzilla.redhat.com/1060518 Change-Id: I9273136a6dd1f3b6f28c329828c23f3a798c6075 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified -- To view, visit http://gerrit.ovirt.org/31337 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9273136a6dd1f3b6f28c329828c23f3a798c6075 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix fence-status operation
by oourfali＠redhat.com 18 Aug '14

18 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: fix fence-status operation ...................................................................... core: fix fence-status operation When the fencing policy is null, we check that the host is compatible with cluster level 3.0, which is wrong. This patch changes that by not checking cluster level when fencing policy is null. Also getMinimalSupportedVersion was modified to throw IllegalArgumentException when null is passed as parameter. Change-Id: Idecf91da729cbd8744f894c341b7044cc791853d Bug-Url: https://bugzilla.redhat.com/1130791 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/FencingPolicyHelper.java 2 files changed, 17 insertions(+), 11 deletions(-) Approvals: Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31575 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idecf91da729cbd8744f894c341b7044cc791853d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: DeactivateStorageDomain - removing unneeded part of lo...
by laravot＠redhat.com 18 Aug '14

18 Aug '14

Liron Aravot has submitted this change and it was merged. Change subject: core: DeactivateStorageDomain - removing unneeded part of log message ...................................................................... core: DeactivateStorageDomain - removing unneeded part of log message getExceptionString() always returns null, therefore there's no need to have it logged. Change-Id: I226ab3c43d8bddbca495be933f700d97641886e1 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/31564 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I226ab3c43d8bddbca495be933f700d97641886e1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: SpmStopOnIrs - set result
by laravot＠redhat.com 18 Aug '14

18 Aug '14

Liron Aravot has submitted this change and it was merged. Change subject: core: SpmStopOnIrs - set result ...................................................................... core: SpmStopOnIrs - set result When executing SpmStopOnIrs we should set the return value to be as the return value of the command that's being executed, otherwise the caller can't tell what actually happend. Change-Id: I5eb2a4c788ef5cf571a8de150355c85e3a9ae77a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1130222 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SpmStopOnIrsVDSCommand.java 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/31563 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5eb2a4c788ef5cf571a8de150355c85e3a9ae77a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0