- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core: Skip fencing if host has connectivity issues
by tnisan＠redhat.com 18 Aug '14

18 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Skip fencing if host has connectivity issues ...................................................................... core: Skip fencing if host has connectivity issues Change-Id: I7a9c7db43b50421414ce9596137767b00cbfc2ae Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120829 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/FencingPolicy.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/dal/src/test/resources/fixtures.xml A packaging/dbscripts/upgrade/03_05_0900_skip_fencing_when_connectivity_broken.sql M packaging/dbscripts/vds_groups_sp.sql 8 files changed, 114 insertions(+), 8 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a9c7db43b50421414ce9596137767b00cbfc2ae Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: format StorageListModel
by gchaplik＠redhat.com 18 Aug '14

18 Aug '14

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: format StorageListModel ...................................................................... webadmin: format StorageListModel using eclipse formatter. Change-Id: Iac9b645eb610545d94b117c0b3d007daf304294b Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 28 insertions(+), 28 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/31105 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac9b645eb610545d94b117c0b3d007daf304294b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: update support of ppc cpus
by oourfali＠redhat.com 18 Aug '14

18 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: update support of ppc cpus ...................................................................... core: update support of ppc cpus Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1131021 Change-Id: I75ea7ce447853f653cc45044cbf8ede64c0a8bb9 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Verified Arik Hadas: Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31508 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75ea7ce447853f653cc45044cbf8ede64c0a8bb9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: ui: redundant call to vminit when initializing vms template
by tnisan＠redhat.com 18 Aug '14

18 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: ui: redundant call to vminit when initializing vms template ...................................................................... ui: redundant call to vminit when initializing vms template When setting vminit to desktop vm (one that have a template), we call again vminit.init() method - after it has been initialize with the right values. Removing that not influence current code work-flow (ie vm, template and pool) Change-Id: Idc2e40f72b85cd3641c6e5c705438cd217308f91 Bug-Url: https://bugzilla.redhat.com/1126195 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified -- To view, visit http://gerrit.ovirt.org/31600 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc2e40f72b85cd3641c6e5c705438cd217308f91 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Implement validation in EntityModelCellTable
by tnisan＠redhat.com 18 Aug '14

18 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Implement validation in EntityModelCellTable ...................................................................... webadmin: Implement validation in EntityModelCellTable Validation accepts a list of errors, and outlines invalid entries (ones which have non-empty errors) with a red outline, as well as adds the invalidity reason as tooltip. Change-Id: I8cddd3a6dbfe3cd9b18b631f4da13865b367d096 Bug-Url: https://bugzilla.redhat.com/1048752 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/CellTableValidation.css 2 files changed, 36 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/31504 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8cddd3a6dbfe3cd9b18b631f4da13865b367d096 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: fix fence-status operation
by tnisan＠redhat.com 18 Aug '14

18 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: fix fence-status operation ...................................................................... core: fix fence-status operation When the fencing policy is null, we check that the host is compatible with cluster level 3.0, which is wrong. This patch changes that by not checking cluster level when fencing policy is null. Also getMinimalSupportedVersion was modified to throw IllegalArgumentException when null is passed as parameter. Change-Id: Idecf91da729cbd8744f894c341b7044cc791853d Bug-Url: https://bugzilla.redhat.com/1130791 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> Signed-off-by: Martin Perina <mperina(a)redhat.com> (cherry picked from commit 7039195f1019371a1edbcf3b97a82a098e77c868) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/FencingPolicyHelper.java 2 files changed, 17 insertions(+), 11 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31603 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idecf91da729cbd8744f894c341b7044cc791853d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webamdin: clarify error message on storage creation
by tnisan＠redhat.com 18 Aug '14

18 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webamdin: clarify error message on storage creation ...................................................................... webamdin: clarify error message on storage creation Clarified error message in the webadmin when trying to create a file storage domain with a used connection: "Create operation failed. Storage connection is already used by the following storage domain: {storage_name}." Change-Id: Ifc91bc60e42c94b972bb8c2c26a2980072bfe43e Bug-Url: https://bugzilla.redhat.com/1029934 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31578 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc91bc60e42c94b972bb8c2c26a2980072bfe43e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: userportal, webadmin: webadmin fixes for VM dialog
by tnisan＠redhat.com 18 Aug '14

18 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: userportal,webadmin: webadmin fixes for VM dialog ...................................................................... userportal,webadmin: webadmin fixes for VM dialog In FR locale new VM/pool dialog had some issues. Fixed by making the dialog bigger and setting the proper style to SerialNumberPolicyWidget's checkbox. Change-Id: I7e8659f3aee8d8ce3a67c97c9fda2d2546175f0c Bug-Url: https://bugzilla.redhat.com/1123735 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractVmPopupView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/SerialNumberPolicyWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/pool/PoolEditPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/pool/PoolNewPopupView.java 5 files changed, 8 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31132 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e8659f3aee8d8ce3a67c97c9fda2d2546175f0c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: Remove default caption from Cloud-Init new network
by shavivi＠redhat.com 18 Aug '14

18 Aug '14

Shahar Havivi has submitted this change and it was merged. Change subject: ui: Remove default caption from Cloud-Init new network ...................................................................... ui: Remove default caption from Cloud-Init new network The label is: "ethX [Click to Change]" which is confusing and the user need to delete the text for entering a new interface name. Also added an empty field validator. Bug-Url: https://bugzilla.redhat.com/1126198 Change-Id: I796812fedf425592b6f566047ad8ccbf29c9e50e Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 2 files changed, 3 insertions(+), 8 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified -- To view, visit http://gerrit.ovirt.org/31019 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I796812fedf425592b6f566047ad8ccbf29c9e50e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: line chart progress bar
by tjelinek＠redhat.com 18 Aug '14

18 Aug '14

Tomas Jelinek has submitted this change and it was merged. Change subject: ui: line chart progress bar ...................................................................... ui: line chart progress bar Added a widget which can visualize a list of integers as a line chart and its usage to the VM main tab for mem/cpu/network usage Change-Id: I66a577d6e3699c7985a4e6dd4aa66dd5969ebf82 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=803251 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/LineChartProgressBarColumn.java 4 files changed, 329 insertions(+), 14 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29549 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66a577d6e3699c7985a4e6dd4aa66dd5969ebf82 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0