- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: StoragePoolValidatorTest assets
by amureini＠redhat.com 12 Aug '14

12 Aug '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: StoragePoolValidatorTest assets ...................................................................... core: StoragePoolValidatorTest assets Standardized asserts to use ValidationResultMatchers in order to improve readability and reuse code wherever possible. Change-Id: Iae8ee38b15cdea9c876760bdc096c7adae578b8a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StoragePoolValidatorTest.java 1 file changed, 15 insertions(+), 24 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/31265 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae8ee38b15cdea9c876760bdc096c7adae578b8a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: StoragePoolValidatorTest initializers
by amureini＠redhat.com 12 Aug '14

12 Aug '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: StoragePoolValidatorTest initializers ...................................................................... core: StoragePoolValidatorTest initializers Removed redundant initializers to solve IntelliJ IDEA warning. Change-Id: Ifdf260ad7dafcbb1d9c1bbd7a3c6e375e74e18c7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StoragePoolValidatorTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/31264 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdf260ad7dafcbb1d9c1bbd7a3c6e375e74e18c7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-release[master]: packaging: add rubygem-rgen deps for puppet
by sbonazzo＠redhat.com 12 Aug '14

12 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: add rubygem-rgen deps for puppet ...................................................................... packaging: add rubygem-rgen deps for puppet Change-Id: I8647ea83a615fd4eb7ce5f83fe492cb17bd67446 Bug-Url: https://bugzilla.redhat.com/1129236 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-release-3.5/ovirt-el6-deps.repo.in M ovirt-release-3.5/ovirt-el7-deps.repo.in M ovirt-release-3.5/ovirt-release35.spec.in M ovirt-release-master/ovirt-el6-deps.repo.in M ovirt-release-master/ovirt-el7-deps.repo.in 5 files changed, 5 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31408 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8647ea83a615fd4eb7ce5f83fe492cb17bd67446 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.4]: sos2: fix callExtProg usage
by sbonazzo＠redhat.com 12 Aug '14

12 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: sos2: fix callExtProg usage ...................................................................... sos2: fix callExtProg usage fix usage of callExtProg method causing sos plugin to exit due to a TypeError exception. Change-Id: I02574b2d4ac35bac137db82060ccc18b5d27a372 Bug-Url: https://bugzilla.redhat.com/1129373 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit f732b107c58b5f732a6ce23f854a9c283f687228) (cherry picked from commit efe47eedf3feb4e25a0fe487203c6f3ba8e81bb6) --- M src/sos/plugins/ovirt.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02574b2d4ac35bac137db82060ccc18b5d27a372 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.4]: sos: fixing backport issues
by sbonazzo＠redhat.com 12 Aug '14

12 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: fixing backport issues ...................................................................... sos: fixing backport issues fixing some bits left while backporting from sos 3. Change-Id: I2ec54434502a6774da8f2bdf7e87d76df89a4fed Bug-Url: https://bugzilla.redhat.com/1129373 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit d0edf00b9e5bd40509e5a1a851fb556857a48d50) --- M src/sos/plugins/ovirt.py M src/sos/plugins/postgresql.py 2 files changed, 13 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31416 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ec54434502a6774da8f2bdf7e87d76df89a4fed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-log-collector[master]: sos: collect /etc/rhevm
by sbonazzo＠redhat.com 12 Aug '14

12 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: collect /etc/rhevm ...................................................................... sos: collect /etc/rhevm Due to a bug in sos /etc/rhevm was not collected. This patch introduces a workaround by collecting its content. Change-Id: Iebee3f58a987921e7919a42810659f57cc96cae9 Bug-Url: https://bugzilla.redhat.com/1128738 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/sos/plugins/ovirt.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31379 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iebee3f58a987921e7919a42810659f57cc96cae9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tomáš Došek <tdosek(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.5]: sos: fixing backport issues
by sbonazzo＠redhat.com 12 Aug '14

12 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: fixing backport issues ...................................................................... sos: fixing backport issues fixing some bits left while backporting from sos 3. Change-Id: I2ec54434502a6774da8f2bdf7e87d76df89a4fed Bug-Url: https://bugzilla.redhat.com/1128839 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit d0edf00b9e5bd40509e5a1a851fb556857a48d50) --- M src/sos/plugins/ovirt.py M src/sos/plugins/postgresql.py 2 files changed, 13 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31415 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ec54434502a6774da8f2bdf7e87d76df89a4fed Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-log-collector[master]: sos: fixing backport issues
by sbonazzo＠redhat.com 12 Aug '14

12 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: fixing backport issues ...................................................................... sos: fixing backport issues fixing some bits left while backporting from sos 3. Change-Id: I2ec54434502a6774da8f2bdf7e87d76df89a4fed Bug-Url: https://bugzilla.redhat.com/1128839 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/sos/plugins/ovirt.py M src/sos/plugins/postgresql.py 2 files changed, 13 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31357 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ec54434502a6774da8f2bdf7e87d76df89a4fed Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.4]: sos: ovirt: add rhevm packages
by sbonazzo＠redhat.com 12 Aug '14

12 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: ovirt: add rhevm packages ...................................................................... sos: ovirt: add rhevm packages Align with upstream sos master patches. Add support for downstream packages and ovirt-scheduler-proxy Change-Id: I7e41635ffbb937390804e05961f49c687798cba2 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/sos/plugins/ovirt.py 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e41635ffbb937390804e05961f49c687798cba2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.5]: sos: ovirt: add rhevm packages
by sbonazzo＠redhat.com 12 Aug '14

12 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: ovirt: add rhevm packages ...................................................................... sos: ovirt: add rhevm packages Align with upstream sos master patches. Add support for downstream packages and ovirt-scheduler-proxy Change-Id: I7e41635ffbb937390804e05961f49c687798cba2 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/sos/plugins/ovirt.py 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e41635ffbb937390804e05961f49c687798cba2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0