- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: dbscripts: Add DWH hostname and uuid
by sbonazzo＠redhat.com 12 Aug '14

12 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: dbscripts: Add DWH hostname and uuid ...................................................................... packaging: dbscripts: Add DWH hostname and uuid These are used to track remote dwh setups. Change-Id: Ib66d62fa0da0cd1014e71ae509e49b28228d0cf1 Bug-Url: https://bugzilla.redhat.com/1118350 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- A packaging/dbscripts/upgrade/03_06_0160_add_dwh_hostname_and_uuid.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Eli Mesika: Looks good to me, but someone else must approve Yedidyah Bar David: Verified Yaniv Dary: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib66d62fa0da0cd1014e71ae509e49b28228d0cf1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: rename cloud-init root-password to password
by shavivi＠redhat.com 12 Aug '14

12 Aug '14

Shahar Havivi has submitted this change and it was merged. Change subject: ui: rename cloud-init root-password to password ...................................................................... ui: rename cloud-init root-password to password The password field is not relevant only for root - but other users as well. Change-Id: I84451cc25ae14f056c673eb715eea3ea870840d5 Bug-Url: https://bugzilla.redhat.com/1126185 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31057 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84451cc25ae14f056c673eb715eea3ea870840d5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: spec: require latest vdsm-jsonrpc-java
by sbonazzo＠redhat.com 12 Aug '14

12 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: require latest vdsm-jsonrpc-java ...................................................................... packaging: spec: require latest vdsm-jsonrpc-java Change-Id: I503f001e51144feeeb59a93ebc5d18d1368a7cde Bug-Url: https://bugzilla.redhat.com/1128761 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Sandro Bonazzola: Verified; Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31341 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I503f001e51144feeeb59a93ebc5d18d1368a7cde Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk[master]: sdk: Revert Replace decorators before marshal
by mishka8520＠yahoo.com 11 Aug '14

11 Aug '14

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: Revert Replace decorators before marshal ...................................................................... sdk: Revert Replace decorators before marshal Revert patch Replace decorators before marshal http://gerrit.ovirt.org/#/c/24131 Change-Id: Id18dc425c9bdff54cada4c62a3183fc729ae3b82 Bug-Url: https://bugzilla.redhat.com/1122546 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/ovirtsdk/utils/parsehelper.py 1 file changed, 3 insertions(+), 41 deletions(-) Approvals: Michael Pasternak: Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/31362 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id18dc425c9bdff54cada4c62a3183fc729ae3b82 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[sdk_3.5]: sdk: Revert Replace decorators before marshal
by mishka8520＠yahoo.com 11 Aug '14

11 Aug '14

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: Revert Replace decorators before marshal ...................................................................... sdk: Revert Replace decorators before marshal Revert patch Replace decorators before marshal http://gerrit.ovirt.org/#/c/24131 Change-Id: I5da35cbf75b6e29f5c5b4a79bd07d757691d5de1 Bug-Url: https://bugzilla.redhat.com/1122546 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/codegen/xsd/paramsconf.py M src/ovirtsdk/utils/parsehelper.py 2 files changed, 51 insertions(+), 41 deletions(-) Approvals: Michael Pasternak: Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/31358 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5da35cbf75b6e29f5c5b4a79bd07d757691d5de1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: userportal, webadmin: XSRF token generation fix
by awels＠redhat.com 11 Aug '14

11 Aug '14

Alexander Wels has submitted this change and it was merged. Change subject: userportal,webadmin: XSRF token generation fix ...................................................................... userportal,webadmin: XSRF token generation fix - Fix token generation to use session id instead of passed in jsessionid cookie, as that value might be stale. This prevents a lot of 500 errors in the log due to automatic login. Change-Id: I3e9a234bada73873f398d4220808f573810440dc Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1115918 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/OvirtXsrfTokenServiceServlet.java M frontend/webadmin/modules/frontend/src/main/resources/META-INF/web-fragment.xml 2 files changed, 28 insertions(+), 1 deletion(-) Approvals: Alexander Wels: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30849 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e9a234bada73873f398d4220808f573810440dc Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Calculate storage format when adding an SD
by tnisan＠redhat.com 11 Aug '14

11 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Calculate storage format when adding an SD ...................................................................... core: Calculate storage format when adding an SD Removed the default V1 format from StorageDomainStatic's constructor so it can be calculated when adding a domain without specifying the format via REST. The logic goes as follows: - If the format is specified (as is the case in all the edit scenarios as well as when adding a new domain via the GUI), leave it alone - If it's a data domain, set the format to the format required by the pool's version. Note: Creating a domain by a host not attached to a pool is currently NOT supported. This patch does not change that behavior, nor does it handle this situation. - If it's not a data domain, use V1 (i.e., preserve the old behavior). Change-Id: If469bb655e9a65e2d0afcee164655fa0bdfa5d99 Bug-Url: https://bugzilla.redhat.com/1120712 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatic.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDynamicDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainStaticDAOTest.java 4 files changed, 23 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/31348 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If469bb655e9a65e2d0afcee164655fa0bdfa5d99 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: AddStorageDomainCommand.getTargetStoragePool
by tnisan＠redhat.com 11 Aug '14

11 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: AddStorageDomainCommand.getTargetStoragePool ...................................................................... core: AddStorageDomainCommand.getTargetStoragePool Extracted AddStorageDomainCommand.getTargetStoragePool for later use (not to mention the increased readability). Change-Id: I3776beb5a7426e010f05ca0b4f3dffb128346ed7 Related-To: https://bugzilla.redhat.com/1120712 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java 1 file changed, 11 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/31347 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3776beb5a7426e010f05ca0b4f3dffb128346ed7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Fix confusing names in async tasks
by tnisan＠redhat.com 11 Aug '14

11 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: Fix confusing names in async tasks ...................................................................... engine: Fix confusing names in async tasks Fix confusing name for action and command parameters in AsyncTasks and Command Entities Change-Id: I6e619857ae36f1b69a4370ddcf53aee45c2c2c6f Bug-Url: https://bugzilla.redhat.com/1127774 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AsyncTasks.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/CommandEntity.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/CommandEntityDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/CommandEntityDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/async_tasks_sp.sql M packaging/dbscripts/command_entities_sp.sql A packaging/dbscripts/upgrade/03_05_0870_rename_async_tasks_columns.sql 12 files changed, 61 insertions(+), 50 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31345 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e619857ae36f1b69a4370ddcf53aee45c2c2c6f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Remove unused javassisst dependencies
by oourfali＠redhat.com 11 Aug '14

11 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Remove unused javassisst dependencies ...................................................................... engine: Remove unused javassisst dependencies The engine and its test suite do not use Javassisst directly - its is only used as part of the PowerMock mocking (and is required directly due to a bug in PowerMock's pom). Most of PowerMock's usages were removed from the engine a long time ago, with the exception being the jaxrs module. This patch removes the leftover javassisst dependencies from all the other modules that no longer require it. Change-Id: I360789865b8de899d1a04b0f8a974e95eecc65ca Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/restapi/types/pom.xml 3 files changed, 0 insertions(+), 17 deletions(-) Approvals: Ori Liel: Looks good to me, but someone else must approve Allon Mureinik: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I360789865b8de899d1a04b0f8a974e95eecc65ca Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0