- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Persist vm id for associating the event with the VM
by Code Review 30 Apr '17

30 Apr '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: Persist vm id for associating the event with the VM ...................................................................... engine: Persist vm id for associating the event with the VM The VM ID will be used to find events which are associated with the specific VM by its ID. Change-Id: I6e69cf3648d116cbe341bd7b01877b94d4b312ee Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/75717 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e69cf3648d116cbe341bd7b01877b94d4b312ee Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Avoid injection in DataCenterCompatibilityChecker
by Code Review 30 Apr '17

30 Apr '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: Avoid injection in DataCenterCompatibilityChecker ...................................................................... engine: Avoid injection in DataCenterCompatibilityChecker Change-Id: I13e8478d00c84963ca2a82f1016795ccc4f02c79 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DataCenterCompatibilityChecker.java 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/75331 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13e8478d00c84963ca2a82f1016795ccc4f02c79 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Lock a prestarted VM from pool when attaching to user
by Code Review 30 Apr '17

30 Apr '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: Lock a prestarted VM from pool when attaching to user ...................................................................... core: Lock a prestarted VM from pool when attaching to user When a prestarted VM from pool is being attached to user, the VM lock on it is added to the context, but not actually taken. Because of this, a race condition may happen when one and the same prestarted VM is given to several users. Change-Id: I8ffe5ab7675ef76ed0f39ac8ca2d6e7ff8da30a2 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java 1 file changed, 18 insertions(+), 28 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/75833 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ffe5ab7675ef76ed0f39ac8ca2d6e7ff8da30a2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Don't expect any pre-set values for the Logged event
by Code Review 30 Apr '17

30 Apr '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: Don't expect any pre-set values for the Logged event ...................................................................... engine: Don't expect any pre-set values for the Logged event With AuditLogableImpl there shouldn't be any assumption about initial values set to the logged entities. Therefore, we shouldn't rely on the existence of Host and Cluster when constructing the key to represent the event. Change-Id: I90012a2c531ea96728ecb5029fd095f6288e3217 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/EventKeyComposer.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76233 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90012a2c531ea96728ecb5029fd095f6288e3217 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: [RFE] exposed vm pause events for notification
by Code Review 29 Apr '17

29 Apr '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: engine: [RFE] exposed vm pause events for notification ...................................................................... engine: [RFE] exposed vm pause events for notification Events exposed for notification: VM_PAUSE_EIO VM_PAUSE_ENOSPC VM_PAUSE_EPERM VM_PAUSE_ERROR VM_RECOVERED_FROM_PAUSE_ERROR Change-Id: I8983daf4f52fc019744030df94322e8bee7e275b Bug-Url: https://bugzilla.redhat.com/1441059 Signed-off-by: Miroslava Voglova <mvoglova(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 3 files changed, 21 insertions(+), 1 deletion(-) Approvals: Miroslava Voglova: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/76082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8983daf4f52fc019744030df94322e8bee7e275b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Miroslava Voglova <mvoglova(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Miroslava Voglova <mvoglova(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: otopi: drop 3.6 and 4.0 jobs
by Code Review 28 Apr '17

28 Apr '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: otopi: drop 3.6 and 4.0 jobs ...................................................................... otopi: drop 3.6 and 4.0 jobs both 3.6 and 4.0 has gone EOL long ago, dropping otopi jobs left around. Change-Id: I63b403c73367e45373a37c30bcce399b35fbf430 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- D jobs/confs/projects/otopi/otopi_create-rpms.yaml M jobs/confs/projects/otopi/otopi_standard.yaml 2 files changed, 0 insertions(+), 47 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76209 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63b403c73367e45373a37c30bcce399b35fbf430 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: reporting mac_addresses, initial/upgrade versions, %memory, ...
by Code Review 28 Apr '17

28 Apr '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: reporting mac_addresses, initial/upgrade versions, %memory, %cpu ...................................................................... reporting mac_addresses, initial/upgrade versions, %memory, %cpu Change-Id: I68c080f0f03ab8d8cf2cd3bbcd8d302b80f2e1c5 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M src/inventory_report/produceReport.sh A src/inventory_report/sqls/engine_versions_through_all_upgrades.sql A src/inventory_report/sqls/networks_table_not_using_network_attachments.sql A src/inventory_report/sqls/networks_table_using_network_attachments.sql 4 files changed, 106 insertions(+), 83 deletions(-) Approvals: Douglas Schilling Landgraf: Looks good to me, approved Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76081 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68c080f0f03ab8d8cf2cd3bbcd8d302b80f2e1c5 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: do not require execution from current dir + init variables o...
by Code Review 28 Apr '17

28 Apr '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: do not require execution from current dir + init variables on 1 place ...................................................................... do not require execution from current dir + init variables on 1 place • uninitialized variables, inlined function 'initDbVariables' • script needs not to be executed from current directory, thus 'sqls' directory needs to be referenced in relations to produceReport script Change-Id: Ibb424687aee48708203668af9234eafd620d5d05 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M src/inventory_report/produceReport.sh 1 file changed, 11 insertions(+), 16 deletions(-) Approvals: Douglas Schilling Landgraf: Looks good to me, approved Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76063 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb424687aee48708203668af9234eafd620d5d05 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: automation: moved findbugs check to check-patch and check-me...
by Code Review 28 Apr '17

28 Apr '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: automation: moved findbugs check to check-patch and check-merged ...................................................................... automation: moved findbugs check to check-patch and check-merged Instead of having a dedicated job(s) for findbugs, I've added support for exporting findbugs.xml files from any std ci jenkins job. Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-536 Change-Id: I1d393265348450aaffcb103500ef3a3834829b57 Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com> --- M automation/check-merged.sh M automation/check-patch.sh A automation/findbugs.sh 3 files changed, 29 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Daniel Belenky: Verified; Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75460 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d393265348450aaffcb103500ef3a3834829b57 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: he: Fixed connect/disconnect options description.
by Code Review 28 Apr '17

28 Apr '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: he: Fixed connect/disconnect options description. ...................................................................... he: Fixed connect/disconnect options description. connect/disconnect options operate only on hosted engine storage domain, not all domains. Change-Id: I550da2d1c871b097be3d4f68938c9ea7aeda3924 Signed-off-by: Denis Chaplygin <dchaplyg(a)redhat.com> --- M src/bin/hosted-engine.in 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Denis Chaplygin: Verified Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Andrej Krejcir: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/76112 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I550da2d1c871b097be3d4f68938c9ea7aeda3924 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0