- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: minor cleanup in vms monitoring
by Code Review 27 Apr '17

27 Apr '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: minor cleanup in vms monitoring ...................................................................... core: minor cleanup in vms monitoring Add getVmManager method. Change-Id: I69a760818fe868b9a46b74e0ffb516df3c043df6 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/76034 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69a760818fe868b9a46b74e0ffb516df3c043df6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cleanup in SetVmStatus
by Code Review 27 Apr '17

27 Apr '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup in SetVmStatus ...................................................................... core: cleanup in SetVmStatus 1. This command is called internally from just a few places so we can remove the validation of the parameters at the beginning of the execute method. 2. This command is not used for setting the VM status to Unknown thus the code for this specific case is removed. 3. This command is only used to set the VM status to Down or ImageLocked, in both statuses the VM is not running, thus its execute method can be simplified. Change-Id: I724544f8063e04a7a5405a8e5cc25abea87c3b42 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetVmStatusVDSCommand.java 1 file changed, 5 insertions(+), 21 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/76033 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I724544f8063e04a7a5405a8e5cc25abea87c3b42 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[ovirt-host-deploy-1.6]: metrics: Make collectd/fluentd packages optional
by Code Review 27 Apr '17

27 Apr '17

>From Yedidyah Bar David <didi(a)redhat.com>: Yedidyah Bar David has submitted this change and it was merged. Change subject: metrics: Make collectd/fluentd packages optional ...................................................................... metrics: Make collectd/fluentd packages optional Emit a warning if they are missing but do not fail deploy. Change-Id: Ic2df4e82c92cfbf6c7df15c1ceca0600626e4385 Bug-Url: https://bugzilla.redhat.com/1443508 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit d3e77e7ae4c29ae5a9ea35e43cfc835dac117cd7) --- M src/plugins/ovirt-host-deploy/collectd/packages.py M src/plugins/ovirt-host-deploy/fluentd/packages.py 2 files changed, 34 insertions(+), 12 deletions(-) Approvals: Ido Rosenzwig: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2df4e82c92cfbf6c7df15c1ceca0600626e4385 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: ovirt-host-deploy-1.6 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.1]: Add list of build packages for Fedora 25
by Code Review 27 Apr '17

27 Apr '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add list of build packages for Fedora 25 ...................................................................... Add list of build packages for Fedora 25 This patch adds the 'build.packages.fc25' file containing the list of packages needed by the automation environment to build in Fedora 25. Change-Id: I0c9712c363e6bdbdda73526c51a8c8effa6f9660 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A automation/build-artifacts.packages.fc25 A automation/build.packages.fc25 A automation/check-merged.packages.fc25 A automation/check-patch.packages.fc25 4 files changed, 26 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76111 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c9712c363e6bdbdda73526c51a8c8effa6f9660 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Remove dead code
by Code Review 27 Apr '17

27 Apr '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: Remove dead code ...................................................................... engine: Remove dead code Change-Id: I1a1b948dc15ee9a6385aacd4df304e5da8dd5cae Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceQueryBase.java 1 file changed, 0 insertions(+), 26 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/75332 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a1b948dc15ee9a6385aacd4df304e5da8dd5cae Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Removed 3.6 option from the manual job
by Code Review 27 Apr '17

27 Apr '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: Removed 3.6 option from the manual job ...................................................................... Removed 3.6 option from the manual job Change-Id: I5ee90a3c93ecb7e3959c8be007c8ce3fd445a121 Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com> --- M jobs/confs/yaml/parmeters/upgrade-table.yaml 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Eyal Edri: Looks good to me, approved; Ready for merge Daniel Belenky: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ee90a3c93ecb7e3959c8be007c8ce3fd445a121 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Simplify EventFloodRegulator
by Code Review 27 Apr '17

27 Apr '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: Simplify EventFloodRegulator ...................................................................... engine: Simplify EventFloodRegulator The method updateTimeoutLogableObject can be called from within the c'tor and to initialize the instance for its legality. Change-Id: I649b273cccd627755f36378c5ea77628c477726d Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/EventFloodRegulator.java 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76072 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I649b273cccd627755f36378c5ea77628c477726d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Introduce AuditLogableImpl
by Code Review 27 Apr '17

27 Apr '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: Introduce AuditLogableImpl ...................................................................... engine: Introduce AuditLogableImpl AuditLogableImpl is a POJO which could be used for logging an event by the AuditLogDirector without the need to consider how the various members should be evaluated. It purely logs only the data that was provided by the user, therefore it is the responsibility of the user to set any relevant data for the event. As future improvement, we can set the logic to populate the fields which could be resolved transitively on the DB level, by adding that logic to the Insert statement of the audit_log table. Change-Id: I7c2770d31f4ad9dcd39be1700762bf556cd805d1 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableImpl.java 1 file changed, 445 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76048 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c2770d31f4ad9dcd39be1700762bf556cd805d1 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Extract AuditLogable interface from AuditLogableBase
by Code Review 27 Apr '17

27 Apr '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: Extract AuditLogable interface from AuditLogableBase ...................................................................... engine: Extract AuditLogable interface from AuditLogableBase The interface will allow to use the AuditLogable outside of the contexts of commands safetly. The AuditLogDirector will not make any assumptions for the implementation of the logged entity. By defining AuditLogable, we set the ground for introducing a POJO implementation for AuditLogable which will avoid any need to inject DAOs. However, it will require to speicfy the data explicitly. Change-Id: I58ed8ca0ebadb381ecb67531a6c39a80ac90edc4 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogable.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/EventFloodRegulator.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/EventKeyComposer.java 5 files changed, 229 insertions(+), 63 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76046 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58ed8ca0ebadb381ecb67531a6c39a80ac90edc4 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Add EventKeyComposerTest
by Code Review 27 Apr '17

27 Apr '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: Add EventKeyComposerTest ...................................................................... engine: Add EventKeyComposerTest Change-Id: I402fc8776b815d6c192afa72ad8e7b5821d3831c Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/EventKeyComposerTest.java 1 file changed, 47 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76058 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I402fc8776b815d6c192afa72ad8e7b5821d3831c Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0