- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: macPool per DC, db changes
by lvernia＠redhat.com 04 Aug '14

04 Aug '14

Lior Vernia has submitted this change and it was merged. Change subject: core: macPool per DC, db changes ...................................................................... core: macPool per DC, db changes * add table mac_pools — for pool data * add table mac_pool_ranges — for each range of given pool * add respective business entities Change-Id: Id30f3c384ecf933daaacdbdd6542e88afb98f7ca Bug-Url: https://bugzilla.redhat.com/1078844 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/MacPool.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/MacRange.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/MacPoolDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/MacPoolDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/jdbc-resources/engine-daos.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/MacPoolDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StoragePoolDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml A packaging/dbscripts/mac_pools_sp.sql M packaging/dbscripts/storages_sp.sql A packaging/dbscripts/upgrade/03_06_0090_add_mac_pool_ranges_to_storage_pool.sql 17 files changed, 880 insertions(+), 32 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id30f3c384ecf933daaacdbdd6542e88afb98f7ca Gerrit-PatchSet: 43 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: set template id in ctor
by oourfali＠redhat.com 04 Aug '14

04 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine: set template id in ctor ...................................................................... engine: set template id in ctor When not setting the template id before the execute we have an empty id for the template. If we are failing with adding image to the template and the engine is reset we are deleting the blank template! When setting the template id right at the beginning prevent this kind of races. Bug-Url: https://bugzilla.redhat.com/1105211 Change-Id: I696e572ce87f9fe041a50ca4a88584df385ea353 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I696e572ce87f9fe041a50ca4a88584df385ea353 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: enable to sort DC according to version.
by oourfali＠redhat.com 04 Aug '14

04 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: enable to sort DC according to version. ...................................................................... core: enable to sort DC according to version. enable to sort DC according to compatibility version in DC TAB. Change-Id: I7a2ba8e21ca1cdf63f635d80a66e6d52ae48bba0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1124378 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDataCenterView.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Eli Mesika: Verified Gilad Chaplik: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30969 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a2ba8e21ca1cdf63f635d80a66e6d52ae48bba0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: setup: use own connection
by ydary＠redhat.com 04 Aug '14

04 Aug '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: use own connection ...................................................................... packaging: setup: use own connection Revert I7ba25d4b5dc7cb7ab4e3d8beaa52cfb7ac7087b6 . Requires http://gerrit.ovirt.org/31001 . We can't use an existing connection when on separate hosts. Instead just prevent the conflict by making the engine not update the same row. Change-Id: Ia6de30c43fbe395fb293eed31930ba4be7d702f5 Bug-Url: https://bugzilla.redhat.com/1080998 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Yedidyah Bar David: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31002 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6de30c43fbe395fb293eed31930ba4be7d702f5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Add audit log when removing networks from iSCSI bond.
by mlipchuk＠redhat.com 04 Aug '14

04 Aug '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add audit log when removing networks from iSCSI bond. ...................................................................... core: Add audit log when removing networks from iSCSI bond. Adding an audit log to indicate the user that the removed networks from the iSCSI bond, will only take affect, after the Hosts will be moved to maintenance and activated again. Change-Id: I087818bb48cc9243e76b2cb850e6262104537f3c Bug-Url: https://bugzilla.redhat.com/1094144 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/EditIscsiBondCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 22 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/30988 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I087818bb48cc9243e76b2cb850e6262104537f3c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: setup: do not update RedirectServletReportsPage
by sbonazzo＠redhat.com 04 Aug '14

04 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: do not update RedirectServletReportsPage ...................................................................... packaging: setup: do not update RedirectServletReportsPage It is not the engine's job to update this, but rather Reports'. Currently if setting up both of them at same engine-setup run, there is a race condition. A first solution was http://gerrit.ovirt.org/29640 , which works when both on same host but fails if separate. Change-Id: I203fda5fc153df608db559f6e627c7ccd4a8f24f Bug-Url: https://bugzilla.redhat.com/1080998 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/options.py 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Verified Yaniv Dary: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31001 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I203fda5fc153df608db559f6e627c7ccd4a8f24f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[ovirt-engine-reports-3.4]: reports: remove war file for new db
by ydary＠redhat.com 04 Aug '14

04 Aug '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: remove war file for new db ...................................................................... reports: remove war file for new db updated abort, when clean install will remove deployed files. Change-Id: Ief7abeee5c139ccd5877c013b4cf7f55a3521782 Bug-Url: https://bugzilla.redhat.com/1124383 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31003 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief7abeee5c139ccd5877c013b4cf7f55a3521782 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.4 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in gerrit-admin[master]: Not moving bugs to MODIFIED when branch is master
by dcaroest＠redhat.com 04 Aug '14

04 Aug '14

David Caro has submitted this change and it was merged. Change subject: Not moving bugs to MODIFIED when branch is master ...................................................................... Not moving bugs to MODIFIED when branch is master Change-Id: Ic016cd4fbb9043b82c6c0004fe6f3e57a5bb84b8 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M hooks/custom_hooks/change-merged.set_MODIFIED 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30765 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic016cd4fbb9043b82c6c0004fe6f3e57a5bb84b8 Gerrit-PatchSet: 1 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: allow read-only for VirtIO-SCSI DirectLUN disks
by tnisan＠redhat.com 04 Aug '14

04 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: allow read-only for VirtIO-SCSI DirectLUN disks ...................................................................... core: allow read-only for VirtIO-SCSI DirectLUN disks In order to support read-only property for VirtIO-SCSI DirectLUN disks, the device type for such disks should be 'disk' (SCSI emulation) instead of 'lun' (SCSI pass-through). I.e. representation in the domain xml sent to libvirt should look like [1] instead of [2]. Note that this limitation (enabling pass-through for read-only VirtIO-SCSI DirectLUN disks) could be removed once 'Support read only VirtIO-SCSI direct LUNs in QEMU' bug [3] is resolved. To provide full flexibility, added a new check-box for enabling pass-through (see screenshot [4]). I.e. the user can choose between emulated and pass-through ('disk' vs. 'lun'); read-only is currently supported only for emulated. [1] <disk type='block' device='disk'>...</disk> [2] <disk type='block' device='lun'>...</disk> [3] https://bugzilla.redhat.com/1110396 [4] screenshot: http://i.imgur.com/5mS3xSk.jpg Change-Id: Ic317722be9ef8978b50352c12bc06ea8c906dcd0 Bug-Url: https://bugzilla.redhat.com/1118847 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/DiskValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BaseDisk.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties A packaging/dbscripts/upgrade/03_05_0810_update_sgio_for_readonly_disks.sql 17 files changed, 135 insertions(+), 27 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/30885 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic317722be9ef8978b50352c12bc06ea8c906dcd0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: fixing nfs mountpoint FQDN regex
by tnisan＠redhat.com 04 Aug '14

04 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: fixing nfs mountpoint FQDN regex ...................................................................... core: fixing nfs mountpoint FQDN regex *the regex now supports fqdn similar to: "foo.example.f7:/<export>" *minor structural fixes of the regex Change-Id: Iba3121b602d9e2e21bc120875cdfc4298f872841 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1126342 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NfsMountPointConstraint.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/validation/NFSMountPointConstraintTest.java 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/30995 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba3121b602d9e2e21bc120875cdfc4298f872841 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0