- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: aaa: sync: copy isAdmin from existing user
by oourfali＠redhat.com 02 Aug '14

02 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: sync: copy isAdmin from existing user ...................................................................... aaa: sync: copy isAdmin from existing user in role based security there should be no duplication of roles, but in ovirt-engine schema we have isAdmin marker, although the role can be queried. temporary solution is to copy existing user's bit into synced user. long term solution is to remove this duplication. Topic: AAA Change-Id: Id62a2a774c102e3e31c022456809b4b2eb2319b2 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SyncUsers.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id62a2a774c102e3e31c022456809b4b2eb2319b2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: populate display group earlier at login
by oourfali＠redhat.com 02 Aug '14

02 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: populate display group earlier at login ...................................................................... aaa: populate display group earlier at login we have a mess between groups that we display and group that we actually use (uuid), populate display group earlier in login. Topic: AAA Change-Id: I01da660c44899eabc85da5c23540ca6a9e8ec433 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Ravi Nori: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30930 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01da660c44899eabc85da5c23540ca6a9e8ec433 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: Added ovirt-engine-extension-logger-log4j rpm jobs
by dcaroest＠redhat.com 01 Aug '14

01 Aug '14

David Caro has submitted this change and it was merged. Change subject: Added ovirt-engine-extension-logger-log4j rpm jobs ...................................................................... Added ovirt-engine-extension-logger-log4j rpm jobs Change-Id: Ice0c6c4fb89d1cab2e8a02d19baf5b611cf3ac6d Signed-off-by: David Caro <dcaroest(a)redhat.com> --- A jobs/confs/yaml/jobs/ovirt-engine-extension-logger-log4j/ovirt-engine-extension-logger-log4j_create-rpms.yaml A jobs/confs/yaml/scms/ovirt-engine-extension-logger-log4j.yaml 2 files changed, 38 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30886 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice0c6c4fb89d1cab2e8a02d19baf5b611cf3ac6d Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: Added ovirt-engine-extension-aaa-misc rpm jobs
by dcaroest＠redhat.com 01 Aug '14

01 Aug '14

David Caro has submitted this change and it was merged. Change subject: Added ovirt-engine-extension-aaa-misc rpm jobs ...................................................................... Added ovirt-engine-extension-aaa-misc rpm jobs Change-Id: I9dc594e2f800c59c61703a126797013930612856 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- A jobs/confs/yaml/jobs/ovirt-engine-extension-aaa-misc/ovirt-engine-extension-aaa-misc_create-rpms.yaml A jobs/confs/yaml/scms/ovirt-engine-extension-aaa-misc.yaml 2 files changed, 38 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9dc594e2f800c59c61703a126797013930612856 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: Added ovirt-engine-extension-aaa-ldap rpm jobs
by dcaroest＠redhat.com 01 Aug '14

01 Aug '14

David Caro has submitted this change and it was merged. Change subject: Added ovirt-engine-extension-aaa-ldap rpm jobs ...................................................................... Added ovirt-engine-extension-aaa-ldap rpm jobs Change-Id: I2762dbefbb7eff0c874b3751d2aae1197e741cc4 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- A jobs/confs/yaml/jobs/ovirt-engine-extension-aaa-ldap/ovirt-engine-extension-aaa-ldap_create-rpms.yaml A jobs/confs/yaml/scms/ovirt-engine-extension-aaa-ldap.yaml 2 files changed, 38 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2762dbefbb7eff0c874b3751d2aae1197e741cc4 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: engine-cleanup refuses to remove a differe...
by piotr.kliczewski＠gmail.com 01 Aug '14

01 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: packaging: setup: engine-cleanup refuses to remove a different version ...................................................................... packaging: setup: engine-cleanup refuses to remove a different version engine-cleanup should refuse to remove a version of the engine where the x or y version number are different or where the z is major Change-Id: I06b0d3437bfca4f4e63be4c212f15e98f5617bfd Bug-Url: https://bugzilla.redhat.com/1118360 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit e0f57f0ae5887da0148fc8528a1a32851ec4ac36) --- M packaging/setup/plugins/ovirt-engine-remove/base/core/misc.py 1 file changed, 30 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/30750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06b0d3437bfca4f4e63be4c212f15e98f5617bfd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: packaging: setup: validate unicast MAC address
by sbonazzo＠redhat.com 01 Aug '14

01 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: validate unicast MAC address ...................................................................... packaging: setup: validate unicast MAC address Change-Id: I6af3523bff99d153691996152f39b7d4750eeaf5 Bug-Url: https://bugzilla.redhat.com/1116785 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit 6c1b4046ea12306dc8dd556f0ca41f70defdbfe6) --- M src/ovirt_hosted_engine_setup/util.py M src/plugins/ovirt-hosted-engine-setup/vm/mac.py 2 files changed, 24 insertions(+), 20 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30926 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6af3523bff99d153691996152f39b7d4750eeaf5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: validate unicast MAC address
by sbonazzo＠redhat.com 01 Aug '14

01 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: validate unicast MAC address ...................................................................... packaging: setup: validate unicast MAC address Change-Id: I6af3523bff99d153691996152f39b7d4750eeaf5 Bug-Url: https://bugzilla.redhat.com/1116785 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/ovirt_hosted_engine_setup/util.py M src/plugins/ovirt-hosted-engine-setup/vm/mac.py 2 files changed, 24 insertions(+), 20 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jiří Moskovčák: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6af3523bff99d153691996152f39b7d4750eeaf5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-release[master]: Updated EL dependencies repo
by sbonazzo＠redhat.com 01 Aug '14

01 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: Updated EL dependencies repo ...................................................................... Updated EL dependencies repo - provide EL7 dependencies for 3.5 - add python-ioprocess from EPEL repository for vdsm on 3.5 and master Change-Id: I1c2dba4d15c807635911c41724329c0e02669df4 Bug-Url: https://bugzilla.redhat.com/1124802 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-release-3.5/Makefile.am M ovirt-release-3.5/configure.ac R ovirt-release-3.5/ovirt-el6-deps.repo.in C ovirt-release-3.5/ovirt-el7-deps.repo.in M ovirt-release-3.5/ovirt-release35.spec.in M ovirt-release-master/ovirt-el6-deps.repo.in M ovirt-release-master/ovirt-el7-deps.repo.in 7 files changed, 23 insertions(+), 23 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30921 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c2dba4d15c807635911c41724329c0e02669df4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Fixes StackOverflowError during fencing
by piotr.kliczewski＠gmail.com 01 Aug '14

01 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Fixes StackOverflowError during fencing ...................................................................... core: Fixes StackOverflowError during fencing Fixes StackOverflowError appeared during execution of fencing operation. This fix removes commandContex instance and overriden getContext() from RestartVdsCommand, because command context in CommandBase should be set always during creation of command and successful locks aquiring is checked prior to executeCommand call in CommandBase. Also when RestartVdsCommand and its inherited commands are using global command context, VdsKdumpDetection command executed from VdsNotRespondingTreatmentCommand should also use global command context and not its copy. The overriden getContext() has been introduced in Iaf021010188e3c3662fbf8a057da4c58f2600c02. Change-Id: Icbe5ad9194b19a390f45c99198087a9e5b68eb9c Bug-Url: https://bugzilla.redhat.com/1124141 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsKdumpDetectionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java 3 files changed, 2 insertions(+), 16 deletions(-) Approvals: Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30906 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbe5ad9194b19a390f45c99198087a9e5b68eb9c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0