- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Don't send SetStoragePoolDescription
by amureini＠redhat.com 29 Jul '14

29 Jul '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Don't send SetStoragePoolDescription ...................................................................... core: Don't send SetStoragePoolDescription The storage pool description is never read in VDSM and thus updating it is a useless (and expensive!) call. Moreover, this call cannot be trusted - since it's only sent if the DC's status is UP, there may very well be a situation where the DC's name in the engine and the pool's description in VDSM do not match. This patch removes this redundant and harmful call. Topic: remove-sp-description Change-Id: I5664c9912d07f9fbb99af315e904270597adbd73 Bug-Url: https://bugzilla.redhat.com/1096215 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetStoragePoolDescriptionVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerWrapper.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SetStoragePoolDescriptionVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java 8 files changed, 0 insertions(+), 79 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Federico Simoncelli: Looks good to me, but someone else must approve Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/30464 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5664c9912d07f9fbb99af315e904270597adbd73 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Adjust Un/LabelNetworkCommand to use commandBase.run...
by alkaplan＠redhat.com 29 Jul '14

29 Jul '14

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Adjust Un/LabelNetworkCommand to use commandBase.runInternalAction ...................................................................... engine: Adjust Un/LabelNetworkCommand to use commandBase.runInternalAction UnlabelNetworkCommand and LabelNetworkCommand call UpdateNetworkCommand internally. For unknown reason they used getBackend().runAction(..) for this purpose. Since the call to UpdateNetworkCommand is internal runInternalAction(..) should be called. Due to the last changes to CommandBase- commandBase.runInternalAction(..) should be used. Change-Id: Ibbe6c0e74129c2ae25d540331a93225181ae41c8 Bug-Url: https://bugzilla.redhat.com/1123636 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/LabelNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkCommon.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkModification.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UnlabelNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 5 files changed, 17 insertions(+), 3 deletions(-) Approvals: Alona Kaplan: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30753 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibbe6c0e74129c2ae25d540331a93225181ae41c8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add disk - storage domain not specified error message
by derez＠redhat.com 28 Jul '14

28 Jul '14

Daniel Erez has submitted this change and it was merged. Change subject: core: add disk - storage domain not specified error message ...................................................................... core: add disk - storage domain not specified error message AddDiskCommand -> canDo: added a verification that a storage domain ID has been specified by the client (and return an appropriate error message accordingly). Change-Id: Ibd74f8ecd23b3c01108c31a0bb46f99002fd7071 Bug-Url: https://bugzilla.redhat.com/1120768 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 11 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30633 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd74f8ecd23b3c01108c31a0bb46f99002fd7071 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: frontend: Fix issues with VmRngDevice.Source enum
by piotr.kliczewski＠gmail.com 28 Jul '14

28 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: frontend: Fix issues with VmRngDevice.Source enum ...................................................................... frontend: Fix issues with VmRngDevice.Source enum this patch fixes problems with ^ enum parsing in ClusterModel. This enum is represented as lower-case string in the engine config. When matching this enum to its string representation, toLowerCase() must be called firstly. Change-Id: Ieeb5660fe5da4ea1ba913247150d4c63cecae1bb Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1122921 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/30679 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieeb5660fe5da4ea1ba913247150d4c63cecae1bb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine : CommandExecutor should handle exception in CallBack...
by piotr.kliczewski＠gmail.com 28 Jul '14

28 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine : CommandExecutor should handle exception in CallBackMethods ...................................................................... engine : CommandExecutor should handle exception in CallBackMethods If one of the callback methods raises an exception, the framework keeps calling the method again the next loop iteration. In some circumstances this means the command will never converge--e.g. coding errors, database connection failures, etc. Change-Id: I06b82f29ac31fd09903d76f87e839d8ac32ef1e1 Bug-Url: https://bugzilla.redhat.com/1121237 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCache.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/TaskManagerUtil.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCRUDOperations.java 7 files changed, 57 insertions(+), 32 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30703 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06b82f29ac31fd09903d76f87e839d8ac32ef1e1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine : Remove ACTIVE_ASYNC status
by piotr.kliczewski＠gmail.com 28 Jul '14

28 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine : Remove ACTIVE_ASYNC status ...................................................................... engine : Remove ACTIVE_ASYNC status Remove ACTIVE_ASYNC command status Change-Id: I382790a2f4042f2924a0916f62047790bb6d5e94 Bug-Url: https://bugzilla.redhat.com/1118249 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DestroyImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeStatusCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/CommandStatus.java 8 files changed, 1 insertion(+), 19 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I382790a2f4042f2924a0916f62047790bb6d5e94 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine : Simplify persistCommand
by piotr.kliczewski＠gmail.com 28 Jul '14

28 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine : Simplify persistCommand ...................................................................... engine : Simplify persistCommand Simplify persist command in command base Change-Id: Ie6f38c3eb2a38536febe7f65c65b256d0c0798f3 Bug-Url: https://bugzilla.redhat.com/1118249 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DestroyImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeStatusCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java 7 files changed, 7 insertions(+), 11 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30701 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6f38c3eb2a38536febe7f65c65b256d0c0798f3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: Adding namespace dropdown list to "add user" dialog
by piotr.kliczewski＠gmail.com 28 Jul '14

28 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: aaa: Adding namespace dropdown list to "add user" dialog ...................................................................... aaa: Adding namespace dropdown list to "add user" dialog This both adds the namespace dropdown list and fixes search to support namespace Topic: AAA Bug-Url: https://bugzilla.redhat.com/1117502 Change-Id: Ic78559243c765271bf8e12abd035deba05226bda Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAvailableAuthzNamespacesQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAvailableNamespacesQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/DirectorySearchParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAvailableAuthzNamespacesQueryParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendDomainGroupsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendDomainUsersResource.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java 14 files changed, 204 insertions(+), 42 deletions(-) Approvals: Alon Bar-Lev: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30755 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic78559243c765271bf8e12abd035deba05226bda Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[ovirt-engine-reports-3.4]: reports: do not provide default theme
by ydary＠redhat.com 28 Jul '14

28 Jul '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: do not provide default theme ...................................................................... reports: do not provide default theme This can cause upgrade issue from version to version in JRS. Change-Id: I82023e99e8efe402df41e80d52bc33ac012e80f7 Bug-Url: https://bugzilla.redhat.com/1112641 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> (cherry picked from commit 2265cc8eea7e1369b941eec2b1e4d566be5ac360) --- M packaging/ovirt-reports/resources/themes/.folder.xml D packaging/ovirt-reports/resources/themes/default/.folder.xml D packaging/ovirt-reports/resources/themes/default/buttons.css.data D packaging/ovirt-reports/resources/themes/default/buttons.css.xml D packaging/ovirt-reports/resources/themes/default/containers.css.data D packaging/ovirt-reports/resources/themes/default/containers.css.xml D packaging/ovirt-reports/resources/themes/default/controls.css.data D packaging/ovirt-reports/resources/themes/default/controls.css.xml D packaging/ovirt-reports/resources/themes/default/dataDisplays.css.data D packaging/ovirt-reports/resources/themes/default/dataDisplays.css.xml D packaging/ovirt-reports/resources/themes/default/dialogSpecific.css.data D packaging/ovirt-reports/resources/themes/default/dialogSpecific.css.xml D packaging/ovirt-reports/resources/themes/default/forPrint.css.data D packaging/ovirt-reports/resources/themes/default/forPrint.css.xml D packaging/ovirt-reports/resources/themes/default/images/.folder.xml D packaging/ovirt-reports/resources/themes/default/images/adhoc_datatree_icons_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/adhoc_datatree_icons_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/adhoc_toolbar_buttons_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/adhoc_toolbar_buttons_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/banner_bkgd.png.data D packaging/ovirt-reports/resources/themes/default/images/banner_bkgd.png.xml D packaging/ovirt-reports/resources/themes/default/images/button_action_primary_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/button_action_primary_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/button_action_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/button_action_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/button_action_square_icons_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/button_action_square_icons_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/button_capsule_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/button_capsule_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/button_options_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/button_options_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/column_header_bkgd.png.data D packaging/ovirt-reports/resources/themes/default/images/column_header_bkgd.png.xml D packaging/ovirt-reports/resources/themes/default/images/cursor_copy.cur.data D packaging/ovirt-reports/resources/themes/default/images/cursor_copy.cur.xml D packaging/ovirt-reports/resources/themes/default/images/cursor_copy.png.data D packaging/ovirt-reports/resources/themes/default/images/cursor_copy.png.xml D packaging/ovirt-reports/resources/themes/default/images/disclosure_indicators_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/disclosure_indicators_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/floatingMenu_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/floatingMenu_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/grid_20x20_bkgd.png.data D packaging/ovirt-reports/resources/themes/default/images/grid_20x20_bkgd.png.xml D packaging/ovirt-reports/resources/themes/default/images/home_bkgd.png.data D packaging/ovirt-reports/resources/themes/default/images/home_bkgd.png.xml D packaging/ovirt-reports/resources/themes/default/images/home_icons_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/home_icons_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/inner_pagination_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/inner_pagination_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/input_bkgd.png.data D packaging/ovirt-reports/resources/themes/default/images/input_bkgd.png.xml D packaging/ovirt-reports/resources/themes/default/images/list_node_animation.gif.data D packaging/ovirt-reports/resources/themes/default/images/list_node_animation.gif.xml D packaging/ovirt-reports/resources/themes/default/images/list_pressed_bkgd.png.data D packaging/ovirt-reports/resources/themes/default/images/list_pressed_bkgd.png.xml D packaging/ovirt-reports/resources/themes/default/images/lists_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/lists_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/loadinfo.gif.data D packaging/ovirt-reports/resources/themes/default/images/loadinfo.gif.xml D packaging/ovirt-reports/resources/themes/default/images/login_welcome_bkgd.jpg.data D packaging/ovirt-reports/resources/themes/default/images/login_welcome_bkgd.jpg.xml D packaging/ovirt-reports/resources/themes/default/images/login_welcome_ce_bkgd.jpg.data D packaging/ovirt-reports/resources/themes/default/images/login_welcome_ce_bkgd.jpg.xml D packaging/ovirt-reports/resources/themes/default/images/logo.png.data D packaging/ovirt-reports/resources/themes/default/images/logo.png.xml D packaging/ovirt-reports/resources/themes/default/images/menu_primaryNav_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/menu_primaryNav_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/message_icons_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/message_icons_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/panel_inset_inset_bkgd.png.data D packaging/ovirt-reports/resources/themes/default/images/panel_inset_inset_bkgd.png.xml D packaging/ovirt-reports/resources/themes/default/images/panel_sizer_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/panel_sizer_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/report_load_animation.gif.data D packaging/ovirt-reports/resources/themes/default/images/report_load_animation.gif.xml D packaging/ovirt-reports/resources/themes/default/images/search_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/search_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/sort_indicators_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/sort_indicators_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/spacer.gif.data D packaging/ovirt-reports/resources/themes/default/images/spacer.gif.xml D packaging/ovirt-reports/resources/themes/default/images/tabs_horizontal_buttons_bkgd.png.data D packaging/ovirt-reports/resources/themes/default/images/tabs_horizontal_buttons_bkgd.png.xml D packaging/ovirt-reports/resources/themes/default/images/tabs_horizontal_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/tabs_horizontal_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/tabs_vertical_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/tabs_vertical_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/viewer_toolbar_buttons_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/viewer_toolbar_buttons_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/wait_animation_large.gif.data D packaging/ovirt-reports/resources/themes/default/images/wait_animation_large.gif.xml D packaging/ovirt-reports/resources/themes/default/lists.css.data D packaging/ovirt-reports/resources/themes/default/lists.css.xml D packaging/ovirt-reports/resources/themes/default/overrides_custom.css.data D packaging/ovirt-reports/resources/themes/default/overrides_custom.css.xml D packaging/ovirt-reports/resources/themes/default/overrides_ie.css.data D packaging/ovirt-reports/resources/themes/default/overrides_ie.css.xml D packaging/ovirt-reports/resources/themes/default/overrides_ie7.css.data D packaging/ovirt-reports/resources/themes/default/overrides_ie7.css.xml D packaging/ovirt-reports/resources/themes/default/overrides_ie8.css.data D packaging/ovirt-reports/resources/themes/default/overrides_ie8.css.xml D packaging/ovirt-reports/resources/themes/default/pageSpecific.css.data D packaging/ovirt-reports/resources/themes/default/pageSpecific.css.xml D packaging/ovirt-reports/resources/themes/default/pages.css.data D packaging/ovirt-reports/resources/themes/default/pages.css.xml D packaging/ovirt-reports/resources/themes/default/samples.css.data D packaging/ovirt-reports/resources/themes/default/samples.css.xml D packaging/ovirt-reports/resources/themes/default/theme.css.data D packaging/ovirt-reports/resources/themes/default/theme.css.xml 109 files changed, 0 insertions(+), 12,854 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30761 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82023e99e8efe402df41e80d52bc33ac012e80f7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.4 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: Fix "directory group" sub tab
by piotr.kliczewski＠gmail.com 28 Jul '14

28 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: aaa: Fix "directory group" sub tab ...................................................................... aaa: Fix "directory group" sub tab Some changes were made to the directory group sub tab of users: 1. Organizational unit is removed, as relevant for ldap providers, and engine/ui should be agnostic to provider type 2. namespace is introduced , same as in other places in ui (for example at the add user/group dialog). Topic: AAA Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720 Change-Id: I2125c11f60576d9c2fd9fa3d2771cb34145cccc2 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/comparators/UserGroupComparator.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserGroup.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserGroupListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/user/SubTabUserGroupView.java 5 files changed, 42 insertions(+), 54 deletions(-) Approvals: Alon Bar-Lev: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30746 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2125c11f60576d9c2fd9fa3d2771cb34145cccc2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0