- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core: GetRngDeviceQuery should be a user query
by oourfali＠redhat.com 27 Jul '14

27 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: GetRngDeviceQuery should be a user query ...................................................................... core: GetRngDeviceQuery should be a user query Change-Id: I5589c7185a61c076123aee962c8ea2c097920617 Bug-Url: https://bugzilla.redhat.com/1122427 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetRngDeviceQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 2 files changed, 9 insertions(+), 4 deletions(-) Approvals: Frank Kobzik: Verified Omer Frenkel: Looks good to me, approved Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30619 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5589c7185a61c076123aee962c8ea2c097920617 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Minor adjustment for remove external network message
by masayag＠redhat.com 27 Jul '14

27 Jul '14

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Minor adjustment for remove external network message ...................................................................... webadmin: Minor adjustment for remove external network message Change-Id: If65a2cf50bb89b29988913fd8801b4ce32ef6e95 Bug-Url: https://bugzilla.redhat.com/1101068 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Lior Vernia: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/30726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If65a2cf50bb89b29988913fd8801b4ce32ef6e95 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: More accurate wording for IntegerValidation
by lvernia＠redhat.com 27 Jul '14

27 Jul '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: More accurate wording for IntegerValidation ...................................................................... webadmin: More accurate wording for IntegerValidation The validation actually checks whether a number is lesser/greater than OR equals minimum/maximum limits. Change-Id: I553a53d40116c577cc97e43e3b6db2791bd0ab5e Bug-Url: https://bugzilla.redhat.com/1115062 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/30686 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I553a53d40116c577cc97e43e3b6db2791bd0ab5e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: Revert "reports: provide reports.xml to engine over http"
by ydary＠redhat.com 27 Jul '14

27 Jul '14

Yaniv Dary has submitted this change and it was merged. Change subject: Revert "reports: provide reports.xml to engine over http" ...................................................................... Revert "reports: provide reports.xml to engine over http" This reverts commit 1cef17b7217494e1a90a374d749ab09f651f86d6. Change-Id: I8736651ea01f72d3ae11de404ae81bef76924b27 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M ovirt-engine-reports.spec.in M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py 2 files changed, 2 insertions(+), 4 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30723 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8736651ea01f72d3ae11de404ae81bef76924b27 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: reports: provide reports.xml to engine over http
by ydary＠redhat.com 27 Jul '14

27 Jul '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: provide reports.xml to engine over http ...................................................................... reports: provide reports.xml to engine over http this is to support reports integration to webadmin on separate servers. Change-Id: Ia0230c58de2edfb3896b7af2e71ad27d47ee2229 Bug-Url: https://bugzilla.redhat.com/1116851 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M ovirt-engine-reports.spec.in M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29657 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0230c58de2edfb3896b7af2e71ad27d47ee2229 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: reports: do not provide default theme
by ydary＠redhat.com 27 Jul '14

27 Jul '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: do not provide default theme ...................................................................... reports: do not provide default theme This can cause upgrade issue from version to version in JRS. Change-Id: I82023e99e8efe402df41e80d52bc33ac012e80f7 Bug-Url: https://bugzilla.redhat.com/1112641 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/ovirt-reports/resources/themes/.folder.xml D packaging/ovirt-reports/resources/themes/default/.folder.xml D packaging/ovirt-reports/resources/themes/default/buttons.css.data D packaging/ovirt-reports/resources/themes/default/buttons.css.xml D packaging/ovirt-reports/resources/themes/default/containers.css.data D packaging/ovirt-reports/resources/themes/default/containers.css.xml D packaging/ovirt-reports/resources/themes/default/controls.css.data D packaging/ovirt-reports/resources/themes/default/controls.css.xml D packaging/ovirt-reports/resources/themes/default/dataDisplays.css.data D packaging/ovirt-reports/resources/themes/default/dataDisplays.css.xml D packaging/ovirt-reports/resources/themes/default/dialogSpecific.css.data D packaging/ovirt-reports/resources/themes/default/dialogSpecific.css.xml D packaging/ovirt-reports/resources/themes/default/forPrint.css.data D packaging/ovirt-reports/resources/themes/default/forPrint.css.xml D packaging/ovirt-reports/resources/themes/default/images/.folder.xml D packaging/ovirt-reports/resources/themes/default/images/adhoc_datatree_icons_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/adhoc_datatree_icons_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/adhoc_toolbar_buttons_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/adhoc_toolbar_buttons_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/banner_bkgd.png.data D packaging/ovirt-reports/resources/themes/default/images/banner_bkgd.png.xml D packaging/ovirt-reports/resources/themes/default/images/button_action_primary_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/button_action_primary_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/button_action_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/button_action_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/button_action_square_icons_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/button_action_square_icons_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/button_capsule_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/button_capsule_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/button_options_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/button_options_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/column_header_bkgd.png.data D packaging/ovirt-reports/resources/themes/default/images/column_header_bkgd.png.xml D packaging/ovirt-reports/resources/themes/default/images/cursor_copy.cur.data D packaging/ovirt-reports/resources/themes/default/images/cursor_copy.cur.xml D packaging/ovirt-reports/resources/themes/default/images/cursor_copy.png.data D packaging/ovirt-reports/resources/themes/default/images/cursor_copy.png.xml D packaging/ovirt-reports/resources/themes/default/images/disclosure_indicators_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/disclosure_indicators_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/floatingMenu_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/floatingMenu_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/grid_20x20_bkgd.png.data D packaging/ovirt-reports/resources/themes/default/images/grid_20x20_bkgd.png.xml D packaging/ovirt-reports/resources/themes/default/images/home_bkgd.png.data D packaging/ovirt-reports/resources/themes/default/images/home_bkgd.png.xml D packaging/ovirt-reports/resources/themes/default/images/home_icons_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/home_icons_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/inner_pagination_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/inner_pagination_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/input_bkgd.png.data D packaging/ovirt-reports/resources/themes/default/images/input_bkgd.png.xml D packaging/ovirt-reports/resources/themes/default/images/list_node_animation.gif.data D packaging/ovirt-reports/resources/themes/default/images/list_node_animation.gif.xml D packaging/ovirt-reports/resources/themes/default/images/list_pressed_bkgd.png.data D packaging/ovirt-reports/resources/themes/default/images/list_pressed_bkgd.png.xml D packaging/ovirt-reports/resources/themes/default/images/lists_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/lists_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/loadinfo.gif.data D packaging/ovirt-reports/resources/themes/default/images/loadinfo.gif.xml D packaging/ovirt-reports/resources/themes/default/images/login_welcome_bkgd.jpg.data D packaging/ovirt-reports/resources/themes/default/images/login_welcome_bkgd.jpg.xml D packaging/ovirt-reports/resources/themes/default/images/login_welcome_ce_bkgd.jpg.data D packaging/ovirt-reports/resources/themes/default/images/login_welcome_ce_bkgd.jpg.xml D packaging/ovirt-reports/resources/themes/default/images/logo.png.data D packaging/ovirt-reports/resources/themes/default/images/logo.png.xml D packaging/ovirt-reports/resources/themes/default/images/menu_primaryNav_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/menu_primaryNav_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/message_icons_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/message_icons_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/panel_inset_inset_bkgd.png.data D packaging/ovirt-reports/resources/themes/default/images/panel_inset_inset_bkgd.png.xml D packaging/ovirt-reports/resources/themes/default/images/panel_sizer_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/panel_sizer_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/report_load_animation.gif.data D packaging/ovirt-reports/resources/themes/default/images/report_load_animation.gif.xml D packaging/ovirt-reports/resources/themes/default/images/search_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/search_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/sort_indicators_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/sort_indicators_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/spacer.gif.data D packaging/ovirt-reports/resources/themes/default/images/spacer.gif.xml D packaging/ovirt-reports/resources/themes/default/images/tabs_horizontal_buttons_bkgd.png.data D packaging/ovirt-reports/resources/themes/default/images/tabs_horizontal_buttons_bkgd.png.xml D packaging/ovirt-reports/resources/themes/default/images/tabs_horizontal_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/tabs_horizontal_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/tabs_vertical_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/tabs_vertical_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/viewer_toolbar_buttons_sprite.png.data D packaging/ovirt-reports/resources/themes/default/images/viewer_toolbar_buttons_sprite.png.xml D packaging/ovirt-reports/resources/themes/default/images/wait_animation_large.gif.data D packaging/ovirt-reports/resources/themes/default/images/wait_animation_large.gif.xml D packaging/ovirt-reports/resources/themes/default/lists.css.data D packaging/ovirt-reports/resources/themes/default/lists.css.xml D packaging/ovirt-reports/resources/themes/default/overrides_custom.css.data D packaging/ovirt-reports/resources/themes/default/overrides_custom.css.xml D packaging/ovirt-reports/resources/themes/default/overrides_ie.css.data D packaging/ovirt-reports/resources/themes/default/overrides_ie.css.xml D packaging/ovirt-reports/resources/themes/default/overrides_ie7.css.data D packaging/ovirt-reports/resources/themes/default/overrides_ie7.css.xml D packaging/ovirt-reports/resources/themes/default/overrides_ie8.css.data D packaging/ovirt-reports/resources/themes/default/overrides_ie8.css.xml D packaging/ovirt-reports/resources/themes/default/pageSpecific.css.data D packaging/ovirt-reports/resources/themes/default/pageSpecific.css.xml D packaging/ovirt-reports/resources/themes/default/pages.css.data D packaging/ovirt-reports/resources/themes/default/pages.css.xml D packaging/ovirt-reports/resources/themes/default/samples.css.data D packaging/ovirt-reports/resources/themes/default/samples.css.xml D packaging/ovirt-reports/resources/themes/default/theme.css.data D packaging/ovirt-reports/resources/themes/default/theme.css.xml 109 files changed, 0 insertions(+), 12,854 deletions(-) Approvals: Shirly Radco: Looks good to me, but someone else must approve Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30711 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82023e99e8efe402df41e80d52bc33ac012e80f7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: update blank template origin type
by oourfali＠redhat.com 27 Jul '14

27 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: update blank template origin type ...................................................................... core: update blank template origin type currently the origin type for blank template is always RHEV there is a config in the db for the default origin type of vms so this patch uses this config to update blank template to the current configuration, should be OVIRT in most cases. Change-Id: Ib844899a61093c1c2b70a34adcddb0b9bca83b37 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1057211 --- A packaging/dbscripts/upgrade/03_05_0800_update_blank_template_origin_type.sql 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib844899a61093c1c2b70a34adcddb0b9bca83b37 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine : command infrastructure should know when the "execut...
by oourfali＠redhat.com 27 Jul '14

27 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine : command infrastructure should know when the "execute" phase finished ...................................................................... engine : command infrastructure should know when the "execute" phase finished When the engine is started after crashing/stopped while a command with async tasks is running, we should know after the restart whether the "Execution" phase of the command has ended or not, so that we'll know whether the command can be recovered or not. Change-Id: Ie36e7d8a0263d5dd90fabe914a76711d5c001e72 Bug-Url: https://bugzilla.redhat.com/1118249 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCache.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/TaskManagerUtil.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCRUDOperations.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandBaseTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/CommandEntity.java A backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/CommandExecutionStatus.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/CommandEntityDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/CommandEntityDaoDbFacadeImpl.java M packaging/dbscripts/command_entities_sp.sql A packaging/dbscripts/upgrade/03_05_0790_add_executed_to_command_entities.sql 14 files changed, 108 insertions(+), 17 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie36e7d8a0263d5dd90fabe914a76711d5c001e72 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine : Command Executor should persist command before subm...
by oourfali＠redhat.com 27 Jul '14

27 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine : Command Executor should persist command before submitting to threadpool ...................................................................... engine : Command Executor should persist command before submitting to threadpool Command Coordinator should persist command before submitting command to thread pool for execution. On server restarted the commands that have not started execution are failed Change-Id: I4d510836dc822a95198dc1db4a4f74206466f0c9 Bug-Url: https://bugzilla.redhat.com/1113256 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java 1 file changed, 79 insertions(+), 18 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30693 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d510836dc822a95198dc1db4a4f74206466f0c9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: fix race when removing memory volumes during Live Merge
by oourfali＠redhat.com 27 Jul '14

27 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: fix race when removing memory volumes during Live Merge ...................................................................... core: fix race when removing memory volumes during Live Merge Memory volume removal was not tracked as a child command, and its completion would trigger endAction of RemoveSnapshotCommand before the tasks run by ExecutionHandler were complete. Instead, use the newer RemoveMemoryVolumesCommand during Live Merge, which Executionhandler can coordinate. Change-Id: I12e317ada7159101cc5349e9a084b7f316493048 Bug-Url: https://bugzilla.redhat.com/1122691 Related-To: https://bugzilla.redhat.com/1083310 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMemoryVolumesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java 2 files changed, 17 insertions(+), 5 deletions(-) Approvals: Greg Padgett: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30608 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12e317ada7159101cc5349e9a084b7f316493048 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0