- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: extapi: use collection instead of list
by yzaslavs＠redhat.com 17 Jul '14

17 Jul '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: extapi: use collection instead of list ...................................................................... extapi: use collection instead of list primitive types are better, no real reason to use list in these. Topic: AAA Change-Id: I0555f7f10bae370c3605b5253cab09620ff770bb Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthn.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthn.java M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/Base.java M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Acct.java M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Authn.java M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Authz.java M backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java 8 files changed, 39 insertions(+), 37 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30236 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0555f7f10bae370c3605b5253cab09620ff770bb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Different realms for different URLs
by juan.hernandez＠redhat.com 17 Jul '14

17 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Different realms for different URLs ...................................................................... restapi: Different realms for different URLs Currently we deploy the RESTAPI application twice, once for the /api URL and another time for the /ovirt-engine/api URL. But both deployments use the same basic authentication realm. As a result when a browser authenticates with one URL it will be automatically authenticated with the other one, as the browser will remember the credentials and send them automatically if the realm is the same. To avoid this issue this patch changes the names of the realms, so that they will be different. Change-Id: I36140bf236b7043f3b813863ce8db635012a11ce Related: https://bugzilla.redhat.com/1077441 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Alexander Wels: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30222 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36140bf236b7043f3b813863ce8db635012a11ce Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: remove proprietary logger
by yzaslavs＠redhat.com 17 Jul '14

17 Jul '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: remove proprietary logger ...................................................................... aaa: remove proprietary logger Topic: AAA Change-Id: I3bbaeba654ecc1f585a285af2863dd53506f462b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/SessionValidationFilter.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30230 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3bbaeba654ecc1f585a285af2863dd53506f462b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: The labels should be displayed in lexo numeric order
by tnisan＠redhat.com 17 Jul '14

17 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: The labels should be displayed in lexo numeric order ...................................................................... webadmin: The labels should be displayed in lexo numeric order The edit interface(nic) label window, and the tool tip on the name of the nic in the sub tab network interfaces under hosts had to be fixed. Change-Id: If25a826a3123b43f87e51537a1988209dda31fa6 Bug-Url: https://bugzilla.redhat.com/1091674 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> (cherry picked from commit 7abd04b92dca83523372f35839ef139832b66e08) --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NicLabelModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfaceLabelWithToolTip.java 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30219 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If25a826a3123b43f87e51537a1988209dda31fa6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: enable hyperv optimization on windows
by tnisan＠redhat.com 17 Jul '14

17 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: enable hyperv optimization on windows ...................................................................... core: enable hyperv optimization on windows On VDSM side, we are catching-up with HyperV enligthenment support and recommended settings. Some of them are grouped under the 'hypervEnable' toggle and it is required to be explicitely enable for various reasons, the first one is they may be not completely transparent to not-windows guests. This patch automaticcaly enables these optimizations for windows guests. Change-Id: I01d50a539347211a6729cfb86922d60a6244d495 Bug-Url: https://bugzilla.redhat.com/1110305 Relates-To: https://bugzilla.redhat.com/1107835 Relates-To: https://bugzilla.redhat.com/1083529 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/OsRepositoryImplTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java M packaging/conf/osinfo-defaults.properties 6 files changed, 29 insertions(+), 0 deletions(-) Approvals: Francesco Romani: Verified Roy Golan: Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30188 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01d50a539347211a6729cfb86922d60a6244d495 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-guest-agent[ovirt-3.5]: Filter out duplicated network adapters on Windows
by vfeenstr＠redhat.com 17 Jul '14

17 Jul '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Filter out duplicated network adapters on Windows ...................................................................... Filter out duplicated network adapters on Windows Change-Id: I19d4b91ea4fb6fcec6699ab6892ba1d6240919f6 Bug-Url: https://bugzilla.redhat.com/1113089 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> (cherry picked from commit f531f482a2b2fa03ba7ec61449f5c3539a607a03) --- M ovirt-guest-agent/GuestAgentWin32.py 1 file changed, 18 insertions(+), 1 deletion(-) Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30224 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19d4b91ea4fb6fcec6699ab6892ba1d6240919f6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-guest-agent[master]: Filter out duplicated network adapters on Windows
by vfeenstr＠redhat.com 17 Jul '14

17 Jul '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Filter out duplicated network adapters on Windows ...................................................................... Filter out duplicated network adapters on Windows Change-Id: I19d4b91ea4fb6fcec6699ab6892ba1d6240919f6 Bug-Url: https://bugzilla.redhat.com/1113089 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/GuestAgentWin32.py 1 file changed, 18 insertions(+), 1 deletion(-) Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30095 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19d4b91ea4fb6fcec6699ab6892ba1d6240919f6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: The labels should be displayed in lexo numeric order
by alkaplan＠redhat.com 17 Jul '14

17 Jul '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: The labels should be displayed in lexo numeric order ...................................................................... webadmin: The labels should be displayed in lexo numeric order The edit interface(nic) label window, and the tool tip on the name of the nic in the sub tab network interfaces under hosts had to be fixed. Change-Id: If25a826a3123b43f87e51537a1988209dda31fa6 Bug-Url: https://bugzilla.redhat.com/1091674 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NicLabelModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfaceLabelWithToolTip.java 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30217 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If25a826a3123b43f87e51537a1988209dda31fa6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: tools: support for deprecating config values.
by masayag＠redhat.com 17 Jul '14

17 Jul '14

Moti Asayag has submitted this change and it was merged. Change subject: tools: support for deprecating config values. ...................................................................... tools: support for deprecating config values. - each config value can be deprecated via setting its property '.deprecated' to true. If not specified, deprecated=false is assumed. - when someone tries to set deprecated value, following message is printed: "ConfigKey <option_name> is deprecated. Please refer to product documentation." Change-Id: I636f7fe2530acfe00d8f0487001ddc781d1745a0 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/ConfigKey.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/ConfigKeyFactory.java 3 files changed, 38 insertions(+), 5 deletions(-) Approvals: Martin Mucha: Verified Moti Asayag: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29295 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I636f7fe2530acfe00d8f0487001ddc781d1745a0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Error code 23 when invoking Setup Networks
by alkaplan＠redhat.com 17 Jul '14

17 Jul '14

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Error code 23 when invoking Setup Networks ...................................................................... engine: Error code 23 when invoking Setup Networks In case the network is not in sync, it shouldn't override the interface's vlan id. Bug-Url: https://bugzilla.redhat.com/1115001 Change-Id: Iac0252076e8fa8704ed6c5257aeb5824d71470c5 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Alona Kaplan: Verified -- To view, visit http://gerrit.ovirt.org/30170 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac0252076e8fa8704ed6c5257aeb5824d71470c5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0