- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core: Added log when retrieving entities from tar
by tnisan＠redhat.com 17 Jul '14

17 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Added log when retrieving entities from tar ...................................................................... core: Added log when retrieving entities from tar Adding a log for the retrieve of entities process so it will be easier to understand the flow through the engine log file. Bug-Url: https://bugzilla.redhat.com/1119376 Change-Id: I11b1102b64c6951376a5242364435515b41d24fb Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OvfUtils.java 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/30206 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11b1102b64c6951376a5242364435515b41d24fb Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Use audit log only when failed to use retrieve command.
by tnisan＠redhat.com 17 Jul '14

17 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Use audit log only when failed to use retrieve command. ...................................................................... core: Use audit log only when failed to use retrieve command. Using a warning audit log only when the retrieve of OVF_STORE disks has been failed. When there are no OVF_STORE disks available we should only print a warnning log which indicates that there were no OVF_STORE in the storage domain. Bug-Url: https://bugzilla.redhat.com/1119376 Change-Id: I1eb5a687429c081f42bdc63bf3b8dd17eb295236 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java 1 file changed, 11 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/30205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1eb5a687429c081f42bdc63bf3b8dd17eb295236 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: jobs: ovirt-log-collector create rpms
by dcaroest＠redhat.com 17 Jul '14

17 Jul '14

David Caro has submitted this change and it was merged. Change subject: jobs: ovirt-log-collector create rpms ...................................................................... jobs: ovirt-log-collector create rpms Added jobs for creating rpms on master, 3.5 and 3.4 branches. Change-Id: I15d47beab5db38786bc9557473dff8c9454a68b1 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/yaml/jobs/kexec-tools/kexec-tools_create-rpms.yaml M jobs/confs/yaml/jobs/ovirt-hosted-engine-ha/ovirt-hosted-engine-ha_create-rpms.yaml A jobs/confs/yaml/jobs/ovirt-log-collector/ovirt-log-collector_create-rpms.yaml M jobs/confs/yaml/jobs/unboundid-ldapsdk/unboundid-ldapsdk_create-rpms.yaml M jobs/confs/yaml/jobs/vdsm-jsonrpc-java/vdsm-jsonrpc-java_create-rpms.yaml M jobs/confs/yaml/jobs/vdsm/vdsm_install-rpm-sanity.yaml A jobs/confs/yaml/scms/ovirt-log-collector.yaml M jobs/confs/yaml/templates/create-rpms_mock.yaml M jobs/confs/yaml/templates/install-rpm-sanity.yaml 9 files changed, 74 insertions(+), 23 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30087 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15d47beab5db38786bc9557473dff8c9454a68b1 Gerrit-PatchSet: 5 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Added log when retrieving entities from tar
by mlipchuk＠redhat.com 17 Jul '14

17 Jul '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Added log when retrieving entities from tar ...................................................................... core: Added log when retrieving entities from tar Adding a log for the retrieve of entities process so it will be easier to understand the flow through the engine log file. Change-Id: I11b1102b64c6951376a5242364435515b41d24fb Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OvfUtils.java 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30101 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11b1102b64c6951376a5242364435515b41d24fb Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Use audit log only when failed to use retrieve command.
by mlipchuk＠redhat.com 17 Jul '14

17 Jul '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use audit log only when failed to use retrieve command. ...................................................................... core: Use audit log only when failed to use retrieve command. Using a warning audit log only when the retrieve of OVF_STORE disks has been failed. When there are no OVF_STORE disks available we should only print a warnning log which indicates that there were no OVF_STORE in the storage domain. Change-Id: I1eb5a687429c081f42bdc63bf3b8dd17eb295236 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java 1 file changed, 11 insertions(+), 6 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/30061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1eb5a687429c081f42bdc63bf3b8dd17eb295236 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add tests for AddExistingFileStorageDomainCommand
by derez＠redhat.com 17 Jul '14

17 Jul '14

Daniel Erez has submitted this change and it was merged. Change subject: core: add tests for AddExistingFileStorageDomainCommand ...................................................................... core: add tests for AddExistingFileStorageDomainCommand Added a new unit tests class AddExistingFileStorageDomainCommandTest. Change-Id: Iae99fc564942fe8ff92f3e7e133d5c6c4d4bba49 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommandTest.java 2 files changed, 176 insertions(+), 10 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae99fc564942fe8ff92f3e7e133d5c6c4d4bba49 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: reactivate user
by yzaslavs＠redhat.com 17 Jul '14

17 Jul '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: reactivate user ...................................................................... aaa: reactivate user Reactive users in the following flow: 1. Login 2. AddUser 3. Periodic sync reactivate will occur with syncing the directory groups Change-Id: I556d8da48a858ce193865e84fb6c7cb4043a8e5b Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SyncUsers.java 4 files changed, 39 insertions(+), 9 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29974 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I556d8da48a858ce193865e84fb6c7cb4043a8e5b Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: change code of AddUser and AddGroup
by yzaslavs＠redhat.com 17 Jul '14

17 Jul '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: change code of AddUser and AddGroup ...................................................................... aaa: change code of AddUser and AddGroup removing the check from canDoAction to check if entity exists in directory as these checks are done both by rest-api and gui. Topic: AAA Change-Id: If841c8d30d6ab2c5d06b1637cde93cfc65598a96 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SyncUsers.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddGroupParameters.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddUserParameters.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbGroupDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAODbFacadeImpl.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendUsersResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendUsersResourceTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserListModel.java 13 files changed, 127 insertions(+), 190 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If841c8d30d6ab2c5d06b1637cde93cfc65598a96 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Remove payload logging
by juan.hernandez＠redhat.com 16 Jul '14

16 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Remove payload logging ...................................................................... restapi: Remove payload logging The infrastructure for payload logging is never used, and it is Resteasy dependent. This patch removes it. Change-Id: I1e845ce56e39936bae5a3bbb792b7a846345f979 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/BackendApplication.java D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/logging/LoggingInputStream.java D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/logging/LoggingOutputStream.java D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/logging/MessageLogger.java D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/logging/RequestPayloadLogger.java D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/logging/RequestVerbLogger.java D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/logging/ResponsePayloadLogger.java D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/logging/ResponseStatusLogger.java 8 files changed, 0 insertions(+), 323 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30103 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e845ce56e39936bae5a3bbb792b7a846345f979 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4.3]: packaging: ovirt-engine-3.4.3
by sbonazzo＠redhat.com 16 Jul '14

16 Jul '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: ovirt-engine-3.4.3 ...................................................................... packaging: ovirt-engine-3.4.3 Change-Id: Id7865a5d7ce1bb9acdc2475c05e9f3d53e02aba2 Bug-Url: https://bugzilla.redhat.com/1107968 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M backend/manager/dependencies/pom.xml M backend/manager/modules/authentication/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/jboss-modules-maven-plugin/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M ovirt-engine.spec.in M pom.xml M version.mak 45 files changed, 58 insertions(+), 52 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30187 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7865a5d7ce1bb9acdc2475c05e9f3d53e02aba2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0