- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal, webadmin: Changing "no sufficient" to "insuffici...
by gchaplik＠redhat.com 16 Jul '14

16 Jul '14

Gilad Chaplik has submitted this change and it was merged. Change subject: userportal, webadmin: Changing "no sufficient" to "insufficient" ...................................................................... userportal, webadmin: Changing "no sufficient" to "insufficient" Just better phrasing Change-Id: I1b39dec92244d13b46b8f5f87d9797ab71646e6b Bug-Url: https://bugzilla.redhat.com/1117349 Signed-off-by: Kobi Ianko <kobi(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 8 insertions(+), 8 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30140 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b39dec92244d13b46b8f5f87d9797ab71646e6b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-release[master]: add python-IPy
by sbonazzo＠redhat.com 16 Jul '14

16 Jul '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: add python-IPy ...................................................................... add python-IPy - add python-IPy from EPEL repository for ovirt-node. Change-Id: I6f6f733d3d6d6c25193b62503f1d3380ef865e04 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-release-3.5/configure.ac M ovirt-release-3.5/ovirt-el-deps.repo.in M ovirt-release-3.5/ovirt-release35.spec.in 3 files changed, 6 insertions(+), 3 deletions(-) Approvals: Fabian Deutsch: Looks good to me, but someone else must approve Sandro Bonazzola: Verified; Looks good to me, approved David Caro: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30161 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f6f733d3d6d6c25193b62503f1d3380ef865e04 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: Don't show fence_kdump listener in summary
by tnisan＠redhat.com 16 Jul '14

16 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: packaging: Don't show fence_kdump listener in summary ...................................................................... packaging: Don't show fence_kdump listener in summary Don't show "Configuring fence_kdump listener" message in summary of engine-setup, because listener is part of ovirt-engine setup (cannot be enabled/disabled by user). Change-Id: Ib31f1ff25ef406ccdf40e7ddcb4047984fef3ebd Bug-Url: https://bugzilla.redhat.com/1114040 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/fence_kdump_listener/config.py 2 files changed, 3 insertions(+), 40 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Peřina: Verified -- To view, visit http://gerrit.ovirt.org/30142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib31f1ff25ef406ccdf40e7ddcb4047984fef3ebd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Implement sorting for RxTxRateColumn
by lvernia＠redhat.com 16 Jul '14

16 Jul '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Implement sorting for RxTxRateColumn ...................................................................... webadmin: Implement sorting for RxTxRateColumn Implemented default client-side sorting for RxTxRateColumn, and switched it on for the Network/Hosts and Network/VMs subtab columns. Change-Id: Ia0a9b91350e774639a7879e26456f6e8cc15ba3d Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/RxTxRateRenderer.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/RxTxRateColumn.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkHostView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkVmView.java 4 files changed, 55 insertions(+), 3 deletions(-) Approvals: Alexander Wels: Looks good to me, but someone else must approve Vojtech Szocs: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/28757 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0a9b91350e774639a7879e26456f6e8cc15ba3d Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add VdcQueryType test
by tnisan＠redhat.com 16 Jul '14

16 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Add VdcQueryType test ...................................................................... core: Add VdcQueryType test Added a tests validates that every query type in VdcQueryType corresponds to an existing query class Change-Id: I4cf3e10f2dfd2b132283d2408c1079e37a9789df Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/QueryExistenceTest.java 1 file changed, 26 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29794 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4cf3e10f2dfd2b132283d2408c1079e37a9789df Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add VdcActionType tests
by tnisan＠redhat.com 16 Jul '14

16 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Add VdcActionType tests ...................................................................... core: Add VdcActionType tests Added tests to: - Validate that every command values is unique - Validate that every command type in VdcActionType corresponds to an existing command class Change-Id: I53b51b359e14e2f1ebb6e518846f1cf00c8bbe6b Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VdcActionTypeTest.java 1 file changed, 46 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29779 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53b51b359e14e2f1ebb6e518846f1cf00c8bbe6b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove unused query types in VdcQueryType
by tnisan＠redhat.com 16 Jul '14

16 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove unused query types in VdcQueryType ...................................................................... core: Remove unused query types in VdcQueryType Removed query types that does not correspond with an existing query class in VdcQueryType as they are useless Change-Id: Ibffaf330c738e01680edf21b5ecd099e9be173a0 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29793 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibffaf330c738e01680edf21b5ecd099e9be173a0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove static member initialization from a config value
by tnisan＠redhat.com 16 Jul '14

16 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove static member initialization from a config value ...................................................................... core: Remove static member initialization from a config value Removed static member initialization from a config value in InitVdsOnUpCommand, initialization of static member from config, database and such prevent the possibility to initialize a class instance without mocking the corresponding environments and is considered bad practice Change-Id: Ifb76820c331ef0e4f5cd53b5c12c52989e50c4dc Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java 1 file changed, 10 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved Omer Frenkel: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb76820c331ef0e4f5cd53b5c12c52989e50c4dc Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove unused action types in VdcActionType
by tnisan＠redhat.com 16 Jul '14

16 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove unused action types in VdcActionType ...................................................................... core: Remove unused action types in VdcActionType Removed action types that does not correspond with an existing command class in VdcActionType as they are useless Change-Id: Ic0e7d92edb85a0fb1f8994cf5d46a28dae97b5da Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29777 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0e7d92edb85a0fb1f8994cf5d46a28dae97b5da Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Change duplicate action type values to unique ones
by tnisan＠redhat.com 16 Jul '14

16 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Change duplicate action type values to unique ones ...................................................................... core: Change duplicate action type values to unique ones Since the action type value is supposed to be unique, a test will be added to enforce uniqueness of the action type values prior to that, since we have duplicate values in the VdcActionType class we have to change first the duplicate values to different values to ensure uniqueness Change-Id: I6de787be50f8ef0149805bd0292ece2ab81aa465 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29776 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6de787be50f8ef0149805bd0292ece2ab81aa465 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0