- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Render Providers main tab columns sortable
by tnisan＠redhat.com 16 Jul '14

16 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Render Providers main tab columns sortable ...................................................................... webadmin: Render Providers main tab columns sortable Rendered columns sortable via server-side sorting. Change-Id: I5843296ec00aebc3bca8e90a39dff3d2ad6541a4 Bug-Url: https://bugzilla.redhat.com/1120054 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabProviderView.java 2 files changed, 12 insertions(+), 1 deletion(-) Approvals: Alexander Wels: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/30151 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5843296ec00aebc3bca8e90a39dff3d2ad6541a4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Render Networks main tab columns sortable
by tnisan＠redhat.com 16 Jul '14

16 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Render Networks main tab columns sortable ...................................................................... webadmin: Render Networks main tab columns sortable Rendered all columns sortable except for: * Comment isn't helpful when it's displayed as icon. * Role and Provider, don't currently support server-side sorting. Change-Id: I440ad9be062547cdf4b1bad68d8f4d62072b5bef Bug-Url: https://bugzilla.redhat.com/1120054 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/NetworkConditionFieldAutoCompleter.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabNetworkView.java 3 files changed, 22 insertions(+), 10 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/30150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I440ad9be062547cdf4b1bad68d8f4d62072b5bef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Implement permission sorting by role icon
by tnisan＠redhat.com 16 Jul '14

16 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Implement permission sorting by role icon ...................................................................... webadmin: Implement permission sorting by role icon Implemented sorting for permission subtabs according to the role icon (ordinary user is lesser than administrator). Change-Id: I3a2c97315bda060e44b662562e1e08652881d72f Bug-Url: https://bugzilla.redhat.com/1120054 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/PermissionTypeColumn.java 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/30149 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a2c97315bda060e44b662562e1e08652881d72f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Implement default sort order for CheckboxColumn
by tnisan＠redhat.com 16 Jul '14

16 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Implement default sort order for CheckboxColumn ...................................................................... webadmin: Implement default sort order for CheckboxColumn Similarly to what was done with TextColumnWithTooltip, it makes sense to implement some default sorting behavior for CheckboxColumn. Change-Id: I7c70dd4c052ba21660f16ae223eb00ccf5d5edba Bug-Url: https://bugzilla.redhat.com/1120054 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/CheckboxColumn.java 1 file changed, 22 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/30148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c70dd4c052ba21660f16ae223eb00ccf5d5edba Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Standard exception mappers
by juan.hernandez＠redhat.com 16 Jul '14

16 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Standard exception mappers ...................................................................... restapi: Standard exception mappers Currently we use Resteasy specific code in the exception mappers. This patch removes this code, as is now unnecessary. Change-Id: If033d3370f705149747d37ebfb76d053044823c4 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/BackendApplication.java D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/JaxbExceptionMapper.java D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/JaxbMarshallExceptionMapper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/JsonExceptionMapper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/MalformedIdExceptionMapper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/MappingExceptionMapper.java 6 files changed, 48 insertions(+), 84 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Martin Mucha: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30102 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If033d3370f705149747d37ebfb76d053044823c4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: added matching constructor for SshSoftFencingCommand
by tnisan＠redhat.com 16 Jul '14

16 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: added matching constructor for SshSoftFencingCommand ...................................................................... core: added matching constructor for SshSoftFencingCommand Change-Id: Ibfa993bfb2928bbd5b73176c3a0e3835f420d68c Bug-Url: https://bugzilla.redhat.com/1119753 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshSoftFencingCommand.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Verified -- To view, visit http://gerrit.ovirt.org/30169 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibfa993bfb2928bbd5b73176c3a0e3835f420d68c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: added matching constructor for SshSoftFencingCommand
by oourfali＠redhat.com 16 Jul '14

16 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: added matching constructor for SshSoftFencingCommand ...................................................................... core: added matching constructor for SshSoftFencingCommand Change-Id: Ibfa993bfb2928bbd5b73176c3a0e3835f420d68c Bug-Url: https://bugzilla.redhat.com/1119753 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshSoftFencingCommand.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Verified -- To view, visit http://gerrit.ovirt.org/30168 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibfa993bfb2928bbd5b73176c3a0e3835f420d68c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: sysprep MachineObjectOU fix closing xml tag
by shavivi＠redhat.com 16 Jul '14

16 Jul '14

Shahar Havivi has submitted this change and it was merged. Change subject: engine: sysprep MachineObjectOU fix closing xml tag ...................................................................... engine: sysprep MachineObjectOU fix closing xml tag Change-Id: I76c14e104db8890ef1973dec9d64a3def30e1204 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M packaging/conf/sysprep/sysprep.2k12x64 M packaging/conf/sysprep/sysprep.2k8 M packaging/conf/sysprep/sysprep.2k8x64 M packaging/conf/sysprep/sysprep.w7 M packaging/conf/sysprep/sysprep.w7x64 M packaging/conf/sysprep/sysprep.w8 M packaging/conf/sysprep/sysprep.w8x64 7 files changed, 7 insertions(+), 7 deletions(-) Approvals: Shahar Havivi: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30143 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76c14e104db8890ef1973dec9d64a3def30e1204 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-iso-uploader[ovirt-iso-uploader-3.4]: build: post ovirt-iso-uploader-3.4.3
by sbonazzo＠redhat.com 16 Jul '14

16 Jul '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: post ovirt-iso-uploader-3.4.3 ...................................................................... build: post ovirt-iso-uploader-3.4.3 Change-Id: Iaca1556efd4f2c1f1651131fd13ac2ecc18e94ad Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-iso-uploader.spec.in 2 files changed, 7 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30164 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaca1556efd4f2c1f1651131fd13ac2ecc18e94ad Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: ovirt-iso-uploader-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-iso-uploader[ovirt-iso-uploader-3.4]: build: ovirt-iso-uploader-3.4.3
by sbonazzo＠redhat.com 16 Jul '14

16 Jul '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-iso-uploader-3.4.3 ...................................................................... build: ovirt-iso-uploader-3.4.3 Change-Id: I222f147148e123226add56926b7ce3a40357e87f Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-iso-uploader.spec.in 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30163 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I222f147148e123226add56926b7ce3a40357e87f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: ovirt-iso-uploader-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0