- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: ovs renames
by Code Review 25 Apr '17

25 Apr '17

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: ovs renames ...................................................................... webadmin: ovs renames Switch type(Experimental!) —> Switch type LEGACY —> Linux Bridge OVS —> OVS (experimental) Change-Id: Ieb8878d9e061bae8e95a44acd4030d77e1ce9f6e Bug-Url: https://bugzilla.redhat.com/1438298 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties 3 files changed, 8 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75956 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb8878d9e061bae8e95a44acd4030d77e1ce9f6e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: missing default route icon
by Code Review 25 Apr '17

25 Apr '17

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: missing default route icon ...................................................................... webadmin: missing default route icon Change-Id: Icbfe212a8c151e444d8ff6c35ceebdf83aad5060 Bug-Url: https://bugzilla.redhat.com/1434731 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java 1 file changed, 18 insertions(+), 10 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Looks good to me, but someone else must approve Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76015 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbfe212a8c151e444d8ff6c35ceebdf83aad5060 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: produceReport: Add pre-upgrade validation
by Code Review 25 Apr '17

25 Apr '17

>From Lev Veyde <lveyde(a)redhat.com>: Lev Veyde has submitted this change and it was merged. Change subject: produceReport: Add pre-upgrade validation ...................................................................... produceReport: Add pre-upgrade validation This patch add a new session to report called Pre-upgrade, which will do SQL commands to validate users database for upgrade scenario. In this initial commit, we added the skill to check hosts health. Finally, we also split the sql commands and bash script for plainness. Change-Id: I5d59a7e7fc896a4a59e08fee1d637d0289e2d2ce Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport.sh A src/inventory_report/sqls/cleanup.sql A src/inventory_report/sqls/hosts_create_related_lookup_tables.sql A src/inventory_report/sqls/hosts_query_check_health.sql 4 files changed, 98 insertions(+), 29 deletions(-) Approvals: Lev Veyde: Looks good to me, approved Douglas Schilling Landgraf: Verified Sandro Bonazzola: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/75323 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d59a7e7fc896a4a59e08fee1d637d0289e2d2ce Gerrit-PatchSet: 7 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.1]: build: ovirt-live-4.1.2 tc1
by Code Review 25 Apr '17

25 Apr '17

>From Lev Veyde <lveyde(a)redhat.com>: Lev Veyde has submitted this change and it was merged. Change subject: build: ovirt-live-4.1.2 tc1 ...................................................................... build: ovirt-live-4.1.2 tc1 Change-Id: Id0bb04d4301b1995968046bbbc3af249cf7fa464 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M centos-7/Makefile M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Lev Veyde: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/75992 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0bb04d4301b1995968046bbbc3af249cf7fa464 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.1 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix NPE on floating disk creation through REST
by Code Review 25 Apr '17

25 Apr '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Fix NPE on floating disk creation through REST ...................................................................... core: Fix NPE on floating disk creation through REST Commit d9a7c1c moved the read only property of a disk from the disk entity to the relation between a disk and a VM where it belongs, since the property was moved, validating whether a read only property is compatible should be done only in case of adding a disk that is connected to a VM. Change-Id: I5257e7ab9c048b31d134a0f09fbeceed7d596061 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommand.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Benny Zlotnik: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75987 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5257e7ab9c048b31d134a0f09fbeceed7d596061 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: he: Implemented monitoring loop steps management
by Code Review 25 Apr '17

25 Apr '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: he: Implemented monitoring loop steps management ...................................................................... he: Implemented monitoring loop steps management Monitoring loops execution could be slow and we may skip some steps in case when previous delay was zero. Change-Id: I9f3d70b8f4f6aed66ebbfa9e2f41a74811c15b9e Signed-off-by: Denis Chaplygin <dchaplyg(a)redhat.com> Bug-Url:https://bugzilla.redhat.com/1399766 --- M ovirt_hosted_engine_ha/agent/hosted_engine.py 1 file changed, 11 insertions(+), 6 deletions(-) Approvals: Denis Chaplygin: Verified Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75685 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f3d70b8f4f6aed66ebbfa9e2f41a74811c15b9e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: he: Implemented dynamic delay of monitoring loop
by Code Review 25 Apr '17

25 Apr '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: he: Implemented dynamic delay of monitoring loop ...................................................................... he: Implemented dynamic delay of monitoring loop Monitoring loop should be exexcuted every 10 seconds or more. Right now execution of loops takes more than 10 seconds, so for longer execution times protective delay could be decreased or removed at all. Change-Id: I84a19e0730a2017b9b83129dcee04e6fc90b97b3 Signed-off-by: Denis Chaplygin <dchaplyg(a)redhat.com> Bug-Url:https://bugzilla.redhat.com/1399766 --- M ovirt_hosted_engine_ha/agent/hosted_engine.py 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Denis Chaplygin: Verified Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75684 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84a19e0730a2017b9b83129dcee04e6fc90b97b3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: VdsmVm type inference
by Code Review 25 Apr '17

25 Apr '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: VdsmVm type inference ...................................................................... core: VdsmVm type inference Change-Id: I6756f6fc212c4ee9e260f26082aebb0889651bb5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VdsmVm.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/75961 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6756f6fc212c4ee9e260f26082aebb0889651bb5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: setup: Fail the setup if VMs CCV is lower then DC
by Code Review 25 Apr '17

25 Apr '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: setup: Fail the setup if VMs CCV is lower then DC ...................................................................... setup: Fail the setup if VMs CCV is lower then DC we want to notify the user if the customcompatibility version (CCV) is lower then the data center (DC). Change-Id: If24bfa9f7f8bf265b4f88ab4f51c61371508f4d5 Bug-Url: https://bugzilla.redhat.com/1436577 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/schema.py 1 file changed, 54 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75859 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If24bfa9f7f8bf265b4f88ab4f51c61371508f4d5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: add vm exit reason of type unknown
by Code Review 25 Apr '17

25 Apr '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: add vm exit reason of type unknown ...................................................................... core: add vm exit reason of type unknown When restoring a backup, the status and run_on_vds fields of the VM do not represent the actual information of the running VM. This may lead of unneeded restart of highly-available VMs that would cause a split-brain. Therefore, we decide to switch highly-available VMs to down when restoring a backup. But none of the existing exit reasons fit for this flow: Error would cause the VM to be restarted when the engine starts, and Normal doesn't reflect the situation properly since the VM was not shut-down properly. Thus, we add a new exit reason for this case, called Unknown. The whole purpose of this value, for now, is to prevent the automatic VM restart mechanism to skip VMs set with this value. Change-Id: I40710a943c60dbdbbdf9e8e9563afc121d1d632a Bug-Url: https://bugzilla.redhat.com/1441322 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmExitStatus.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/75904 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40710a943c60dbdbbdf9e8e9563afc121d1d632a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0