- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: dal: Fix vm_device data population - custom_properties
by Code Review 26 Apr '17

26 Apr '17

>From Roy Golan <rgolan(a)redhat.com>: Roy Golan has submitted this change and it was merged. Change subject: dal: Fix vm_device data population - custom_properties ...................................................................... dal: Fix vm_device data population - custom_properties Mistakenly custom_properties in vm_device was set to a uuid - that would fail deserializing vm_device custom properties Change-Id: I23aa02117d03b2455e12d9c8dd74323d8a7a5440 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M packaging/dbscripts/data/01200_insert_vm_device.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Roy Golan: Verified -- To view, visit https://gerrit.ovirt.org/76080 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I23aa02117d03b2455e12d9c8dd74323d8a7a5440 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine:BackendSnapshotsResource#mapDisks
by Code Review 26 Apr '17

26 Apr '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: engine:BackendSnapshotsResource#mapDisks ...................................................................... engine:BackendSnapshotsResource#mapDisks Changed the 'for each' loop into a stream. Change-Id: I733f2e00abef2c77dd77cfc194ec1b6a75cccc44 Signed-off-by: Shani Leviim <sleviim(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotsResource.java 1 file changed, 11 insertions(+), 11 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Shani Leviim: Verified -- To view, visit https://gerrit.ovirt.org/76059 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I733f2e00abef2c77dd77cfc194ec1b6a75cccc44 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shani Leviim <sleviim(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Shani Leviim <sleviim(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: Corrected validation for geo-rep
by Code Review 26 Apr '17

26 Apr '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Corrected validation for geo-rep ...................................................................... webadmin: Corrected validation for geo-rep AsciiName validation is not required for volume as this is a volume entity selection Change-Id: I640936d741456bc13977946272a0c3afddf6ced6 Bug-Url: https://bugzilla.redhat.com/1440071 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeGeoRepCreateModel.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Denis Chaplygin: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Sahina Bose: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/75687 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I640936d741456bc13977946272a0c3afddf6ced6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: engine-backup: Allow setting temp dir
by Code Review 26 Apr '17

26 Apr '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: Allow setting temp dir ...................................................................... packaging: engine-backup: Allow setting temp dir Add an option --tmpdir=DIR to set the parent of the temporary directory that's created. Defaults to $TMPDIR if set, otherwise to /tmp. Change-Id: I13f07418329fd6347e3ec86f52438db220da393f Bug-Url: https://bugzilla.redhat.com/1439332 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh.in M packaging/man/man8/engine-backup.8 2 files changed, 20 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/75589 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13f07418329fd6347e3ec86f52438db220da393f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Use type inference in StorageDRListModel
by Code Review 25 Apr '17

25 Apr '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Use type inference in StorageDRListModel ...................................................................... webadmin: Use type inference in StorageDRListModel Change-Id: I196b75ff7438007d5f91eab5ea51ae81d64d034e Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDRListModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76008 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I196b75ff7438007d5f91eab5ea51ae81d64d034e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Remove redundant methods in StorageDRListModel
by Code Review 25 Apr '17

25 Apr '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Remove redundant methods in StorageDRListModel ...................................................................... webadmin: Remove redundant methods in StorageDRListModel Change-Id: I1273f6dc2c3d92432505d8ed983515626d3bb7a4 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDRListModel.java 1 file changed, 0 insertions(+), 16 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76007 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1273f6dc2c3d92432505d8ed983515626d3bb7a4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: ovs renames
by Code Review 25 Apr '17

25 Apr '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: ovs renames ...................................................................... webadmin: ovs renames Switch type(Experimental!) —> Switch type LEGACY —> Linux Bridge OVS —> OVS (experimental) Change-Id: Ieb8878d9e061bae8e95a44acd4030d77e1ce9f6e Bug-Url: https://bugzilla.redhat.com/1438298 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties 3 files changed, 8 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75957 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb8878d9e061bae8e95a44acd4030d77e1ce9f6e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.1]: fix CentOS repos
by Code Review 25 Apr '17

25 Apr '17

>From Lev Veyde <lveyde(a)redhat.com>: Lev Veyde has submitted this change and it was merged. Change subject: fix CentOS repos ...................................................................... fix CentOS repos Change-Id: I6b4d0770a2493e958004d456c749a61d899c455d Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Lev Veyde: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/76029 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b4d0770a2493e958004d456c749a61d899c455d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.1 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: enable concurent runs for manual system jobs
by Code Review 25 Apr '17

25 Apr '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: enable concurent runs for manual system jobs ...................................................................... enable concurent runs for manual system jobs jira: https://ovirt-jira.atlassian.net/browse/OVIRT-1316 Change-Id: I862e676a48100d20eb0412db31b9b50fe8888b59 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt/system-tests.yaml 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Eyal Edri: Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests Daniel Belenky: Verified -- To view, visit https://gerrit.ovirt.org/75691 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I862e676a48100d20eb0412db31b9b50fe8888b59 Gerrit-PatchSet: 6 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix spec_params value in vm_device
by Code Review 25 Apr '17

25 Apr '17

>From Eli Mesika <emesika(a)redhat.com>: Eli Mesika has submitted this change and it was merged. Change subject: core: fix spec_params value in vm_device ...................................................................... core: fix spec_params value in vm_device The squashing 03_06 patch replaced by mistake the following column values: initrd_url column in vm_static table in file 01100_insert_vm_static.sql spec_params column in vm_device table in file 01200_insert_vm_device.sql description column in policy_units table in file 00340_insert_policy_units.sql with UUID while in original it was empty. As a result an exception is thrown in engine when trying to create a map from this value for spec_params or the value is incorrect in the other cases. This patch fixes that issue. Change-Id: I281b8953401a9b8e71ee08031af9c9756fc72b32 Signed-off-by: emesika <emesika(a)redhat.com> --- M packaging/dbscripts/data/00340_insert_policy_units.sql M packaging/dbscripts/data/01100_insert_vm_static.sql M packaging/dbscripts/data/01200_insert_vm_device.sql 3 files changed, 17 insertions(+), 17 deletions(-) Approvals: Eli Mesika: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Andrej Krejcir: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/76013 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I281b8953401a9b8e71ee08031af9c9756fc72b32 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0