- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Use force detach only on Data SD
by mlipchuk＠redhat.com 01 Jul '14

01 Jul '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use force detach only on Data SD ...................................................................... core: Use force detach only on Data SD Use force detach on data storage domain instead on every domain which is not Export, so force detach of ISO domain will be prevented. Change-Id: I5784956d566d815b4471382b004879735ab016d2 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/29403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5784956d566d815b4471382b004879735ab016d2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: no need to save vm_static on run once
by oourfali＠redhat.com 01 Jul '14

01 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine: no need to save vm_static on run once ...................................................................... engine: no need to save vm_static on run once Change-Id: Idb5c0da8b0257a7751255665f4160391a1e3b2a5 Bug-Url: https://bugzilla.redhat.com/1108676 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Shahar Havivi: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29416 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb5c0da8b0257a7751255665f4160391a1e3b2a5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: no need to save vm_static on run once
by shavivi＠redhat.com 01 Jul '14

01 Jul '14

Shahar Havivi has submitted this change and it was merged. Change subject: engine: no need to save vm_static on run once ...................................................................... engine: no need to save vm_static on run once Change-Id: Idb5c0da8b0257a7751255665f4160391a1e3b2a5 Bug-Url: https://bugzilla.redhat.com/1108676 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29417 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb5c0da8b0257a7751255665f4160391a1e3b2a5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: remove Escape characters for TextBoxLabel
by shavivi＠redhat.com 01 Jul '14

01 Jul '14

Shahar Havivi has submitted this change and it was merged. Change subject: ui: remove Escape characters for TextBoxLabel ...................................................................... ui: remove Escape characters for TextBoxLabel The reason that we use: SafeHtmlUtils.htmlEscape(renderedText); is to prevent javascript code injection such as <script> etc. Its looks like the control is already safe rendering (tested with <script>, <b> and <h1>). without removing this line its render <>,. as theyer escaped value. Change-Id: I2e303decb9395fcf193e874b4ae55ab076ec0bba Bug-Url: https://bugzilla.redhat.com/1113499 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/TextBoxLabel.java 1 file changed, 2 insertions(+), 11 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified; Looks good to me, approved Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29292 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e303decb9395fcf193e874b4ae55ab076ec0bba Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: handle fence agent power wait param on stop
by oourfali＠redhat.com 01 Jul '14

01 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: handle fence agent power wait param on stop ...................................................................... core: handle fence agent power wait param on stop When a host restart is dome manually or as a result of a non-responsive host treatment and in the case that power wait parameter is used the host may stay in 'off' state and even release its lock on HA VMs before the host is really down This is the scenario: 1) A restart command is issued and actually performed as stop -> wait for 'off' status -> start -> wait for 'on' status 2) power wait parameter is added to the command implicitly or explicitly giving a delay of X seconds before the operation is actually performed 3) The fence agent script returns immediately with 'off' status 4) A 'on' command is sent to the fence agent by the start operation 5) X seconds passed and the host is actually shutdown This patch handles this by adding a new configuration value that maps fence agents to the name of the parameter for power wait Upon stop operation, we will wait a fixed delay (5 seconds hard-coded) before starting to sample the host status, if power wait parameter is used, the value is extracted and we will wait for 5 + X seconds. Change-Id: I310e076ecf84988cacd0b179954d2460d7988b91 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1114618 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/pm/VdsFenceOptions.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 4 files changed, 69 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I310e076ecf84988cacd0b179954d2460d7988b91 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: improve hot plug cpu wording
by rgolan＠redhat.com 01 Jul '14

01 Jul '14

Roy Golan has submitted this change and it was merged. Change subject: ui: improve hot plug cpu wording ...................................................................... ui: improve hot plug cpu wording Change-Id: I8013172ee5410330bad4bfc8f5560ed1eef7988a Bug-Url: https://bugzilla.redhat.com/1093997 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29411 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8013172ee5410330bad4bfc8f5560ed1eef7988a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Rename providerId to networkProviderId in add/update...
by masayag＠redhat.com 01 Jul '14

01 Jul '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Rename providerId to networkProviderId in add/update host actions ...................................................................... engine: Rename providerId to networkProviderId in add/update host actions The property is renamed due to a new provider which was added with the same name for the sake of Foreman integration. In addition, type was added to provider to clear few eclipse warnings. Change-Id: I9cdaddbfd41223b9eb32b52ebfb9333709c0440d Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdsOperationActionParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 5 files changed, 18 insertions(+), 18 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29410 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9cdaddbfd41223b9eb32b52ebfb9333709c0440d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in otopi[master]: packaging: spec: fix latest jbeap junit mess
by Alon Bar-Lev 01 Jul '14

01 Jul '14

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: spec: fix latest jbeap junit mess ...................................................................... packaging: spec: fix latest jbeap junit mess """ Package jakarta-commons-logging is obsoleted by apache-commons-logging, trying to install apache-commons-logging-1.1.1-8_redhat_2.ep6.el6.noarch instead """ but they did not kept the same name for build-classpath! Change-Id: Ib83adec3648ececb196e2d3b35382c989c88a5a8 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M otopi.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29435 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib83adec3648ececb196e2d3b35382c989c88a5a8 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Configure unique host name on neutron.conf
by mkolesni＠redhat.com 01 Jul '14

01 Jul '14

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Configure unique host name on neutron.conf ...................................................................... engine: Configure unique host name on neutron.conf The agent name should be determined by the engine to support its association with the ml2 port bindings. The "host" property within the neutron.conf is used to identify the agent on the neutron node, when the agent communicates with the neutron node. When a port is being allocated on the neutron node, the engine should provide also the agent the port is intended to be run on. The agent is identified by that "host" property. By identifying the agent, the ml2 driver resolves the plugin type (openvswitch, linuxbridge or any other supported plugin). So the engine should be able to define a unique host name for each agent, first for the agent which reports its name to the neutron node, and later-on when ports are allocated on each agent. Since the host name is unique, and could be changed only by re-installing the host, it makes sense to use it as the agent name. Change-Id: I18db7cce8769b23b1fafcf5ac31ebdb7556a7cec Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java 2 files changed, 17 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/28791 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18db7cce8769b23b1fafcf5ac31ebdb7556a7cec Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: extapi: aaa: add auth result to credential change
by yzaslavs＠redhat.com 30 Jun '14

30 Jun '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: extapi: aaa: add auth result to credential change ...................................................................... extapi: aaa: add auth result to credential change usable for provides that can support that. Change-Id: Ib2c360414aad8e9b68174cbc0aa03b4633b6fc7f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Authn.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29432 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2c360414aad8e9b68174cbc0aa03b4633b6fc7f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0