- Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk[sdk_3.5]: codegen: Naming exception for scheduling policy
by juan.hernandez＠redhat.com 01 Jul '14

01 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Naming exception for scheduling policy ...................................................................... codegen: Naming exception for scheduling policy The plural of the new SchedulingPolicy entity has to be managed as an exception to the rule that plurals are formed adding an "s" to the singular. Change-Id: Iac4e9b0b47314ce062bf87718360209bd55960f4 Bug-Url: https://bugzilla.redhat.com/1114655 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 45aa45eef0481a75cf82e024c33adb9dc73b6343) --- M src/codegen/rsdl/rsdlcodegen.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29459 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac4e9b0b47314ce062bf87718360209bd55960f4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[sdk_3.5]: codegen: Support plural exceptions
by juan.hernandez＠redhat.com 01 Jul '14

01 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Support plural exceptions ...................................................................... codegen: Support plural exceptions Currently we have a set of entity names whose corresponding collection name isn't formed by just adding an "s" to the end: the name of the entity and the collection is the same. But we will soon introduce some entities where the name of the collection can't be derived in this simple way, in particular we will introduce the SchedulingPolicy entity and the SchedulingPolicies collection. To support that, this patch changes the list of collections to a map, so that the name of the entity and the name of the collection can be different. Change-Id: I97d45d533e12723426f98dad2874de3945fd483b Related: https://bugzilla.redhat.com/1114655 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit e9d510434a94b19435440e7b0769f96c5a4d0f0c) --- M src/codegen/rsdl/rsdlcodegen.py M src/codegen/utils/stringutils.py 2 files changed, 20 insertions(+), 11 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29458 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97d45d533e12723426f98dad2874de3945fd483b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: codegen: Naming exception for scheduling policy
by juan.hernandez＠redhat.com 01 Jul '14

01 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Naming exception for scheduling policy ...................................................................... codegen: Naming exception for scheduling policy The plural of the new SchedulingPolicy entity has to be managed as an exception to the rule that plurals are formed adding an "s" to the singular. Change-Id: Iac4e9b0b47314ce062bf87718360209bd55960f4 Bug-Url: https://bugzilla.redhat.com/1114655 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/codegen/rsdl/rsdlcodegen.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Daniel Erez: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29419 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac4e9b0b47314ce062bf87718360209bd55960f4 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: codegen: Support plural exceptions
by juan.hernandez＠redhat.com 01 Jul '14

01 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Support plural exceptions ...................................................................... codegen: Support plural exceptions Currently we have a set of entity names whose corresponding collection name isn't formed by just adding an "s" to the end: the name of the entity and the collection is the same. But we will soon introduce some entities where the name of the collection can't be derived in this simple way, in particular we will introduce the SchedulingPolicy entity and the SchedulingPolicies collection. To support that, this patch changes the list of collections to a map, so that the name of the entity and the name of the collection can be different. Change-Id: I97d45d533e12723426f98dad2874de3945fd483b Related: https://bugzilla.redhat.com/1114655 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/codegen/rsdl/rsdlcodegen.py M src/codegen/utils/stringutils.py 2 files changed, 20 insertions(+), 11 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29418 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97d45d533e12723426f98dad2874de3945fd483b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-guest-agent[ovirt-3.5]: Corrections to the build system for el5
by vfeenstr＠redhat.com 01 Jul '14

01 Jul '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Corrections to the build system for el5 ...................................................................... Corrections to the build system for el5 Change-Id: I401b4b0ff68abaf492ab31379c79a18c588cfa00 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/Makefile.am M ovirt-guest-agent/Makefile.el5 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Martin Betak: Looks good to me, but someone else must approve Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29451 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I401b4b0ff68abaf492ab31379c79a18c588cfa00 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-guest-agent[master]: Corrections to the build system for el5
by vfeenstr＠redhat.com 01 Jul '14

01 Jul '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Corrections to the build system for el5 ...................................................................... Corrections to the build system for el5 Change-Id: I401b4b0ff68abaf492ab31379c79a18c588cfa00 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/Makefile.am M ovirt-guest-agent/Makefile.el5 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Martin Betak: Looks good to me, but someone else must approve Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I401b4b0ff68abaf492ab31379c79a18c588cfa00 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-guest-agent[master]: Bump to 1.0.10 for ovirt-3.5
by vfeenstr＠redhat.com 01 Jul '14

01 Jul '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Bump to 1.0.10 for ovirt-3.5 ...................................................................... Bump to 1.0.10 for ovirt-3.5 Change-Id: Ife1c6f7db53228d0e40242d620f9e40ff2344439 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ChangeLog M configure.ac M debian/changelog M debian/copyright M ovirt-guest-agent.rhel6.spec M ovirt-guest-agent.spec 6 files changed, 600 insertions(+), 4 deletions(-) Approvals: Martin Betak: Looks good to me, but someone else must approve Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife1c6f7db53228d0e40242d620f9e40ff2344439 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: NetworkValidator uses new validation syntax
by mkolesni＠redhat.com 01 Jul '14

01 Jul '14

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: NetworkValidator uses new validation syntax ...................................................................... engine: NetworkValidator uses new validation syntax Refactor the NetworkValidator to use the new validation synatx for fluently specifying the validation when possible. In one instance the usage was with "when" instead of unless, since the positive case was easier to read than the negative one. Change-Id: I218166e474c0fb046791f9785f68ac39f4767793 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkValidator.java 1 file changed, 16 insertions(+), 21 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29415 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I218166e474c0fb046791f9785f68ac39f4767793 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Clear syntax for writing validations
by mkolesni＠redhat.com 01 Jul '14

01 Jul '14

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Clear syntax for writing validations ...................................................................... engine: Clear syntax for writing validations Normally when using ValidationResult to do validations the code looks like the following examples: 1. Check positive case (using ternary operator): return FeatureSupported.nonVmNetwork(getDataCenter().getcompatibility_version()) ? ValidationResult.VALID : new ValidationResult(VdcBllMessages.NON_VM_NETWORK_NOT_SUPPORTED_FOR_POOL_LEVEL); 2. Check negative case (using if): VDSStatus hostStatus = getVds().getStatus(); if (hostStatus != VDSStatus.Maintenance && hostStatus != VDSStatus.Up && hostStatus != VDSStatus.NonOperational) { return new ValidationResult( VdcBllMessages.ACTION_TYPE_FAILED_VDS_STATUS_ILLEGAL, VdcBllMessages.VAR__HOST_STATUS__UP_MAINTENANCE_OR_NON_OPERATIONAL.name()); } return ValidationResult.VALID; 3. Check negative case (using ternary operator): return getVds() == null ? new ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_HOST_NOT_EXIST) : ValidationResult.VALID; And so forth.. The suggested syntax would enable simpler checking that is focused on a fluent syntax that's easy to write and read. To check a positive case you would write (Instead of example #1): return ValidationResult.failWith(VdcBllMessages.NON_VM_NETWORK_NOT_SUPPORTED_FOR_POOL_LEVEL) .unless(FeatureSupported.nonVmNetwork(getDataCenter().getcompatibility_version())); To check a negative case you would write (Instead of example #3): return ValidationResult.failWith(VdcBllMessages.ACTION_TYPE_FAILED_HOST_NOT_EXIST) .when(getVds() == null); Example #2 could be rewritten in a similar matter (the condition could be simplified/extracted). The new syntax presents a more comprehensible way to read and write the validation logic, and abstracts the repetitive decision of returning the valid or invalid result. In the next patch there will be a small refactor to demonstrate the usage. In the future, the ValidationResult constructors could be hidden in favor of this API (after refactoring their usages). Change-Id: I2e40ce1bf69d2df45d3136a9f2db0afc00a02159 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ValidationResult.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ValidationResultTest.java 2 files changed, 112 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved Yair Zaslavsky: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e40ce1bf69d2df45d3136a9f2db0afc00a02159 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: host-deploy: appropriate message for kdump detection
by oourfali＠redhat.com 01 Jul '14

01 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: host-deploy: appropriate message for kdump detection ...................................................................... host-deploy: appropriate message for kdump detection 1. a system that does not support kdump is expected, so it cannot be warning. 2. messages with '!' are not polite, user did not do anything to justify that. Change-Id: Ie10ebdbbc0b5148e4cd6e1b2deb251f96a2f56c7 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29369 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie10ebdbbc0b5148e4cd6e1b2deb251f96a2f56c7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0