- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: frontend: disable spice options in instance types
by tjelinek＠redhat.com 30 May '14

30 May '14

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: disable spice options in instance types ...................................................................... frontend: disable spice options in instance types This patch disables the spice settings added in commit 662f6fa8d26409be4e4c4b835e29a61e20d20244 And wrongly left partially enabled. Change-Id: I6c8cd0ecb84e21c5406cbb6bc4950cb8537645b0 Bug-Url: https://bugzilla.redhat.com/?????? Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/instancetypes/InstanceTypesPopupWidget.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/28207 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c8cd0ecb84e21c5406cbb6bc4950cb8537645b0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fixed iscsi storage dialog spacing
by derez＠redhat.com 29 May '14

29 May '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: fixed iscsi storage dialog spacing ...................................................................... webadmin: fixed iscsi storage dialog spacing PatternFly patch caused some spacing issues in iscsi storage dialog and attach virtual disk dialog. Fixed. Bug-Url: https://bugzilla.redhat.com/1095374 Change-Id: I6aba6206a4d32ae3df935c4aadc524d980d5c2f5 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiDiscoverTargetsView.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml M packaging/branding/ovirt.brand/patternfly-custom-hacks.css 6 files changed, 10 insertions(+), 11 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28195 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6aba6206a4d32ae3df935c4aadc524d980d5c2f5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Pass map instead of strings to KeyValueModel
by lvernia＠redhat.com 29 May '14

29 May '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Pass map instead of strings to KeyValueModel ...................................................................... webadmin: Pass map instead of strings to KeyValueModel Instead of converting to and from strings, try to keep the data as a map. Change-Id: Ic57b3157960e829d43073c1614647b25a3b6a139 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/customprop/VmPropertiesUtils.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/scheduling/NewClusterPolicyModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/WebadminRunOnceModel.java 8 files changed, 21 insertions(+), 50 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic57b3157960e829d43073c1614647b25a3b6a139 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Connect Storage Pool on iSCSI update
by oourfali＠redhat.com 29 May '14

29 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Connect Storage Pool on iSCSI update ...................................................................... core: Connect Storage Pool on iSCSI update We should catch the exception when calling ConnectStorageServer since we should try to connect all the hosts, and if one of them fails we should keep try to connect all the other hosts. Change-Id: I4b125471920792d8bfaae2327e6aa757c378ef0e Bug-Url: https://bugzilla.redhat.com/1102687 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseIscsiBondCommand.java 1 file changed, 12 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/28214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b125471920792d8bfaae2327e6aa757c378ef0e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: build: added maven variable for gwt css obfuscation
by vszocs＠redhat.com 29 May '14

29 May '14

Vojtech Szocs has submitted this change and it was merged. Change subject: build: added maven variable for gwt css obfuscation ...................................................................... build: added maven variable for gwt css obfuscation Added gwt.cssResourceStyle variable that sets GWT's CssResource.style property. This property controls the GWT CSS obfuscation. Use 'obs' for obfuscated (the default), or 'pretty' for human-readable. 'pretty' mode is very help for CSS development and debugging. Change-Id: Icdc4b08f47a2e1570b07037ff30fc4705f308b0a Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/UserPortal.gwt.xml M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/WebAdmin.gwt.xml 3 files changed, 8 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Looks good to me, but someone else must approve Greg Sheremeta: Verified Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icdc4b08f47a2e1570b07037ff30fc4705f308b0a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: removed unused import causing build failure
by ydary＠redhat.com 29 May '14

29 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: removed unused import causing build failure ...................................................................... packaging: removed unused import causing build failure Change-Id: Iab10b03f921a6beb9b757dae1c0f66ceffa05556 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/config/jasper.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Yedidyah Bar David: Looks good to me, but someone else must approve Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab10b03f921a6beb9b757dae1c0f66ceffa05556 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: fixed configure dialog misc issues
by gchaplik＠redhat.com 29 May '14

29 May '14

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: fixed configure dialog misc issues ...................................................................... webadmin: fixed configure dialog misc issues PatternFly patch caused multiple alignment issues in the Configure dialog. Fixed. Change-Id: I862051b41bf076b6f745f2adfafa6d29562a22d8 Bug-Url: https://bugzilla.redhat.com/1096845 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RolePopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyPopupView.ui.xml M packaging/branding/ovirt.brand/patternfly-custom-hacks.css 4 files changed, 46 insertions(+), 13 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28199 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I862051b41bf076b6f745f2adfafa6d29562a22d8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fixed misaligned arrow icon in footer bar
by derez＠redhat.com 29 May '14

29 May '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: fixed misaligned arrow icon in footer bar ...................................................................... webadmin: fixed misaligned arrow icon in footer bar PatternFly patch caused misaligned arrow icon in footer bar. Fixed. Change-Id: I5b11c01653749cceef6c89498bfda9540cf3867b Bug-Url: https://bugzilla.redhat.com/1095114 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/footer/AlertsEventsFooterView.ui.xml 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/28193 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b11c01653749cceef6c89498bfda9540cf3867b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: cleaned up whitespace
by lvernia＠redhat.com 29 May '14

29 May '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: cleaned up whitespace ...................................................................... webadmin: cleaned up whitespace cleanup whitepace Change-Id: I0ffd4c9a372c4c1d468b7f419e5217f2571de416 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RolePopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyPopupView.ui.xml 3 files changed, 241 insertions(+), 241 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ffd4c9a372c4c1d468b7f419e5217f2571de416 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fixed vNIC widget in add/edit VM dialog
by lvernia＠redhat.com 29 May '14

29 May '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: fixed vNIC widget in add/edit VM dialog ...................................................................... webadmin: fixed vNIC widget in add/edit VM dialog PatternFly patch caused vNIC widget in add/edit VM dialog to have a misaligned label. Fixed. Change-Id: Ib8edda05b9770dc4cbfc493a2f62f8c3124a33a6 Bug-Url: https://bugzilla.redhat.com/1096845 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M packaging/branding/ovirt.brand/patternfly-custom-hacks.css 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: oVirt Jenkins CI Server: Looks good to me, but someone else must approve Greg Sheremeta: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8edda05b9770dc4cbfc493a2f62f8c3124a33a6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0