- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: aaa: fix misc null pointer exceptions
by yzaslavs＠redhat.com 29 May '14

29 May '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: fix misc null pointer exceptions ...................................................................... aaa: fix misc null pointer exceptions Topic: AAA Change-Id: Ifcd2c3c8dcc0989951d6274bb3d75d7f93c8c728 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LogoutUserCommand.java 3 files changed, 47 insertions(+), 43 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifcd2c3c8dcc0989951d6274bb3d75d7f93c8c728 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: reports: fixed a bug in dr1 query
by ydary＠redhat.com 29 May '14

29 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: fixed a bug in dr1 query ...................................................................... reports: fixed a bug in dr1 query Change-Id: I06ff19315152047c6d08ffc57bf4abfd57fbaff7 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/reports_resources/embedded_reports/webadmin_dashboards/system_dashboard/jrxmls/system_entities_counts_list_dr1_jrxml.data 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28200 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06ff19315152047c6d08ffc57bf4abfd57fbaff7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-image-uploader[master]: ovirt-image-uploader: using API SDK insecure parameter
by sbonazzo＠redhat.com 29 May '14

29 May '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-image-uploader: using API SDK insecure parameter ...................................................................... ovirt-image-uploader: using API SDK insecure parameter Correctly mapping command line insecure parameter to API SDK insecure parameter. Change-Id: I384e4749044bc2a7027cb550d6985bd1f741c9e0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1102226 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/__main__.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/28189 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I384e4749044bc2a7027cb550d6985bd1f741c9e0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-iso-uploader[master]: ovirt-iso-uploader: using API SDK insecure parameter
by sbonazzo＠redhat.com 29 May '14

29 May '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-iso-uploader: using API SDK insecure parameter ...................................................................... ovirt-iso-uploader: using API SDK insecure parameter Correctly mapping command line insecure parameter to API SDK insecure parameter. Change-Id: I2c76ee34b51bfe111ff319f4e75b7ddb09f03bcf Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1100824 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/__main__.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/28153 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c76ee34b51bfe111ff319f4e75b7ddb09f03bcf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in mom[master]: Revert "Adding support in CPU monitoring"
by alitke＠redhat.com 28 May '14

28 May '14

Adam Litke has submitted this change and it was merged. Change subject: Revert "Adding support in CPU monitoring" ...................................................................... Revert "Adding support in CPU monitoring" This reverts commit a7fa2ec418c65c881362950a4e680fa56afe63cc. Build Failure: http://jenkins.ovirt.org/job/mom_create-rpms/45/label=centos64/console Also, API was not agreed to by vdsm developers. Change-Id: If26228ca6219927534abde90ac600f1eafc7f729 Signed-off-by: Adam Litke <alitke(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/27940 --- M mom/Collectors/Collector.py D mom/Collectors/GuestCpuTune.py D mom/Collectors/HostCpu.py D mom/Controllers/CpuTune.py M mom/HypervisorInterfaces/libvirtInterface.py M mom/HypervisorInterfaces/vdsmInterface.py 6 files changed, 0 insertions(+), 225 deletions(-) Approvals: Adam Litke: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If26228ca6219927534abde90ac600f1eafc7f729 Gerrit-PatchSet: 4 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Storage main-tab - support column sorting
by derez＠redhat.com 28 May '14

28 May '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Storage main-tab - support column sorting ...................................................................... webadmin: Storage main-tab - support column sorting Applied 'makeSortable' method to columns that are supported by search mechanism. ToDo: implement custom comparators for columns that are not supported by search (e.g. 'Total Space'). Change-Id: I689c86d2fb0e0b9070434d17aa4977a64d660cc1 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/StorageDomainFieldAutoCompleter.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabStorageView.java 3 files changed, 54 insertions(+), 32 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27658 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I689c86d2fb0e0b9070434d17aa4977a64d660cc1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: send domains map on connectStoragePool
by amureini＠redhat.com 28 May '14

28 May '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: send domains map on connectStoragePool ...................................................................... core: send domains map on connectStoragePool This patch adds the support for the new connectStoragePool API introduced in vdsm for the data center level 3.4: connectStoragePool(hostId, scsiKey, mstUUID, masterVersion, domainsMap) domainMap is a dictionary of domains UUID and their current status [Attached|Active], e.g.: domainMap = { sdUUID1: "Attached", sdUUID2: "Active", ... } Now that connectStoragePool contains all the information about the pool domains the refreshStoragePool call is obsolete and in fact in data center level 3.4 should never be used. Feature page at: http://wiki.ovirt.org/Features/StoragePool_Metadata_Removal Change-Id: Ic16034c6757959e5d0445814a8acc2221a74f6aa Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AfterDeactivateSingleAsyncOperation.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConntectVDSToPoolAndDomains.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshPoolSingleAsyncOperation.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshStoragePoolAndDisconnectAsyncOperation.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ConnectStoragePoolVDSCommandParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/RefreshStoragePoolVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStoragePoolVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/RefreshStoragePoolVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 19 files changed, 236 insertions(+), 161 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22712 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic16034c6757959e5d0445814a8acc2221a74f6aa Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: synchronize pool storage domain operations
by amureini＠redhat.com 28 May '14

28 May '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: synchronize pool storage domain operations ...................................................................... core: synchronize pool storage domain operations Storage domain activation and deactivation were historically synchronized on the SPM. In preparation for the storage pool metadata removal we need to move this synchronization on the engine side in order to send consistent domains map information when connecting or refreshing the storage pool. Change-Id: Ie2d90d9589181802a2722b0e841a6342af0a807c Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/eventqueue/EventType.java 5 files changed, 65 insertions(+), 7 deletions(-) Approvals: Federico Simoncelli: Verified Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25190 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2d90d9589181802a2722b0e841a6342af0a807c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add the domain activating state
by amureini＠redhat.com 28 May '14

28 May '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: add the domain activating state ...................................................................... core: add the domain activating state This patch adds an additional "Activating" domain state used to track the ongoing operation so that we can do more informed decisions (for example building the storage pool domains map). Change-Id: I537dd962d16fa602f101b91fb68c037be4fa307d Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatus.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/StorageDomainStatus.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/storage/StoragePoolDomainHelper.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/StorageDomainStatusColumn.java 9 files changed, 17 insertions(+), 5 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28184 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I537dd962d16fa602f101b91fb68c037be4fa307d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-guest-agent[master]: Fix SSO on RHEL6
by vfeenstr＠redhat.com 28 May '14

28 May '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Fix SSO on RHEL6 ...................................................................... Fix SSO on RHEL6 The new pam implementation needs the ask_secret to be answered as well. Change-Id: I21f5da545d4fa26f816c4e25c88eccb09d4cfd56 Bug-Url: https://bugzilla.redhat.com/1102095 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M gdm-plugin/gdm-ovirtcred-extension.c M gdm2-plugin/gdm-ovirtcred-extension.c 2 files changed, 15 insertions(+), 1 deletion(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28186 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21f5da545d4fa26f816c4e25c88eccb09d4cfd56 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0