- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: State that vm ended with error in notifier
by emesika＠redhat.com 26 May '14

26 May '14

Eli Mesika has submitted this change and it was merged. Change subject: core: State that vm ended with error in notifier ...................................................................... core: State that vm ended with error in notifier Currently when engine stops with error, notifier doesn't state this fact in email subj. However it should explicitly state that VM went down with error. This patch corrects the message. Change-Id: Idf5668022ab00ddd4439c65c779d48843b81e3eb Bug-Url: https://bugzilla.redhat.com/1070873 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27614 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf5668022ab00ddd4439c65c779d48843b81e3eb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: fixes to Authz utils
by yzaslavs＠redhat.com 26 May '14

26 May '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: fixes to Authz utils ...................................................................... aaa: fixes to Authz utils Change-Id: Iceff3f7355219e1887f4e8736d78af94f6ab310e Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SearchQueryParsingUtils.java 2 files changed, 4 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27967 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iceff3f7355219e1887f4e8736d78af94f6ab310e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: rest api: edit running vm
by ofrenkel＠redhat.com 26 May '14

26 May '14

Omer Frenkel has submitted this change and it was merged. Change subject: rest api: edit running vm ...................................................................... rest api: edit running vm Add field to vm to indicate there is configuration for next run. Add url parameter for getting the configuration (usage: api/vms/vmId;next_run) and the same for updating vm, marking not to hot plug changes if any (for example not to hot plug cpu if changed while vm is running, usage is the same) Feature page: http://www.ovirt.org/Features/Edit_Running_VM Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1072313 Change-Id: I848a9fefb74a982923f655fc1293dc38f419cb1c Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 5 files changed, 39 insertions(+), 1 deletion(-) Approvals: Ori Liel: Looks good to me, approved Omer Frenkel: Verified -- To view, visit http://gerrit.ovirt.org/27382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I848a9fefb74a982923f655fc1293dc38f419cb1c Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.1]: packaging: setup: suppress logging of VM password
by sbonazzo＠redhat.com 26 May '14

26 May '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: suppress logging of VM password ...................................................................... packaging: setup: suppress logging of VM password Also use LOG_FILTER_KEYS for other cases, so that we can do that right at the beginning. Bug-Url: https://bugzilla.redhat.com/1096838 Change-Id: I92ef0a1516d7a6dd70d3fd53ceac3c71ce1eaf24 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-hosted-engine-setup.spec.in M src/plugins/ovirt-hosted-engine-setup/core/remote_answerfile.py M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py 4 files changed, 12 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/28076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92ef0a1516d7a6dd70d3fd53ceac3c71ce1eaf24 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.1 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: reports: added a condition vms / hosts are active
by ydary＠redhat.com 25 May '14

25 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: added a condition vms / hosts are active ...................................................................... reports: added a condition vms / hosts are active added a condition to the report query, taht the vms or hosts must be active. Change-Id: If078b29e2eb9a48018ab9035e9880fc320fdbe3e Bug-Url: https://bugzilla.redhat.com/1085874 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/Reports/Executive/summary_of_host_usage_resources_br17_files/summary_of_host_usage_resources_br17_jrxml.data M packaging/ovirt-reports/resources/Reports/Trend/Hosts/Five_most_utilized_hosts_over_time_files/Five_most_utilized_hosts_over_time_jrxml.data M packaging/ovirt-reports/resources/Reports/Trend/Hosts/five_least_utilized_hosts_br5_files/five_least_utilized_hosts_br5_jrxml.data M packaging/ovirt-reports/resources/Reports/Trend/Hosts/multiple_hosts_resource_usage_br3_files/multiple_hosts_resource_usage_br3_jrxml.data M packaging/ovirt-reports/resources/Reports/Trend/Hosts/single_host_resource_br2a_files/single_host_resource_br2a_jrxml.data M packaging/ovirt-reports/resources/Reports/Trend/Hosts/single_host_resource_usage_dow_br2b_files/single_host_resource_usage_dow_br2b.data M packaging/ovirt-reports/resources/Reports/Trend/Hosts/single_host_resource_usage_hour_of_day_br2c_files/single_host_resource_usage_hour_of_day_br2c_jrxml.data M packaging/ovirt-reports/resources/Reports/Trend/Virtual_machines/five_least_utilized_vms_Over_Time_BR12_files/five_least_utilized_vms_Over_Time_BR12_jrxml.data M packaging/ovirt-reports/resources/Reports/Trend/Virtual_machines/five_most_utilized_vms_over_time_br11_files/five_most_utilized_vms_over_time_br11_jrxml.data M packaging/ovirt-reports/resources/Reports/Trend/Virtual_machines/multiple_vms_resource_usage_over_time_br16_files/multiple_vms_resource_usage_over_time_br16_jrxml.data M packaging/ovirt-reports/resources/Reports/Trend/Virtual_machines/single_vm_resources_days_week_BR10B_files/single_vm_resources_days_week_BR10B_jrxml.data M packaging/ovirt-reports/resources/Reports/Trend/Virtual_machines/single_vm_resources_hour_of_day_BR10c_files/single_vm_resources_hour_of_day_BR10c_jrxml.data M packaging/ovirt-reports/resources/Reports/Trend/Virtual_machines/single_vm_resources_over_time_BR10A_files/single_vm_resources_over_time_BR10A_jrxml.data M packaging/ovirt-reports/resources/reports_resources/embedded_reports/System_Overview_Dashboard/summary_of_host_usage_resources_br17_files/summary_of_host_usage_resources_br17_jrxml.data M packaging/ovirt-reports/resources/reports_resources/embedded_reports/Trends_Dashboard/Five_most_utilized_hosts_over_time_files/Five_most_utilized_hosts_over_time_jrxml.data M packaging/ovirt-reports/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/jrxmls/cluster_summary_of_hosts_resources_usage_dr28_jrxml.data M packaging/ovirt-reports/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/jrxmls/dc_summary_of_cluster_hosts_resources_usage_dr27_jrxml.data 17 files changed, 387 insertions(+), 253 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28077 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If078b29e2eb9a48018ab9035e9880fc320fdbe3e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: block preview of active vm snapshot
by derez＠redhat.com 25 May '14

25 May '14

Daniel Erez has submitted this change and it was merged. Change subject: core: block preview of active vm snapshot ...................................................................... core: block preview of active vm snapshot * TryBackToAllSnapshotsOfVmCommand -> canDo: - Active VM snapshot validation. * DiskSnapshotsValidator: - Added canDiskSnapshotsBePreviewed validation. - Allow custom preview of active VM configuration only when selecting a subset of snapshot disks. Change-Id: Iee5d5e6716cec69f36e2e98fa2c1578c53dc2384 Bug-Url: https://bugzilla.redhat.com/1096884 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskSnapshotsValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/DiskSnapshotsValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 88 insertions(+), 17 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27817 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee5d5e6716cec69f36e2e98fa2c1578c53dc2384 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: Adding findbugs-general profile to pom.xml
by yzaslavs＠redhat.com 25 May '14

25 May '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Adding findbugs-general profile to pom.xml ...................................................................... aaa: Adding findbugs-general profile to pom.xml Change-Id: I4ac1305b12346fcf4bd55c4c1fa628d7a53d353c Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/aaa/pom.xml 1 file changed, 43 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28075 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ac1305b12346fcf4bd55c4c1fa628d7a53d353c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: CompensationContext - add support for updated entity o...
by laravot＠redhat.com 25 May '14

25 May '14

Liron Ar has submitted this change and it was merged. Change subject: core: CompensationContext - add support for updated entity only. ...................................................................... core: CompensationContext - add support for updated entity only. In some cases when we update an entity we would like to use the compensation context to attempt to only update the entity to it's previous state rather than possibly re-insert it as we perform only updates and there might be operations that removed it intentionally without consideration of other running operations. Change-Id: I527d8b95b82f76fb4ce0db7e6ec967c23b759524 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/CompensationContext.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/DefaultCompensationContext.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/NoOpCompensationContext.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntitySnapshot.java 5 files changed, 27 insertions(+), 5 deletions(-) Approvals: Liron Ar: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25231 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I527d8b95b82f76fb4ce0db7e6ec967c23b759524 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: proceedStorageDomainTreatmentByDomainType - proper com...
by laravot＠redhat.com 25 May '14

25 May '14

Liron Ar has submitted this change and it was merged. Change subject: core: proceedStorageDomainTreatmentByDomainType - proper compensation ...................................................................... core: proceedStorageDomainTreatmentByDomainType - proper compensation proceedStorageDomainTreatmentByDomainType() method updates different properties of the storage domain, to use the compensation mechanisam in case of failure the storage domain's static data before the updates was saved in the compensation context. The snapshotEntity() method used for saving the static in the compensation context has documentation stating the in case that the entity was deleted/updated it would be restored to it's state as saved, which means that if it was deleted, the entity would be re-inserted. ForceRemoveStorageDomainCommand is an engine command to remove a domain from the database forcibly at the user risk, this command can run parallely to the ReconstructMasterDomainCommand (wether it's right or wrong is another discussion) which executes the proceedStorageDomainTreatmentByDomainType() method. This can cause to an issue - if the domain is removed by the removal command, the compensation used in the reconstruct command might re-insert domain related records to the db. In this patch i handle this issue by using the snapshotEntityUpdated() method which is more correct in that case (as we only update the entity) and will remove the possibility of mistkenly re-inserting the data. Further on we should inspect why and if we should allow those commands to run in parallel. Change-Id: I9ec99cf5e567fe9820e4028a886372d73d5c1d6f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=969026 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Liron Ar: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25232 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ec99cf5e567fe9820e4028a886372d73d5c1d6f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core : Domain of group is not shown in sub tab of users tab
by oourfali＠redhat.com 25 May '14

25 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: core : Domain of group is not shown in sub tab of users tab ...................................................................... core : Domain of group is not shown in sub tab of users tab Domain of groups added is not shown in general sub tab of users tab Change-Id: Id9aee2ad6491c6f9feee3fd3a92d68a20e8192da Bug-Url: https://bugzilla.redhat.com/1087498 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAODbFacadeImpl.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9aee2ad6491c6f9feee3fd3a92d68a20e8192da Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0