- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal: add 'update on next restart' dialog
by ahadas＠redhat.com 20 May '14

20 May '14

Arik Hadas has submitted this change and it was merged. Change subject: userportal: add 'update on next restart' dialog ...................................................................... userportal: add 'update on next restart' dialog On update running VM such that part of the changed configuration can be applied only when the VM will be restarted, new dialog is presented with a proper message and the user can choose whether cpu changes (if exist) will be applied immediately or later. Change-Id: Ie2fbede65c57505d1290cd8eb6c3bc239a6eb47d Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/PresenterModule.java A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/popup/vm/VmNextRunConfigurationPresenterWidget.java A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmNextRunConfigurationPopupView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/vm/UserPortalListProvider.java 5 files changed, 171 insertions(+), 57 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/27582 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2fbede65c57505d1290cd8eb6c3bc239a6eb47d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: add 'update on next restart' dialog
by ahadas＠redhat.com 20 May '14

20 May '14

Arik Hadas has submitted this change and it was merged. Change subject: webadmin: add 'update on next restart' dialog ...................................................................... webadmin: add 'update on next restart' dialog On update running VM such that part of the changed configuration can be applied only when the VM will be restarted, new dialog is presented with a proper message and the user can choose whether cpu changes (if exist) will be applied immediately or later. Change-Id: Ic2d7a5fa18bc2df73d5e9d898cd3f23f52fdf0ba Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmNextRunConfigurationWidget.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmNextRunConfigurationWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmNextRunConfigurationModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VirtualMachineModule.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/vm/VmNextRunConfigurationPresenterWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmNextRunConfigurationPopupView.java 13 files changed, 266 insertions(+), 6 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27558 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2d7a5fa18bc2df73d5e9d898cd3f23f52fdf0ba Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: amend style for confirm host reboot dialog
by derez＠redhat.com 20 May '14

20 May '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: amend style for confirm host reboot dialog ...................................................................... webadmin: amend style for confirm host reboot dialog To accommodate PatternFly changes, amend style for 'Confirm host has been rebooted' dialog (avoid vertical scrollbar/missing padding). Before-Screenshot: http://i.imgur.com/oEpNKkG.jpg After-Screenshot: http://i.imgur.com/TEPzHFZ.jpg Change-Id: I16f43d896014143b1eb90276d8b625b94589d7e6 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/ManualFenceConfirmationPopupView.ui.xml 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Alexander Wels: Looks good to me, approved Daniel Erez: Verified Greg Sheremeta: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16f43d896014143b1eb90276d8b625b94589d7e6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin, userportal: Use GWTP Bootstrapper for ApplicationInit
by vszocs＠redhat.com 20 May '14

20 May '14

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Use GWTP Bootstrapper for ApplicationInit ...................................................................... webadmin,userportal: Use GWTP Bootstrapper for ApplicationInit Before this patch, ApplicationInit classes were bound in GIN SystemModule as eager singletons. This was to ensure that these classes are instantiated right after Ginjector is created, i.e. before GWTP place transition kicks in. After this patch, ApplicationInit classes implement GWTP Bootstrapper interface, effectively replacing the use of DefaultBootstrapper (built-in GWTP fallback). The role of GWTP Bootstrapper is to perform any application-specific initialization before initiating transition to requested application place, as defined by history token within the URL. By utilizing GWTP Bootstrapper feature, we no longer have to rely on eager singletons to perform initialization at application startup. Change-Id: I31472c718678ef2ccd45fbf1d988f3faa49bb54d Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/SystemModule.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/system/ApplicationInit.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/UserPortal.gwt.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/SystemModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/ApplicationInit.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/WebAdmin.gwt.xml 7 files changed, 50 insertions(+), 12 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25209 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31472c718678ef2ccd45fbf1d988f3faa49bb54d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: refactor VmListModel#onSave method
by ahadas＠redhat.com 20 May '14

20 May '14

Arik Hadas has submitted this change and it was merged. Change subject: frontend: refactor VmListModel#onSave method ...................................................................... frontend: refactor VmListModel#onSave method Extract code from VmListModel#onSave to two separate methods: - saveNewVm which adds VM as new entity - updateExistingVm which updates existing VM entity It makes the code more maintainable, as the onSave method was too long and had too many responsibilities. Change-Id: I90a0164146fd17eb2dced71699bbf3d8ac489004 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 1 file changed, 185 insertions(+), 183 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27557 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90a0164146fd17eb2dced71699bbf3d8ac489004 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: query for getting 'updateable on next run' fields
by ahadas＠redhat.com 20 May '14

20 May '14

Arik Hadas has submitted this change and it was merged. Change subject: core: query for getting 'updateable on next run' fields ...................................................................... core: query for getting 'updateable on next run' fields Add query that gets two versions of VMs and returns the names of the fields which are different between those versions and could be updated only when the VM will be restarted. Change-Id: I6fd7133770aafee5b2bc551d3cffc8951f5d58df Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmUpdatesOnNextRunExistsQuery.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmUpdatesOnNextRunExistsQueryTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmUpdatesOnNextRunExistsParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 5 files changed, 225 insertions(+), 0 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27457 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fd7133770aafee5b2bc551d3cffc8951f5d58df Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add default value for custom properties
by ofrenkel＠redhat.com 20 May '14

20 May '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: add default value for custom properties ...................................................................... core: add default value for custom properties For some flows the custom properties of VM were not initialized, thus they could be null. When the VM was edited from the UI, if no custom properties were set, they were set to empty string. This inconsistency caused false alarms on checks whether the custom properties were changed - because a transition from null to empty string was detected as change. This patch defines empty string as a default value for the custom properties. It is safe since in all its usages, we check whether the custom properties is null or empty string. Change-Id: I74cc88b9bef6ace4a608c6d15f27b9c8f678564d Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/27882 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74cc88b9bef6ace4a608c6d15f27b9c8f678564d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Malformed GUID - fail gracefully
by juan.hernandez＠redhat.com 20 May '14

20 May '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Malformed GUID - fail gracefully ...................................................................... restapi: Malformed GUID - fail gracefully Until now, the http response would contain an unclear exception. After this change, error message will be something like: "Invalid UUID string: SOME_@#%$@_BAD_^@$^_UUID" Change-Id: Icf2d4db9b5e30a86b5eb2bb3071612a48867a646 Bug-Url: https://bugzilla.redhat.com/902073 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAffinityGroupVmsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCentersResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDomainsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendUsersResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBricksResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ApplicationMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/EventMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ReportedDeviceMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/GuidUtils.java 18 files changed, 48 insertions(+), 27 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27140 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf2d4db9b5e30a86b5eb2bb3071612a48867a646 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: fixed typo when accessing the metadata dict
by msivak＠redhat.com 20 May '14

20 May '14

Martin Sivák has submitted this change and it was merged. Change subject: fixed typo when accessing the metadata dict ...................................................................... fixed typo when accessing the metadata dict Change-Id: I3fafb2e6670e0ef3ce18d2f0f03dfa1a2939e36d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1092075 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/state_machine.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Verified; Looks good to me, approved Jiří Moskovčák: Verified -- To view, visit http://gerrit.ovirt.org/27832 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3fafb2e6670e0ef3ce18d2f0f03dfa1a2939e36d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: jaas: add misc profiles to standalone jaas
by yzaslavs＠redhat.com 20 May '14

20 May '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: jaas: add misc profiles to standalone jaas ...................................................................... aaa: jaas: add misc profiles to standalone jaas 1. debug. 2. system credentials, test using system tgt. 3. system credentials with debug. Topic: AAA Change-Id: I58740326735baee5c4313005e060db8f3a81e9f9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/conf/jaas.conf 1 file changed, 28 insertions(+), 7 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27900 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58740326735baee5c4313005e060db8f3a81e9f9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0