- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal: fixed right-click context menu to match webadmin
by awels＠redhat.com 20 May '14

20 May '14

Alexander Wels has submitted this change and it was merged. Change subject: userportal: fixed right-click context menu to match webadmin ...................................................................... userportal: fixed right-click context menu to match webadmin Userportal's context menu style did not match the style used in webadmin. It was missing a border, and the color and padding was wrong. As far as I can tell, it has always been this way, and is probably an oversight. Fixed. Change-Id: I98d8ce62ba859863ce5b2b3cad5f65488d236ac2 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/MainSectionView.ui.xml M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/public/UserPortal.css 2 files changed, 82 insertions(+), 6 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Einav Cohen: Looks good to me, but someone else must approve Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/27893 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98d8ce62ba859863ce5b2b3cad5f65488d236ac2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal: fixed misc padding issues
by awels＠redhat.com 20 May '14

20 May '14

Alexander Wels has submitted this change and it was merged. Change subject: userportal: fixed misc padding issues ...................................................................... userportal: fixed misc padding issues PatternFly patch caused some padding issues in the extended view composite button-cell and table row edges. Fixed. Change-Id: I3ffae021f211bb3dc76d1fc6d70c486fde630a26 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/extended/vm/BorderedCompositeCell.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/css/SideTabWithDetailsViewStyle.css 2 files changed, 3 insertions(+), 1 deletion(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/27892 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ffae021f211bb3dc76d1fc6d70c486fde630a26 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Repair disallow RO in UI
by derez＠redhat.com 20 May '14

20 May '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Repair disallow RO in UI ...................................................................... webadmin: Repair disallow RO in UI Qemu currently does not support direct-LUN disks connected using VirtIO-SCSI. This patch blocks this option from UI when adding/editing/attaching a direct-LUN disk with VirtIO-SCSI interface to a VM. This wasn't checked in Add/Edit Disk to Vm dialog, nor in Attach table. IDE behaviour was changed to comply with this behaviour in this patch as well. This patch also removes un-needed verfication for IDE disk. Change-Id: Ieb1923d03785be7f228076e12f4865242aed5c90 Bug-Url: https://bugzilla.redhat.com/1097754 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 3 files changed, 21 insertions(+), 21 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27665 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb1923d03785be7f228076e12f4865242aed5c90 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[ovirt-engine-3.4]: packaging: setup: Do not fail on errors while restoring perm...
by ydary＠redhat.com 20 May '14

20 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: Do not fail on errors while restoring permissions ...................................................................... packaging: setup: Do not fail on errors while restoring permissions Bug-Url: https://bugzilla.redhat.com/1073471 Change-Id: I5368388764576a2900a772b82f84d0b366f106c7 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit c5a90953f5a2d13202f15786c577d905cd614e3c) --- M packaging/dbscripts/dbfunc-base.sh M packaging/dbscripts/dbfunc-common.sh 2 files changed, 22 insertions(+), 5 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5368388764576a2900a772b82f84d0b366f106c7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: setup: Do not fail on errors while restoring perm...
by ydary＠redhat.com 20 May '14

20 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: Do not fail on errors while restoring permissions ...................................................................... packaging: setup: Do not fail on errors while restoring permissions Bug-Url: https://bugzilla.redhat.com/1073471 Change-Id: I5368388764576a2900a772b82f84d0b366f106c7 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/dbscripts/dbfunc-base.sh M packaging/dbscripts/dbfunc-common.sh 2 files changed, 22 insertions(+), 5 deletions(-) Approvals: Yedidyah Bar David: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5368388764576a2900a772b82f84d0b366f106c7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: display principal name post authn
by yzaslavs＠redhat.com 20 May '14

20 May '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: display principal name post authn ...................................................................... aaa: display principal name post authn post authn there is no sense to display the user that user entered, as the principal name that is used is completely different. Topic: AAA Change-Id: Ibb0f7dd07d71cbcfc361f9da3d5ad677c5fb090b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27885 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb0f7dd07d71cbcfc361f9da3d5ad677c5fb090b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: dbscripts: Do not fail on errors while restoring ...
by emesika＠redhat.com 20 May '14

20 May '14

Eli Mesika has submitted this change and it was merged. Change subject: packaging: dbscripts: Do not fail on errors while restoring permissions ...................................................................... packaging: dbscripts: Do not fail on errors while restoring permissions Change-Id: I6c266617138dab641be7a06b146b9ceb57590340 Bug-Url: https://bugzilla.redhat.com/1073471 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/dbscripts/dbfunc-base.sh M packaging/dbscripts/dbfunc-common.sh 2 files changed, 22 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Eli Mesika: Looks good to me, approved Yedidyah Bar David: Verified Yaniv Dary: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27907 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c266617138dab641be7a06b146b9ceb57590340 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix potential NPE when in CheckboxColumn
by derez＠redhat.com 20 May '14

20 May '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Fix potential NPE when in CheckboxColumn ...................................................................... webadmin: Fix potential NPE when in CheckboxColumn getValue(object)) in checkboxColumn.render() might return null, resulting in an NPE when used in if. Fix the if to handle null. Note: this bug could only occur if a checkboxColumn is not editable *and* it's value is null. Change-Id: I26f688984083fbd6964972e79e50960b254c547b Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1097754 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/CheckboxColumn.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/27726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26f688984083fbd6964972e79e50960b254c547b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: removing lock from DetachStorageDomainFromPoolCommand
by laravot＠redhat.com 20 May '14

20 May '14

Liron Ar has submitted this change and it was merged. Change subject: core: removing lock from DetachStorageDomainFromPoolCommand ...................................................................... core: removing lock from DetachStorageDomainFromPoolCommand The lock on the domain id when detaching it was added in change I4ee8cd4b64393d195fe45349f49996e45ce09f0f but it's currently incorrect because the detach command is also executed from commands that already take the lock on the storage domain, which will lead to a failure. We need to pass the command context to avoid that situation, but that will be inspected in a further patch - right now this patch returns the situation to it's previous state. Change-Id: I90b801416bb932ddc08dbb2d626882fc60895826 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DetachStorageDomainFromPoolCommand.java 1 file changed, 0 insertions(+), 13 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Liron Ar: Verified -- To view, visit http://gerrit.ovirt.org/27938 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90b801416bb932ddc08dbb2d626882fc60895826 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Fix typo in message
by mkolesni＠redhat.com 20 May '14

20 May '14

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Fix typo in message ...................................................................... engine: Fix typo in message Change-Id: Ic7b7be69c0207ca61b476f0eeacf73867673fd6f Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/27931 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7b7be69c0207ca61b476f0eeacf73867673fd6f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0