- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: packaging: setup: hardening postgresql password
by sbonazzo＠redhat.com 13 May '14

13 May '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: hardening postgresql password ...................................................................... packaging: setup: hardening postgresql password Use random.SystemRandom instead of random and extend password lenght to 22 chars in order to have at least 128 bits of entropy. Change-Id: I76769e7eb65df35f982b1ef9e36bc81d1f42b79a Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit 78d5316978a2a078683819a94891d09d403d46b0) --- M packaging/setup/ovirt_engine_setup/postgres.py 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27633 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76769e7eb65df35f982b1ef9e36bc81d1f42b79a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: hardening postgresql password
by sbonazzo＠redhat.com 13 May '14

13 May '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: hardening postgresql password ...................................................................... packaging: setup: hardening postgresql password Use random.SystemRandom instead of random and extend password lenght to 22 chars in order to have at least 128 bits of entropy. Change-Id: I76769e7eb65df35f982b1ef9e36bc81d1f42b79a Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/postgres.py 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve Michael Samuel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76769e7eb65df35f982b1ef9e36bc81d1f42b79a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Samuel <mik(a)miknet.net> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Extract Qpid specific notation
by masayag＠redhat.com 13 May '14

13 May '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Extract Qpid specific notation ...................................................................... engine: Extract Qpid specific notation The Qpid notation within host installation module is being extracted to enable additional broker type to be supported (i.e. RabbitMQ which is introduced in the next patch). Change-Id: I74eadd63cb66231ee240792cebca83d19db9bccb Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/OpenstackNetworkProviderProperties.java 2 files changed, 54 insertions(+), 12 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/27567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74eadd63cb66231ee240792cebca83d19db9bccb Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fixed Coverity Scan errors
by awels＠redhat.com 13 May '14

13 May '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: fixed Coverity Scan errors ...................................................................... webadmin: fixed Coverity Scan errors removed some NPE vulnerabilities and unchecked casts Change-Id: I9e3a6438f23c530e637d557039131442ea3a73e3 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/CustomInstanceType.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 3 files changed, 19 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e3a6438f23c530e637d557039131442ea3a73e3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Persist only reported supported cluster levels
by oourfali＠redhat.com 13 May '14

13 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Persist only reported supported cluster levels ...................................................................... engine: Persist only reported supported cluster levels In order to configure the management network on the host, only the supported cluster levels should be persisted, so the setup networks can identify the supported api by the host. Change-Id: Ifc82a6d113f1b023f2dc6950e2b3c7aad8aa9ec6 Bug-Url: https://bugzilla.redhat.com/1096757 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataAfterInstallationVDSCommand.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/27626 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc82a6d113f1b023f2dc6950e2b3c7aad8aa9ec6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Add broker type to neutron agent configuration
by masayag＠redhat.com 13 May '14

13 May '14

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Add broker type to neutron agent configuration ...................................................................... webadmin: Add broker type to neutron agent configuration The broker type was added to neutron agent configuration so additional broker types could be supported. Change-Id: I04966edaebd4c9d260bbb42cae16ef3a42467ce3 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/HostNeutronAgentModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/NeutronAgentModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/NeutronAgentWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/NeutronAgentWidget.ui.xml 7 files changed, 36 insertions(+), 6 deletions(-) Approvals: Lior Vernia: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/27566 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04966edaebd4c9d260bbb42cae16ef3a42467ce3 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Generalize messaging server broker type
by masayag＠redhat.com 13 May '14

13 May '14

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Generalize messaging server broker type ...................................................................... webadmin: Generalize messaging server broker type Since we intend to support additional messaging broker types (i.e. RabbitMQ), there is a need to update all references to the messaging configuration. Change-Id: I0a18937e5174b5cf95e99b4959f622f368a333c0 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/HostNeutronAgentModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/NeutronAgentModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/NeutronAgentWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/NeutronAgentWidget.ui.xml 5 files changed, 66 insertions(+), 66 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a18937e5174b5cf95e99b4959f622f368a333c0 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Generalize messaging broker type
by masayag＠redhat.com 13 May '14

13 May '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Generalize messaging broker type ...................................................................... engine: Generalize messaging broker type The patch starts a series of refactoring patches to support various messaging broker types to be configured on hosts which are installed with an external network provider. Change-Id: Ib8075f2ef1227ab9c4a40cd3a961921d42d5ac22 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/OpenstackNetworkProviderProperties.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/NeutronAgentModel.java A packaging/dbscripts/upgrade/03_05_0420_generalize_messaging_broker_type.sql 5 files changed, 76 insertions(+), 23 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8075f2ef1227ab9c4a40cd3a961921d42d5ac22 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Persist only reported supported cluster levels
by masayag＠redhat.com 13 May '14

13 May '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Persist only reported supported cluster levels ...................................................................... engine: Persist only reported supported cluster levels In order to configure the management network on the host, only the supported cluster levels should be persisted, so the setup networks can identify the supported api by the host. Change-Id: Ifc82a6d113f1b023f2dc6950e2b3c7aad8aa9ec6 Bug-Url: https://bugzilla.redhat.com/1096757 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataAfterInstallationVDSCommand.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/27618 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc82a6d113f1b023f2dc6950e2b3c7aad8aa9ec6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-cli[master]: cli: Escape comma in values
by juan.hernandez＠redhat.com 13 May '14

13 May '14

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Escape comma in values ...................................................................... cli: Escape comma in values When a command line option uses a value with several items we use the comman character as the delimiter of name value pairs, for example: # update vm myvm --cpu-cpu_tune-vcpu_pin "vcpu_pin.vcpu=0,vcpu_pin.cpu_set=0" But some values may actually contain commas, for example the "cpu_set" value may contain a list of CPU indexes separated by commas: # update vm myvm --cpu-cpu_tune-vcpu_pin "vcpu_pin.vcpu=0,vcpu_pin.cpu_set=0,1" The CLI can't currently support this, as it assumes that "1" is a name, instead of taking it as part of the value. To allow this kind of values this patch introduces the backslash as a way to escape the delimiter (the comma), so that the command can be written as follows: # update vm myvm --cpu-cpu_tune-vcpu_pin "vcpu_pin.vcpu=0,vcpu_pin.cpu_set=0\,1" Change-Id: I4bcc5944e3f4236b3495acc02801acae7ec82eb2 Bug-Url: https://bugzilla.redhat.com/1088914 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtcli/command/command.py 1 file changed, 44 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Looks good to me, approved Juan Hernandez: Verified -- To view, visit http://gerrit.ovirt.org/27078 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4bcc5944e3f4236b3495acc02801acae7ec82eb2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0