- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: UI: possible NPE prevention
by shavivi＠redhat.com 13 May '14

13 May '14

Shahar Havivi has submitted this change and it was merged. Change subject: UI: possible NPE prevention ...................................................................... UI: possible NPE prevention Change-Id: Ie8925e63f7cd0343c7d1379a8f830ca49b45d448 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.java 1 file changed, 8 insertions(+), 6 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8925e63f7cd0343c7d1379a8f830ca49b45d448 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: host-deploy: support remain in same vector entry
by yzaslavs＠redhat.com 13 May '14

13 May '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: host-deploy: support remain in same vector entry ...................................................................... host-deploy: support remain in same vector entry this enables setting N values based on external source such as database table. Change-Id: Ib535fe2e971ca074cd7de7dd501d561db21e8d9f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java 1 file changed, 116 insertions(+), 107 deletions(-) Approvals: Alon Bar-Lev: Verified Moti Asayag: Looks good to me, approved Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27077 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib535fe2e971ca074cd7de7dd501d561db21e8d9f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-node-plugin-vdsm[node-3.0]: engine_page: set password when no address is used
by dougsland＠redhat.com 12 May '14

12 May '14

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: engine_page: set password when no address is used ...................................................................... engine_page: set password when no address is used We should allow users to set password even when no registration is required. Change-Id: I4d2f27901fd01a8ebd1926ac7328b5cf04ea88aa Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1096074 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 7 insertions(+), 6 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27604 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d2f27901fd01a8ebd1926ac7328b5cf04ea88aa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: node-3.0 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-node-plugin-vdsm[master]: engine_page: set password when no address is used
by dougsland＠redhat.com 12 May '14

12 May '14

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: engine_page: set password when no address is used ...................................................................... engine_page: set password when no address is used We should allow users to set password even when no registration is required. Change-Id: I4d2f27901fd01a8ebd1926ac7328b5cf04ea88aa Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1096074 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 7 insertions(+), 6 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27603 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d2f27901fd01a8ebd1926ac7328b5cf04ea88aa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: rest: retrieve disk snapshots list by storage domain
by derez＠redhat.com 12 May '14

12 May '14

Daniel Erez has submitted this change and it was merged. Change subject: rest: retrieve disk snapshots list by storage domain ...................................................................... rest: retrieve disk snapshots list by storage domain * Introduce a support for retrieving disk snapshots from storage domain context: - GET /api/storagedomains/{storage_id}/disksnapshots - Added a new rest entity - DiskSnapshot: -- Represents a snapshot of a disk. -- Its ID is the image_id; as DiskImage in backend composed of an image_group_id (the id of the Disk), and a list of DiskImages (snapshots) which differentiate by image_id. Hence, each DiskSnapshot can be uniquely identified by the image_id. -- Contains a link to the container disk (image_group). * Introduce a support for deleting a disk snapshot from storage domain: - DELETE /api/storagedomains/{storage_id}/disksnapshots/{image_id} Change-Id: I5359c5df490c7e7e6f9b4d25e794bd07c6877339 Feature-Page: http://www.ovirt.org/Features/Snapshots_Overview Signed-off-by: Daniel Erez <derez(a)redhat.com> --- A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/DiskSnapshotResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/DiskSnapshotsResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StorageDomainResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDiskSnapshotResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDiskSnapshotsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDiskSnapshotResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDiskSnapshotsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResourceTest.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskSnapshotMapper.java A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/DiskSnapshotMapperTest.java 16 files changed, 499 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26730 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5359c5df490c7e7e6f9b4d25e794bd07c6877339 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: rest: delete a disk from disks collection of a snapshot
by derez＠redhat.com 12 May '14

12 May '14

Daniel Erez has submitted this change and it was merged. Change subject: rest: delete a disk from disks collection of a snapshot ...................................................................... rest: delete a disk from disks collection of a snapshot Introduce a support for deleting a specific disk from a snapshot: DELETE /api/vms/{vm_id}/snapshots/{snapshot_id}/disks/{disk_id} Change-Id: Ic7fb780516ba715d87e59e98651e9d03dad15845 Feature-Page: http://www.ovirt.org/Features/Snapshots_Overview Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/SnapshotDisksResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotCdRomsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotDiskResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotDisksResource.java D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotElementsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotNicsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java 9 files changed, 98 insertions(+), 25 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26328 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7fb780516ba715d87e59e98651e9d03dad15845 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: AsyncTaskType enum - added downloadImage
by derez＠redhat.com 12 May '14

12 May '14

Daniel Erez has submitted this change and it was merged. Change subject: core: AsyncTaskType enum - added downloadImage ...................................................................... core: AsyncTaskType enum - added downloadImage Added downloadImage to AsyncTaskType enum in order to construct CommandAsyncTask instead of SPMAsyncTask (determined at AsyncTaskFactory -> construct method). Change-Id: I2c999b5b4426cf9b58691f2a1ee1c247a152ed7c Bug-Url: https://bugzilla.redhat.com/1074311 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/AsyncTaskType.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved Yair Zaslavsky: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27495 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c999b5b4426cf9b58691f2a1ee1c247a152ed7c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: LUNs table - prevent focus on margin click
by derez＠redhat.com 12 May '14

12 May '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: LUNs table - prevent focus on margin click ...................................................................... webadmin: LUNs table - prevent focus on margin click AbstractSanStorageList: LUNs table tree leaf - use marginLeft instead of paddingLeft to prevent focus when clicking the margin. Change-Id: Iaca0e7a6a3600cb955add272caf5e87696ee457f Bug-Url: https://bugzilla.redhat.com/856940 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageList.java 1 file changed, 17 insertions(+), 9 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27440 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaca0e7a6a3600cb955add272caf5e87696ee457f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: StorageView tabs - remove redundant right border
by derez＠redhat.com 12 May '14

12 May '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: StorageView tabs - remove redundant right border ...................................................................... webadmin: StorageView tabs - remove redundant right border IscsiStorageView.ui.xml: Removed redundant right border (has been added horizontal tabs). Screenshot-of-defect: http://imgur.com/OiHMJ6t Change-Id: Id8756d2f5538385d6f1092f76327dd0ff95ca417 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.ui.xml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/27346 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8756d2f5538385d6f1092f76327dd0ff95ca417 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: StorageView tabs - disable highlight in chrome
by derez＠redhat.com 12 May '14

12 May '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: StorageView tabs - disable highlight in chrome ...................................................................... webadmin: StorageView tabs - disable highlight in chrome IscsiStorageView.ui.xml: Added 'outline: none' to the tabs to disable highlight in chrome. Screenshot-of-defect: http://imgur.com/XUl7ZTl Change-Id: I82e10323e555ce368f9dc21261a971e392dd3f13 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.ui.xml 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/27345 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82e10323e555ce368f9dc21261a971e392dd3f13 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0