- Engine-commits - oVirt List Archives

Change in ovirt-dwh[ovirt-engine-3.4]: packaging: setup: pep8 fixes
by ydary＠redhat.com 11 May '14

11 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: pep8 fixes ...................................................................... packaging: setup: pep8 fixes Change-Id: Idba85ca5e2183967462b2b35f978e2f9a1529b10 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/schema.py 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27530 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idba85ca5e2183967462b2b35f978e2f9a1529b10 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Improve VM interface explanatory text
by lvernia＠redhat.com 11 May '14

11 May '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Improve VM interface explanatory text ...................................................................... webadmin: Improve VM interface explanatory text Changed the text to conform with the changes to the widget. Change-Id: I79d0d3d62f48c1d56292e65f5087a7a7100e118a Bug-Url: https://bugzilla.redhat.com/1032513 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 5 files changed, 11 insertions(+), 49 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25004 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79d0d3d62f48c1d56292e65f5087a7a7100e118a Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Disable clusters incompatible with external networks
by lvernia＠redhat.com 11 May '14

11 May '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Disable clusters incompatible with external networks ...................................................................... webadmin: Disable clusters incompatible with external networks Since it is impossible to attach an external network to a cluster that doesn't support it, it should be reflected in the GUI. While I was at it, also filtered out non-supporting clusters when importing networks from provider. Change-Id: Ida15ca4b63e894ab28f456fdd7e263405d6c679b Bug-Url: https://bugzilla.redhat.com/1049243 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java 4 files changed, 27 insertions(+), 5 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26842 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida15ca4b63e894ab28f456fdd7e263405d6c679b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Properly parameterize cluster ListModel
by lvernia＠redhat.com 11 May '14

11 May '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Properly parameterize cluster ListModel ...................................................................... webadmin: Properly parameterize cluster ListModel Parameterized the now-generic ListModel containing clusters in NewNetworkModel, as well as the corresponding objects in the view (which enabled to remove a few castings). Change-Id: I1fedd156dc3a8e6d6defcf9260a3c66b6f9281db Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/datacenter/NewNetworkPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/NewNetworkPopupView.java 4 files changed, 29 insertions(+), 34 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26841 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1fedd156dc3a8e6d6defcf9260a3c66b6f9281db Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Password field is not validate on host install
by oourfali＠redhat.com 11 May '14

11 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Password field is not validate on host install ...................................................................... webadmin: Password field is not validate on host install When the host is reinstalled and the password is choosen as authntication mechanism, empty password should display an error. If the user is on Network tab the general tab is selected and the field is highlighted in red indicating that it can't be empty. Change-Id: I3745852a0b1b33e5ba04583e911bbbc90fd8d796 Bug-Url: https://bugzilla.redhat.com/1086798 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/InstallModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInstallPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInstallPopupView.ui.xml 4 files changed, 45 insertions(+), 2 deletions(-) Approvals: Ravi Nori: Verified Gilad Chaplik: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27324 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3745852a0b1b33e5ba04583e911bbbc90fd8d796 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Adding a down event for HA Reservation
by oourfali＠redhat.com 11 May '14

11 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Adding a down event for HA Reservation ...................................................................... engine: Adding a down event for HA Reservation Adding a down event to HA Reservation, this event will be triggered only in case the current status of the Cluster was changed from not HA safe to HA safe. This is done to ensure that the user is notified that his action (freeing resources) have made the Cluster HA safe. Change-Id: Iebc82d3cc190d439b77e45e7e6b3eb7451f71c3c Bug-Url: https://bugzilla.redhat.com/1076211 Signed-off-by: Kobi Ianko <kobi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 6 files changed, 27 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Looks good to me, approved Kobi Ianko: Verified -- To view, visit http://gerrit.ovirt.org/27471 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iebc82d3cc190d439b77e45e7e6b3eb7451f71c3c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: host-deploy: prepare upgrade to apache-sshd 0.11.0
by oourfali＠redhat.com 11 May '14

11 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: host-deploy: prepare upgrade to apache-sshd 0.11.0 ...................................................................... host-deploy: prepare upgrade to apache-sshd 0.11.0 since 3.1 we use internal implementation of KeyPairProvider which was changed in future releases, in order to make transition easier drop the internal implementation in favour of super interface. required subset of I6943590f1c without implications. Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1094123 Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1093882 Change-Id: I6943590f1c479e71633dcce1180028e06c9a9a17 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/SSHD.java 1 file changed, 19 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27549 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6943590f1c479e71633dcce1180028e06c9a9a17 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4.1]: backend: upgrade - process symbolic link files
by oourfali＠redhat.com 11 May '14

11 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: backend: upgrade - process symbolic link files ...................................................................... backend: upgrade - process symbolic link files Currently if users decided to upgrade the ovirt-node via restapi using the symbolic link name ovirt-node-iso.iso it will fail. This patch adds getCanonicalPath() call to resolves the symbolic links. Change-Id: If4084095c40848dc5573d434c1c7ca497883b280 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1093303 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java 1 file changed, 22 insertions(+), 9 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Douglas Schilling Landgraf: Verified Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27467 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4084095c40848dc5573d434c1c7ca497883b280 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: dwh: Update minimal ETL version
by sbonazzo＠redhat.com 09 May '14

09 May '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: dwh: Update minimal ETL version ...................................................................... dwh: Update minimal ETL version Needed following http://gerrit.ovirt.org/26992 Change-Id: I5757f1d349fad82cd7f5b3371814a725fb443e0e Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yaniv Dary: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27337 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5757f1d349fad82cd7f5b3371814a725fb443e0e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Don't resurrect removed bonds for label
by oourfali＠redhat.com 09 May '14

09 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Don't resurrect removed bonds for label ...................................................................... engine: Don't resurrect removed bonds for label If a network was attached via label to a bond being removed, the operation would still be blocked by the CanDoAction, this is now fixed. Change-Id: Ie5c0648999a80c313f6565673e7880a2b34f3e53 Bug-Url: https://bugzilla.redhat.com/1084771 Bug-Url: https://bugzilla.redhat.com/1084915 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> (cherry picked from commit 433fa09c87eb88d6d5e187f25d7a2dd1e9cb4c35) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Lior Vernia: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27029 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5c0648999a80c313f6565673e7880a2b34f3e53 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0