- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: aaa: add authz namespace support
by yzaslavs＠redhat.com 12 May '14

12 May '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: add authz namespace support ...................................................................... aaa: add authz namespace support in an environment of large network as active directory forest we need a way to query subset of the content. the namespace will enable the provider to place partitions / domains into context to allow user interface to present selector. currently user interface does not support that, so we query all namespaces at server side. Topic: AAA Change-Id: I38968ae4b61aa8d0a5120a22a17e016cbe96c5e9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthz.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthz.java M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Authz.java 4 files changed, 53 insertions(+), 22 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27538 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38968ae4b61aa8d0a5120a22a17e016cbe96c5e9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: cleanup AuthzUtils
by yzaslavs＠redhat.com 12 May '14

12 May '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: cleanup AuthzUtils ...................................................................... aaa: cleanup AuthzUtils reorder parameters to be consistent. remove unneeded parameters. rename parameters and sync to better reflect meaning. Topic: AAA Change-Id: I4b833ca69531b6d8d6b554c3086d7e31c08ff544 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java 1 file changed, 7 insertions(+), 13 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27537 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b833ca69531b6d8d6b554c3086d7e31c08ff544 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Add CustomProperties member to HostNIC
by juan.hernandez＠redhat.com 12 May '14

12 May '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add CustomProperties member to HostNIC ...................................................................... restapi: Add CustomProperties member to HostNIC Added a new Properties member to HostNIC, as well as updated its mapper (and corresponding test class) to reflect it. Also updated the Setup Networks entry in rsdl_metadata.yaml to include the new argument. Change-Id: Ie1cd53d4e3fd0d2f0d7bec7f1a480679a31c6c8f Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostNicMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostNicMapperTest.java 5 files changed, 26 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26725 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1cd53d4e3fd0d2f0d7bec7f1a480679a31c6c8f Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Render CustomPropertiesUtils usable by frontend
by lvernia＠redhat.com 12 May '14

12 May '14

Lior Vernia has submitted this change and it was merged. Change subject: core: Render CustomPropertiesUtils usable by frontend ...................................................................... core: Render CustomPropertiesUtils usable by frontend Removed usage of Pattern/Matcher and of StringUtils where it wasn't necessary, as well as removed new generic instantiation syntax. Change-Id: I7926222061b88325ea0df35e39ad40ec8cce235d Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDeviceCustomPropertiesQuery.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/StringHelper.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/CustomPropertiesUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/DevicePropertiesUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/SimpleCustomPropertiesUtil.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/ValidationFailureReason.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/VmPropertiesUtils.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/customprop/CustomPropertiesUtilsTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/customprop/DevicePropertiesUtilsTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/customprop/PropertiesUtilsTestHelper.java 10 files changed, 82 insertions(+), 137 deletions(-) Approvals: Lior Vernia: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7926222061b88325ea0df35e39ad40ec8cce235d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add NEXT_RUN snapshot
by ofrenkel＠redhat.com 12 May '14

12 May '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: add NEXT_RUN snapshot ...................................................................... core: add NEXT_RUN snapshot Added new snapshot type to save only vm configuration for the vm next run. added also query to get vm from this configuration, and a field in vm to mark this configuration exists. Feature page: http://www.ovirt.org/Features/Edit_Running_VM Change-Id: I4d68f1d7a2de9e66854985583761f47d6db553bd Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmNextRunConfigurationQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Snapshot.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M packaging/dbscripts/create_views.sql M packaging/dbscripts/snapshots_sp.sql A packaging/dbscripts/upgrade/03_05_0400_index_for_snapshot_type.sql 10 files changed, 98 insertions(+), 6 deletions(-) Approvals: Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26757 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d68f1d7a2de9e66854985583761f47d6db553bd Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core, engine: Prevent memory snapshot in ppc64
by rgolan＠redhat.com 12 May '14

12 May '14

Roy Golan has submitted this change and it was merged. Change subject: core, engine: Prevent memory snapshot in ppc64 ...................................................................... core, engine: Prevent memory snapshot in ppc64 This change disables memory snapshot in the back end for clusters with architecture that doesn't support it. All logic was added in conjunction with the snapshot validation from the class FeatureSupported. Change-Id: I4f201b63ddf441a9bc76a37fda33f54fa766d937 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1061774 Signed-off-by: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Signed-off-by: Vitor de Lima <vitor.lima(a)eldorado.org.br> Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java 3 files changed, 19 insertions(+), 4 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved Vered Volansky: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/21657 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f201b63ddf441a9bc76a37fda33f54fa766d937 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: liron aravot <liron.aravot(a)gmail.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Mandatory "succeeded" for step end
by juan.hernandez＠redhat.com 12 May '14

12 May '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Mandatory "succeeded" for step end ...................................................................... restapi: Mandatory "succeeded" for step end The "succeeded" parameter is mandatory for the action to stop a job step. Change-Id: I55ccc732bce26f903275c280192ee83b225bc195 Bug-Url: https://bugzilla.redhat.com/1087916 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStepResource.java 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Looks good to me, approved Juan Hernandez: Verified -- To view, visit http://gerrit.ovirt.org/27520 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55ccc732bce26f903275c280192ee83b225bc195 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-cli[master]: cli: Don't write integer statistics as float
by juan.hernandez＠redhat.com 12 May '14

12 May '14

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Don't write integer statistics as float ...................................................................... cli: Don't write integer statistics as float Currently when we write a an statistic value that is declared to be integer we use the floating point representation used by default by Python. This happens because all the statistics are represented as as xs:decimal, regardless of their declared type, so the generateDS.py tool converts them to float. This has the inconvenient that integer types are displayed with a .0 suffix. For example: # show statistic memory.total --host-identifier myhost id : 7816602b-c05c-3db7-a4da-3769f7ad8896 name : memory.total description : Total memory host-id : d3560912-f2ad-11e1-8f5f-001a4a169798 type : GAUGE unit : BYTES values-type : INTEGER values-value-datum: 33658241024.0 This patch changes the CLI so that it will convert statistics declared as integer to Python long before rendering, so the .0 suffix will not be present. Change-Id: I21490ec50e3a7433331e981162de800c7d548f27 Bug-Url: https://bugzilla.redhat.com/855724 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtcli/format/text.py 1 file changed, 20 insertions(+), 8 deletions(-) Approvals: Michael Pasternak: Looks good to me, approved Juan Hernandez: Verified -- To view, visit http://gerrit.ovirt.org/26864 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21490ec50e3a7433331e981162de800c7d548f27 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Block changing a used label
by oourfali＠redhat.com 12 May '14

12 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Block changing a used label ...................................................................... engine: Block changing a used label Changing a used label isn't supported and should be blocked until it does. Change-Id: I473ff703c35be305abec7b78c44e983c58d4cb03 Bug-Url: https://bugzilla.redhat.com/1091714 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 1 file changed, 27 insertions(+), 5 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/27571 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I473ff703c35be305abec7b78c44e983c58d4cb03 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Fix NPE in edit network popup.
by lvernia＠redhat.com 12 May '14

12 May '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Fix NPE in edit network popup. ...................................................................... webadmin: Fix NPE in edit network popup. Set network.selectedItem for both HostManagementNetworkModel and HostInterfaceModel. Change-Id: I2188dd71037777eb0099d24e0d244589551986d5 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Lior Vernia: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/27565 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2188dd71037777eb0099d24e0d244589551986d5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0