- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine : Clear VM Poweroff/Shutdown reason when RunVmCommand...
by oourfali＠redhat.com 01 May '14

01 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine : Clear VM Poweroff/Shutdown reason when RunVmCommand succeeds ...................................................................... engine : Clear VM Poweroff/Shutdown reason when RunVmCommand succeeds Change the way the reason is cleared. When the RunVmCommand succeeds the reason for the previous shutdown is cleared. Change-Id: Ia1fcf297218295b8cae9e5652e32a1351b0ac9e7 Bug-Url: https://bugzilla.redhat.com/1065753 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27299 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1fcf297218295b8cae9e5652e32a1351b0ac9e7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: fix commit snapshot flow on active vm commit
by derez＠redhat.com 01 May '14

01 May '14

Daniel Erez has submitted this change and it was merged. Change subject: core: fix commit snapshot flow on active vm commit ...................................................................... core: fix commit snapshot flow on active vm commit * RestoreAllSnapshotsCommand -> getSnapshot method: - COMMIT branch: get IN_PREVIEW snapshot by status. * SnapshotDao: - Added a new getter for fetching snapshots only by status. * snapshot_sp.sql: - Added GetSnapshotByVmIdAndStatus stored procedure. Change-Id: Ib27d225b7bf584f1d0c6e2861e91403ba205f087 Bug-Url: https://bugzilla.redhat.com/1093047 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RestoreAllSnapshotCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/SnapshotDaoTest.java M packaging/dbscripts/snapshots_sp.sql 6 files changed, 51 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27291 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib27d225b7bf584f1d0c6e2861e91403ba205f087 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Update audit log message when storage is extended.
by mlipchuk＠redhat.com 01 May '14

01 May '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Update audit log message when storage is extended. ...................................................................... core: Update audit log message when storage is extended. Update the audit log to indicate that the update of the total size and free size for the Storage Domain, might take a few moments. The reason that the operation of extend might suffer from latency issues is that the mechanism of the storage size is depended on different asynchronous operations, such as domain monitor in VDSM, IrsBroker in the engine, and query for storage domains in the GUI main tab. Change-Id: Id903df200a3325dc1a741d0b543e2cb9466f8a4d Bug-Url: https://bugzilla.redhat.com/1075515 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27286 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id903df200a3325dc1a741d0b543e2cb9466f8a4d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4.1]: core: db fix event renaming upgrade script.
by oourfali＠redhat.com 01 May '14

01 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: db fix event renaming upgrade script. ...................................................................... core: db fix event renaming upgrade script. db upgrade fails if there's a subscription to VDS_HIGH_NETWORK_USE event Original upgrade script renamed an event without taking in account that it may be used by subscribers. This patch updates both event_map and event_sunscriber tables with the renamed event, in order to do that we need to remove the FK before the update and adding it back again after the update is finished. Change-Id: I3ac7f33fad30aba5cc459ec05dc990a60bbc65e0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1093283 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/dbscripts/upgrade/03_04_0720_add_host_interface_high_network_use_event.sql 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27293 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ac7f33fad30aba5cc459ec05dc990a60bbc65e0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4.1 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: db fix event renaming upgrade script.
by oourfali＠redhat.com 01 May '14

01 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: db fix event renaming upgrade script. ...................................................................... core: db fix event renaming upgrade script. db upgrade fails if there's a subscription to VDS_HIGH_NETWORK_USE event Original upgrade script renamed an event without taking in account that it may be used by subscribers. This patch updates both event_map and event_sunscriber tables with the renamed event, in order to do that we need to remove the FK before the update and adding it back again after the update is finished. Change-Id: I3ac7f33fad30aba5cc459ec05dc990a60bbc65e0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1093283 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/dbscripts/upgrade/03_04_0720_add_host_interface_high_network_use_event.sql 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27292 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ac7f33fad30aba5cc459ec05dc990a60bbc65e0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: coverity: Fix INVALIDATE_ITERATOR warning in SessionDataCont...
by yzaslavs＠redhat.com 01 May '14

01 May '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: coverity: Fix INVALIDATE_ITERATOR warning in SessionDataContainer ...................................................................... coverity: Fix INVALIDATE_ITERATOR warning in SessionDataContainer Altering a collection while iterating over it with a for loop will most likely cause ConcurrentModificationException, using an iterator instead Change-Id: I223c41e0ad0c091532e598f281f0679306f1164c Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/session/SessionDataContainer.java 1 file changed, 5 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27275 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I223c41e0ad0c091532e598f281f0679306f1164c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: db fix event renaming upgrade script.
by oourfali＠redhat.com 01 May '14

01 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: db fix event renaming upgrade script. ...................................................................... core: db fix event renaming upgrade script. db upgrade fails if there's a subscription to VDS_HIGH_NETWORK_USE event Original upgrade script renamed an event without taking in account that it may be used by subscribers. This patch updates both event_map and event_sunscriber tables with the renamed event, in order to do that we need to remove the FK before the update and adding it back again after the update is finished. Change-Id: I3ac7f33fad30aba5cc459ec05dc990a60bbc65e0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1093283 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/dbscripts/upgrade/03_05_0160_add_host_interface_high_network_use_event.sql 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified Ohad Basan: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27287 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ac7f33fad30aba5cc459ec05dc990a60bbc65e0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4.1]: core: Activate host doesn't set return value
by oourfali＠redhat.com 01 May '14

01 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Activate host doesn't set return value ...................................................................... core: Activate host doesn't set return value ActivateVds defacto works but doesn't set the return value to true, which result REST calls to believe it failed. Change-Id: Id6802431ebc4239e46ab7df30355e18ebf368e86 Bug-Url: https://bugzilla.redhat.com/1077300 Signed-off-by: Roy Golan <rgolan(a)redhat.com> (cherry picked from commit 977a612194013378bc4868f44f9b1ab5170a2453) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27259 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6802431ebc4239e46ab7df30355e18ebf368e86 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4.1 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: reports: br2c report - added comments to queries
by ydary＠redhat.com 01 May '14

01 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: br2c report - added comments to queries ...................................................................... reports: br2c report - added comments to queries Changed the code structure so it will be more readable and added commets. Change-Id: I82104ef88054a831cdac46ab9f67c200fb499956 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/Reports/Trend/Hosts/single_host_resource_usage_hour_of_day_br2c_files/br2 full details.jrxml.data M packaging/ovirt-reports/resources/Reports/Trend/Hosts/single_host_resource_usage_hour_of_day_br2c_files/single_host_resource_usage_hour_of_day_br2c_jrxml.data 2 files changed, 1,297 insertions(+), 933 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26486 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82104ef88054a831cdac46ab9f67c200fb499956 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: reports: br2b report - added comments to queries
by ydary＠redhat.com 01 May '14

01 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: br2b report - added comments to queries ...................................................................... reports: br2b report - added comments to queries Changed the code structure so it will be more readable and added commets. Change-Id: Ibccaba25b0ffefd7d24fd8b446bb1f74caff9296 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/Reports/Trend/Hosts/single_host_resource_usage_dow_br2b_files/br2 full details.jrxml.data M packaging/ovirt-reports/resources/Reports/Trend/Hosts/single_host_resource_usage_dow_br2b_files/single_host_resource_usage_dow_br2b.data 2 files changed, 1,258 insertions(+), 928 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibccaba25b0ffefd7d24fd8b446bb1f74caff9296 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0