- Engine-commits - oVirt List Archives

Change in ovirt-dwh[master]: packaging: spec: update source url
by ydary＠redhat.com 04 May '14

04 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: spec: update source url ...................................................................... packaging: spec: update source url Change-Id: Idbf46dfa84979b10b7bc5beac3d301a85ea6999d Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine-dwh.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27352 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbf46dfa84979b10b7bc5beac3d301a85ea6999d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: spec: update source url
by ydary＠redhat.com 04 May '14

04 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: spec: update source url ...................................................................... packaging: spec: update source url Change-Id: I13d82922e36e573476a797f0327c4ee699a8916a Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine-reports.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27351 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13d82922e36e573476a797f0327c4ee699a8916a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Add gateway & DNS servers columns
by mkolesni＠redhat.com 04 May '14

04 May '14

Mike Kolesnik has submitted this change and it was merged. Change subject: webadmin: Add gateway & DNS servers columns ...................................................................... webadmin: Add gateway & DNS servers columns Added the columns to the external subnet sub-tab under a network, in order to reflect to the user what are the current settings of these fields. Change-Id: I794ee197f31ef89f51f27074d5a8f2a1ca5e51d6 Bug-Url: https://bugzilla.redhat.com/1064749 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkExternalSubnetView.java 1 file changed, 26 insertions(+), 5 deletions(-) Approvals: Mike Kolesnik: Verified Alona Kaplan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25360 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I794ee197f31ef89f51f27074d5a8f2a1ca5e51d6 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Add gateway & DNS servers fields
by mkolesni＠redhat.com 04 May '14

04 May '14

Mike Kolesnik has submitted this change and it was merged. Change subject: webadmin: Add gateway & DNS servers fields ...................................................................... webadmin: Add gateway & DNS servers fields Added the fields to external subnet creation flows to allow users to specify these values when creating a subnet. Change-Id: I8c958328e769badebe2d95359d3ae81e657205c2 Bug-Url: https://bugzilla.redhat.com/1064749 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ExternalSubnetModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ExternalSubnetPopupView.ui.xml A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/DnsServerEditor.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/DnsServersWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/DnsServersWidget.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/ExternalSubnetWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/ExternalSubnetWidget.ui.xml 8 files changed, 229 insertions(+), 4 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c958328e769badebe2d95359d3ae81e657205c2 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Extract external subnet model & widget
by mkolesni＠redhat.com 04 May '14

04 May '14

Mike Kolesnik has submitted this change and it was merged. Change subject: webadmin: Extract external subnet model & widget ...................................................................... webadmin: Extract external subnet model & widget Extracted the representation & functionality of external subnet to a model & widget in order to facilitate code reuse and DRY. Change-Id: I2d9c34a1ceb8c92e8ff813301186a2f5c9f499b4 Related-To: https://bugzilla.redhat.com/1064749 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ExternalSubnetModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/NewExternalSubnetModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ExternalSubnetPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ExternalSubnetPopupView.ui.xml A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/ExternalSubnetWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/ExternalSubnetWidget.ui.xml 12 files changed, 267 insertions(+), 152 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25358 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d9c34a1ceb8c92e8ff813301186a2f5c9f499b4 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Add StringUtils.is{, Not}Empty
by mkolesni＠redhat.com 04 May '14

04 May '14

Mike Kolesnik has submitted this change and it was merged. Change subject: webadmin: Add StringUtils.is{,Not}Empty ...................................................................... webadmin: Add StringUtils.is{,Not}Empty Methods added to the extrenal class until StringUtils is supported normally. Change-Id: Ia26668e73a42523f412b07ca3bcc8ca0578aa550 Related-To: https://bugzilla.redhat.com/1064749 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/StringUtils.java 1 file changed, 48 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified Alona Kaplan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia26668e73a42523f412b07ca3bcc8ca0578aa550 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Added fields to subnet
by mkolesni＠redhat.com 04 May '14

04 May '14

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Added fields to subnet ...................................................................... engine: Added fields to subnet Added gateway and DNS servers list to the ExternalSubnet entity in order to allow the users to set these fields. Change-Id: I1b3718b83bcfb588eb97a55ba559d5407b857955 Bug-Url: https://bugzilla.redhat.com/1064749 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/ExternalSubnet.java 2 files changed, 45 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25357 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b3718b83bcfb588eb97a55ba559d5407b857955 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Change OpenStack SDK version
by mkolesni＠redhat.com 04 May '14

04 May '14

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Change OpenStack SDK version ...................................................................... engine: Change OpenStack SDK version Subnet creation code updated to use the non-deprecated entities. Also marking subnet explicitly as DHCP to make sure it will be used. Change-Id: I148e6efa3edc9adbae52778fd8e1aed34e03da90 Related-To: https://bugzilla.redhat.com/1064749 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java M pom.xml 2 files changed, 5 insertions(+), 4 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I148e6efa3edc9adbae52778fd8e1aed34e03da90 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: SuperUser of DataCenter X cannot approve a host under ...
by oourfali＠redhat.com 04 May '14

04 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: SuperUser of DataCenter X cannot approve a host under this Data Center ...................................................................... core: SuperUser of DataCenter X cannot approve a host under this Data Center This patch address the issue above, where you need the following permissions when approving a host, each from another command that is run in this flow: 1. ChangeVdsCluster (as we change the cluster) - checks for EDIT_HOST_CONFIGURATION action group both on the host, and the destination cluster 2. UpdateVds (as we can edit other stuff as well) - checks for EDIT_HOST_CONFIGURATION action group on the host 3. ApproveVdsCommand - checks for CREATE_HOST action group on the host itself, the cluster, the DC, or System (as I wrote above). This patch changes the requirement in #1 to include EDIT_HOST_CONFIGURATION on the host only if the host is NOT in a PendingApproval state, as in the PendingApproval state there might not be any permissions on the host, as the host is in the Default Cluster, and the user might not have permissions on it. Change-Id: Ia59a51e4e3ebf184e0672a077b6dc0d16e60eb8e Bug-Url: https://bugzilla.redhat.com/1090660 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia59a51e4e3ebf184e0672a077b6dc0d16e60eb8e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: unknown host name when listing jobs
by oourfali＠redhat.com 04 May '14

04 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: unknown host name when listing jobs ...................................................................... core: unknown host name when listing jobs Change-Id: I3754902fdf9e9bdb5de0f6797901adbae6792ee1 Bug-Url: https://bugzilla.redhat.com/1055710 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmToServerCommand.java 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27342 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3754902fdf9e9bdb5de0f6797901adbae6792ee1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0