- Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk[sdk_4.1]: Add create template example
by Code Review 10 Apr '17

10 Apr '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add create template example ...................................................................... Add create template example This patch adds an example that shows how to add a template with customized disk format. Change-Id: I19b9a0c91b4a611c6377a19871d077ee152c31e1 Related-to: https://bugzilla.redhat.com/1425295 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 944dfb17cfb5a4d2e25f4b0ff25e6a5555de78d1) --- A sdk/examples/add_template.py 1 file changed, 93 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19b9a0c91b4a611c6377a19871d077ee152c31e1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Add create template example
by Code Review 10 Apr '17

10 Apr '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add create template example ...................................................................... Add create template example This patch adds an example that shows how to add a template with customized disk format. Change-Id: Ie772d22acaa674b58e4d8eb4ac3e4aec8abd6503 Related-to: https://bugzilla.redhat.com/1425295 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddTemplate.java 1 file changed, 112 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75227 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie772d22acaa674b58e4d8eb4ac3e4aec8abd6503 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Germano Veit Michel <germano(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Add create template example
by Code Review 10 Apr '17

10 Apr '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add create template example ...................................................................... Add create template example This patch adds an example that shows how to add a template with customized disk format. Change-Id: I19b9a0c91b4a611c6377a19871d077ee152c31e1 Related-to: https://bugzilla.redhat.com/1425295 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/examples/add_template.py 1 file changed, 93 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75220 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19b9a0c91b4a611c6377a19871d077ee152c31e1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Germano Veit Michel <germano(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Don't run findbugs on generated code
by Code Review 10 Apr '17

10 Apr '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Don't run findbugs on generated code ...................................................................... restapi: Don't run findbugs on generated code The recent update of the version of the metamodel introduced generation of resource helpers. Findbugs detects some potential issues in these classes that we don't want to address at this point. This patch changes the findbugs filters so that these classes are ignored. Change-Id: Id692c318b74667f73793717fe0410c2f84abda29 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/exclude-filters.xml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/75399 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id692c318b74667f73793717fe0410c2f84abda29 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Update to model 4.2.9 and metamodel 1.2.5
by Code Review 10 Apr '17

10 Apr '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Update to model 4.2.9 and metamodel 1.2.5 ...................................................................... restapi: Update to model 4.2.9 and metamodel 1.2.5 The more relevant changes in this new version of the model are the following: * Replace generic assigned networks services with services specific to the type of object that they are assigned to, in particular data centers and clusters. * Add `driver` attribute to `HostDevice` type. * Add specification of input details. * Add common concepts document. * Add appendix containing changes from version 3 to version 4 of the API. * Update to metamodel 1.2.5 to handle correctly `or` and `COLLECTION` in the specification of input details. The replacement of generic assigned networks service with specific ones requires a significant refactor of the resources in that area. The more relevant change in the new version of the metamodel is the introduction of constraints for input parameters of methods. This results in autogenerated code that performs validation and selection of the correct version of a method according to the input parameters. Change-Id: Ibef405d6f19330f61cb5ec7193c860557fcfb47b Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworkResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterNetworkResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterNetworksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/LinkHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3NICHelper.java R backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3ClusterNetworkServer.java R backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3ClusterNetworksServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3ClusterServer.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3DataCenterNetworkServer.java C backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3DataCenterNetworksServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3DataCenterServer.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterNetworksResourceTest.java M pom.xml 16 files changed, 195 insertions(+), 46 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75297 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibef405d6f19330f61cb5ec7193c860557fcfb47b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: engine: Add missing event for Host Cert Expiration
by Code Review 09 Apr '17

09 Apr '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: engine: Add missing event for Host Cert Expiration ...................................................................... engine: Add missing event for Host Cert Expiration Change-Id: Ic2d445b0c4dab860b5ee1cb8a84bd4f133490420 Bug-Url: https://bugzilla.redhat.com/1439509 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/75354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2d445b0c4dab860b5ee1cb8a84bd4f133490420 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove static VmDevicesMonitoring instance
by Code Review 09 Apr '17

09 Apr '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: Remove static VmDevicesMonitoring instance ...................................................................... core: Remove static VmDevicesMonitoring instance Replaced error prone access of global static instance of VmsDevicesMonitoring (facilitated by manual loading of BackendService in correct order in the Backend initialization) with proper lazy CDI dependency resolution. Change-Id: Ib16d56e7423130da404aa77d2158cd9f5ed5b90b Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoring.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmStatsRefresher.java 3 files changed, 7 insertions(+), 19 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/75049 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib16d56e7423130da404aa77d2158cd9f5ed5b90b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove static instance of VmsMonitoring
by Code Review 09 Apr '17

09 Apr '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: Remove static instance of VmsMonitoring ...................................................................... core: Remove static instance of VmsMonitoring Replaced error prone access of global static instance of VmsMonitoring (facilitated by manual loading of BackendService in correct order in the Backend initialization) with proper lazy CDI dependency resolution. Change-Id: Ia0089d75eea3a59368e2b1684371f51d658dc216 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmStatsRefresher.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java 3 files changed, 5 insertions(+), 22 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Allon Mureinik: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/75048 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0089d75eea3a59368e2b1684371f51d658dc216 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Initialize SparsifyImageCommand#vmsForDisk
by Code Review 09 Apr '17

09 Apr '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Initialize SparsifyImageCommand#vmsForDisk ...................................................................... core: Initialize SparsifyImageCommand#vmsForDisk Initialize SparsifyImageCommand#vmsForDisk field on demand. Previously this field was always initialized to an empty list which caused SparsifyImageCommand to ignore status of VMs the disk is attached to and to fail to lock these VMs. Change-Id: I3d87eb858d144de2f4e855709b8638c783ed5640 Bug-Url: https://bugzilla.redhat.com/1431596 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/SparsifyImageCommand.java 1 file changed, 17 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/75364 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d87eb858d144de2f4e855709b8638c783ed5640 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: NPE when sparsifying a non-attached disk
by Code Review 09 Apr '17

09 Apr '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: NPE when sparsifying a non-attached disk ...................................................................... core: NPE when sparsifying a non-attached disk Fix an NPE that occured when SparsifyImageCommand is called on a disk that is not attached to any VM. Change-Id: Ia77ff88be9705ecce5080769bbf29861c4a89d4d Bug-Url: https://bugzilla.redhat.com/1431596 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/SparsifyImageCommand.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/75366 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia77ff88be9705ecce5080769bbf29861c4a89d4d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0