- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: refactoring: Inject Async Operation dependencies
by Code Review 08 Apr '17

08 Apr '17

>From Martin Betak <mbetak(a)redhat.com>: Martin Betak has submitted this change and it was merged. Change subject: core: refactoring: Inject Async Operation dependencies ...................................................................... core: refactoring: Inject Async Operation dependencies Change-Id: I4f0bc5db607d58dd790dca14172e8bb4c75963d0 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AfterDeactivateSingleAsyncOperation.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AfterDeactivateSingleAsyncOperationFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/ConntectVDSToPoolAndDomains.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/DisconnectStoragePoolAsyncOperation.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/DisconnectStoragePoolAsyncOperationFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RefreshPoolSingleAsyncOperation.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RefreshStoragePoolAndDisconnectAsyncOperation.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RefreshStoragePoolAndDisconnectAsyncOperationFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RemoveStoragePoolCommand.java 9 files changed, 111 insertions(+), 41 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/74779 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f0bc5db607d58dd790dca14172e8bb4c75963d0 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Add .checkstyle to .gitignore
by Code Review 08 Apr '17

08 Apr '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: engine: Add .checkstyle to .gitignore ...................................................................... engine: Add .checkstyle to .gitignore .checkstyle files are generated by Eclipse Checkstyle plugin and should be ignored. Change-Id: I1ae6045a8c0bc61b3ce757a32d610dbc97563f9a Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M .gitignore 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alexander Wels: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Greg Sheremeta: Looks good to me, but someone else must approve Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/75219 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ae6045a8c0bc61b3ce757a32d610dbc97563f9a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1.1.z]: engine: Ensure snapshot deletion after geo-rep sync
by Code Review 08 Apr '17

08 Apr '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: Ensure snapshot deletion after geo-rep sync ...................................................................... engine: Ensure snapshot deletion after geo-rep sync The temp snapshots created prior to geo-rep should only be deleted once the geo-rep checkpoint completes. setting parentParameters to ensure that command is marked completed only when callback completes Change-Id: I589bdf269c6d0b44a977a6b9f94de43072c49317 iBug-Url: https://bugzilla.redhat.com/1437865 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/dr/GlusterStorageSyncCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Jenkins CI: Passed CI tests Sahina Bose: Verified -- To view, visit https://gerrit.ovirt.org/75324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I589bdf269c6d0b44a977a6b9f94de43072c49317 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1.1.z Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.1]: Add create template example
by Code Review 07 Apr '17

07 Apr '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add create template example ...................................................................... Add create template example This patch adds an example that shows how to add a template with customized disk format. Change-Id: Iee5377b2ee1bab1380e88f5de45de0206353cd6c Related-To: https://bugzilla.redhat.com/1425295 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 79aea470ff22706d2679572094a68874ad846201) --- A sdk/examples/add_template.rb 1 file changed, 79 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75344 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee5377b2ee1bab1380e88f5de45de0206353cd6c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add create template example
by Code Review 07 Apr '17

07 Apr '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add create template example ...................................................................... Add create template example This patch adds an example that shows how to add a template with customized disk format. Change-Id: Iee5377b2ee1bab1380e88f5de45de0206353cd6c Related-To: https://bugzilla.redhat.com/1425295 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/examples/add_template.rb 1 file changed, 79 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75225 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee5377b2ee1bab1380e88f5de45de0206353cd6c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Germano Veit Michel <germano(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.1]: Use [ and ] to delimit %i and %w lists
by Code Review 07 Apr '17

07 Apr '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Use [ and ] to delimit %i and %w lists ...................................................................... Use [ and ] to delimit %i and %w lists To make Rubocop happy. Change-Id: I9c253e1efefaead5fcb9b642322ae04f8466f749 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit e402de75fdb26341c5d442c1086e910787f99053) --- M sdk/Rakefile M sdk/spec/xml_reader_spec.rb 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75342 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c253e1efefaead5fcb9b642322ae04f8466f749 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Use [ and ] to delimit %i and %w lists
by Code Review 07 Apr '17

07 Apr '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Use [ and ] to delimit %i and %w lists ...................................................................... Use [ and ] to delimit %i and %w lists To make Rubocop happy. Change-Id: I9c253e1efefaead5fcb9b642322ae04f8466f749 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/Rakefile M sdk/spec/xml_reader_spec.rb 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75224 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c253e1efefaead5fcb9b642322ae04f8466f749 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[master]: vdsm: software: Fix documentation string
by Code Review 07 Apr '17

07 Apr '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: vdsm: software: Fix documentation string ...................................................................... vdsm: software: Fix documentation string Just a very minor fix of the documentation strings to have a more beautiful impression of the code. Change-Id: I4c201808f90a6e3afa6005a5c7ef183e690a549a Signed-off-by: Dominik Holler <dholler(a)redhat.com> --- M src/plugins/ovirt-host-deploy/vdsm/software.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75330 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c201808f90a6e3afa6005a5c7ef183e690a549a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: remove injection into ALB in ExternalNetworkManager
by Code Review 07 Apr '17

07 Apr '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: remove injection into ALB in ExternalNetworkManager ...................................................................... engine: remove injection into ALB in ExternalNetworkManager Remove injection into AuditLogableBase in ExternalNetworkManager and add test coverage to the class. Change-Id: Ibae5e31e79b983772fe4fbe026735ad2a45a4f56 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/ExternalNetworkManager.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/ExternalNetworkManagerTest.java 2 files changed, 135 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/75286 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibae5e31e79b983772fe4fbe026735ad2a45a4f56 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Add missing event for Host Cert Expiration
by Code Review 07 Apr '17

07 Apr '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: Add missing event for Host Cert Expiration ...................................................................... engine: Add missing event for Host Cert Expiration Change-Id: Ic2d445b0c4dab860b5ee1cb8a84bd4f133490420 Bug-Url: https://bugzilla.redhat.com/1439509 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/75318 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2d445b0c4dab860b5ee1cb8a84bd4f133490420 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0