- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: core: adding missing default to a non-null column
by iheim＠redhat.com 05 Mar '14

05 Mar '14

Itamar Heim has submitted this change and it was merged. Change subject: core: adding missing default to a non-null column ...................................................................... core: adding missing default to a non-null column This patch fixes an issue in event_subscriber table that was added a notification_method column which does not allow nulls. If the table has any records before the upgrade, this will fail since the existing records will have NULL for the new added column. Change-Id: Id3c7ce30c32b9b38f08ff6c8c0eb8bfa02cf5066 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1072867 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/dbscripts/upgrade/03_04_0600_event_notification_methods.sql 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved mooli tayer: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25393 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3c7ce30c32b9b38f08ff6c8c0eb8bfa02cf5066 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Add room for long vNIC names
by lvernia＠redhat.com 05 Mar '14

05 Mar '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Add room for long vNIC names ...................................................................... webadmin: Add room for long vNIC names Increased the width of the label field, and redesigned the widgets around it to conform to the new width. Change-Id: I6f7d73632440d88e76c544a1aee754f47bdf8f21 Bug-Url: https://bugzilla.redhat.com/1029973 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.ui.xml 2 files changed, 23 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/25005 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f7d73632440d88e76c544a1aee754f47bdf8f21 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Configure Roles "DataCenterAdmin" Description is n...
by emesika＠redhat.com 05 Mar '14

05 Mar '14

Eli Mesika has submitted this change and it was merged. Change subject: webadmin: Configure Roles "DataCenterAdmin" Description is not fully show ...................................................................... webadmin: Configure Roles "DataCenterAdmin" Description is not fully show In Configure Roles window the description for DataCenterAdmin is too long and cut at the end. The window can not be enlarged so the user can not access the end of the description. Change-Id: I43cd143f1c353e788602863a5a94c2406e694456 Bug-Url: https://bugzilla.redhat.com/1070723 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/ConfigurePopupView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Ravi Nori: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25280 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43cd143f1c353e788602863a5a94c2406e694456 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi : ints and shorts overflow
by juan.hernandez＠redhat.com 05 Mar '14

05 Mar '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi : ints and shorts overflow ...................................................................... restapi : ints and shorts overflow int and short values are overflown[1] before they even reach the business code, allowing for wrong values to be set. Handles the case where negative values are passed for unsignedInt and unsignedShort Change-Id: I40115f1938a6263317d77ae2be0618d905e29664 Bug-Url: https://bugzilla.redhat.com/1000796 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/IntegerParser.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Ravi Nori: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40115f1938a6263317d77ae2be0618d905e29664 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Remove confusing coloring in VM interfaces widget
by lvernia＠redhat.com 05 Mar '14

05 Mar '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Remove confusing coloring in VM interfaces widget ...................................................................... webadmin: Remove confusing coloring in VM interfaces widget The gray color led people to believe the widget was disabled, so changed it to black. Change-Id: I2ffcf14f55b6b14ee62adde63987a2a3bae3cd6c Bug-Url: https://bugzilla.redhat.com/1064431 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.ui.xml 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/24994 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ffcf14f55b6b14ee62adde63987a2a3bae3cd6c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Enable vertical scrolling in bond dialog
by lvernia＠redhat.com 05 Mar '14

05 Mar '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Enable vertical scrolling in bond dialog ...................................................................... webadmin: Enable vertical scrolling in bond dialog This is required since the addition of labels, of which many could exist. Change-Id: I54ae2350eeb1dc23b222915f99df8f15882c67ae Bug-Url: https://bugzilla.redhat.com/1063852 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelEditor.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksBondPopupView.java 4 files changed, 5 insertions(+), 5 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/25012 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54ae2350eeb1dc23b222915f99df8f15882c67ae Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: packaging: setup: database: move connect to database library
by ydary＠redhat.com 05 Mar '14

05 Mar '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: database: move connect to database library ...................................................................... packaging: setup: database: move connect to database library this will enable use of single tweaks for different driver versions. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1067058 Change-Id: I17224df000a8c4457c8fa26d6f0131ef8e3867ed Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/connection.py 1 file changed, 4 insertions(+), 13 deletions(-) Approvals: Alon Bar-Lev: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25335 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17224df000a8c4457c8fa26d6f0131ef8e3867ed Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: setup: database: suppress password based on env key
by ydary＠redhat.com 05 Mar '14

05 Mar '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: database: suppress password based on env key ...................................................................... packaging: setup: database: suppress password based on env key Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1072476 Change-Id: Ia4d1ad9b0acda23a59f55d1653a542c9ea038754 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/connection.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/connection.py 2 files changed, 1 insertion(+), 7 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25362 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4d1ad9b0acda23a59f55d1653a542c9ea038754 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[master]: packaging: setup: database: suppress password based on env key
by ydary＠redhat.com 05 Mar '14

05 Mar '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: database: suppress password based on env key ...................................................................... packaging: setup: database: suppress password based on env key Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1072476 Change-Id: Ia4d1ad9b0acda23a59f55d1653a542c9ea038754 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/db/connection.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/admin.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/db/connection.py 3 files changed, 16 insertions(+), 14 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4d1ad9b0acda23a59f55d1653a542c9ea038754 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[master]: packaging: setup: database: move connect to database library
by ydary＠redhat.com 05 Mar '14

05 Mar '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: database: move connect to database library ...................................................................... packaging: setup: database: move connect to database library this will enable use of single tweaks for different driver versions. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1067058 Change-Id: I7e6abd911d10013fcbb904254762d90a125078e8 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/db/connection.py 1 file changed, 4 insertions(+), 13 deletions(-) Approvals: Alon Bar-Lev: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e6abd911d10013fcbb904254762d90a125078e8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0