- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Added check to prevent no-op case
by lvernia＠redhat.com 05 Mar '14

05 Mar '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Added check to prevent no-op case ...................................................................... webadmin: Added check to prevent no-op case Adding a NIC to the bond already containing it wasn't marked as a no-op so it was displayed as a legitimate operation. Change-Id: Iebff9f9e3b5cd9973cfbebe307ae75a2e5d96a67 Bug-Url: https://bugzilla.redhat.com/1045656 Bug-Url: https://bugzilla.redhat.com/1045658 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationFactory.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/24993 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iebff9f9e3b5cd9973cfbebe307ae75a2e5d96a67 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: libvirt and system PKI
by sbonazzo＠redhat.com 05 Mar '14

05 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: libvirt and system PKI ...................................................................... packaging: setup: libvirt and system PKI Copy generated vdsm pki also to libvirt. Copy generated vdsm cacert to system-wide /etc/pki/CA/cacert.pem . Reorder so that vdsm pki generation happens before configuring libvirt for vdsm, so that it's configured with tls. Fix selinux contexts for libvirt-spice pki if enabled. Bug-Url: https://bugzilla.redhat.com/1034634 Change-Id: I74f44c46e6720ca8c62af1afa6df4a5d7c013b49 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/ovirt_hosted_engine_setup/mixins.py M src/plugins/ovirt-hosted-engine-setup/core/conf.py M src/plugins/ovirt-hosted-engine-setup/pki/vdsmpki.py M src/plugins/ovirt-hosted-engine-setup/system/vdsmenv.py 5 files changed, 143 insertions(+), 22 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74f44c46e6720ca8c62af1afa6df4a5d7c013b49 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <simone.tiraboschi(a)gmail.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4.0]: packaging: setup: database: move connect to database library
by sbonazzo＠redhat.com 05 Mar '14

05 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: database: move connect to database library ...................................................................... packaging: setup: database: move connect to database library this will enable use of single tweaks for different driver versions. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1067058 Change-Id: I36aa977fd6768b1ea3a96660d8473bf6ecffa277 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/database.py M packaging/setup/plugins/ovirt-engine-rename/core/database.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/db/connection.py 3 files changed, 76 insertions(+), 70 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25332 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36aa977fd6768b1ea3a96660d8473bf6ecffa277 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4.0 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.4]: tools: snmp: fix 'minimal snmp configuration' section in con...
by iheim＠redhat.com 05 Mar '14

05 Mar '14

Itamar Heim has submitted this change and it was merged. Change subject: tools: snmp: fix 'minimal snmp configuration' section in conf file ...................................................................... tools: snmp: fix 'minimal snmp configuration' section in conf file key name has to be FILTER and not FILTERS. users using current example will not get any snmp notification. Change-Id: I0202abfd9c2d26e41d2073a293e27d983f7578f9 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1072849 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Looks good to me, approved mooli tayer: Verified -- To view, visit http://gerrit.ovirt.org/25402 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0202abfd9c2d26e41d2073a293e27d983f7578f9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4.0]: packaging: setup: fix remote database typo
by sbonazzo＠redhat.com 05 Mar '14

05 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: fix remote database typo ...................................................................... packaging: setup: fix remote database typo Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1072307 Change-Id: I9b8876f5699c7abd8953ff01295111b4a983a1aa Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/provisioning/postgres.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b8876f5699c7abd8953ff01295111b4a983a1aa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4.0 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.4.0]: packaging: setup: database: extend check empty
by sbonazzo＠redhat.com 05 Mar '14

05 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: database: extend check empty ...................................................................... packaging: setup: database: extend check empty Also check tables for which the engine db user has no permission. Change-Id: I7de630ba6130aa349c15c1101cf2b041614fa5eb Bug-Url: https://bugzilla.redhat.com/1056528 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/database.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/25368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7de630ba6130aa349c15c1101cf2b041614fa5eb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4.0 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: build: read version correctly
by sbonazzo＠redhat.com 05 Mar '14

05 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: build: read version correctly ...................................................................... packaging: build: read version correctly broken by 34a86209eb82e1 Change-Id: I6c2fca9a1f9006548ff01b82b55f1dc035d8e932 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c2fca9a1f9006548ff01b82b55f1dc035d8e932 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[ovirt-3.3]: packaging: setup: Use ovirt engine configfile
by ydary＠redhat.com 05 Mar '14

05 Mar '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: Use ovirt engine configfile ...................................................................... packaging: setup: Use ovirt engine configfile Use configfile from ovirt-engine-lib and (a copy of) escape from ovirt-engine-setup to parse db credential files. Change-Id: Icdea6a02f2737387a4b89b7156eb2c9ebd248fdd Bug-Url: https://bugzilla.redhat.com/1070344 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/common_utils.py M packaging/ovirt-engine-reports-setup.py 2 files changed, 25 insertions(+), 10 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icdea6a02f2737387a4b89b7156eb2c9ebd248fdd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-reports[ovirt-3.3]: packaging: setup: storeConf early
by ydary＠redhat.com 05 Mar '14

05 Mar '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: storeConf early ...................................................................... packaging: setup: storeConf early Store db creds conf after creating reports db user. Bug-Url: https://bugzilla.redhat.com/1071020 Change-Id: I9edb9411f0b661210b05cccc6c617d32210591a3 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/ovirt-engine-reports-setup.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Yedidyah Bar David: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25339 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9edb9411f0b661210b05cccc6c617d32210591a3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-dwh[ovirt-3.3]: packaging: setup: Use ovirt engine configfile
by ydary＠redhat.com 05 Mar '14

05 Mar '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: Use ovirt engine configfile ...................................................................... packaging: setup: Use ovirt engine configfile Use configfile from ovirt-engine-lib and (a copy of) escape from ovirt-engine-setup to parse db credential files. Bug-Url: https://bugzilla.redhat.com/1070339 Related-To: https://bugzilla.redhat.com/1065781 Change-Id: I44ae8c9c7cfe10977b05ee8eb7fe9a4ba00becdf Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/common_utils.py M packaging/ovirt-engine-dwh-setup.py 2 files changed, 30 insertions(+), 26 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Yedidyah Bar David: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25252 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44ae8c9c7cfe10977b05ee8eb7fe9a4ba00becdf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <simone.tiraboschi(a)gmail.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0