- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: Require WildFly 11
by Code Review 17 Aug '17

17 Aug '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. ( https://gerrit.ovirt.org/80722 ) Change subject: packaging: Require WildFly 11 ...................................................................... packaging: Require WildFly 11 Change-Id: Ia3d754db7a1b0789721ec695ecd06a4bb2bd0cfe Bug-Url: https://bugzilla.redhat.com/1475459 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Peřina: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80722 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3d754db7a1b0789721ec695ecd06a4bb2bd0cfe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: add_image_ticket null check for filename
by Code Review 17 Aug '17

17 Aug '17

>From Daniel Erez <derez(a)redhat.com>: Daniel Erez has submitted this change and it was merged. ( https://gerrit.ovirt.org/80735 ) Change subject: core: add_image_ticket null check for filename ...................................................................... core: add_image_ticket null check for filename JsonRpcVdsServer: add_image_ticket -> add 'filename' to ticket dict only if not null. Change-Id: Ifcddb29b00092c758a7d4ede2eefb6d22928d588 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80735 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifcddb29b00092c758a7d4ede2eefb6d22928d588 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: Add updated size validation to network names.
by Code Review 17 Aug '17

17 Aug '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80344 ) Change subject: backend: Add updated size validation to network names. ...................................................................... backend: Add updated size validation to network names. Maximum allowed network name size is now 256 characters; it is not completely unlimited. Re-add size validations for network names with the new appropriate size (256). Change-Id: Ic6e795d148cc2ac860c3932267ba88113af6695c Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1477161 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Network.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/80344 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6e795d148cc2ac860c3932267ba88113af6695c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: dbscripts: Increase vds_interface's network_name ...
by Code Review 17 Aug '17

17 Aug '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80340 ) Change subject: packaging: dbscripts: Increase vds_interface's network_name col size. ...................................................................... packaging: dbscripts: Increase vds_interface's network_name col size. vds_interface holds the network name of the relevant network. With the recent change to network names where networks are no longer restricted to 15 ASCII characters, vds_interface's network_name must follow suit and be increased to 256 bytes. Change-Id: I09bf3ee1fe6f875885b911a34628ffc16b613225 Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1478717 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M packaging/dbscripts/network_sp.sql A packaging/dbscripts/upgrade/04_02_0470_increase_vds_interface_network_name_size.sql 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/80340 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09bf3ee1fe6f875885b911a34628ffc16b613225 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: dbscripts: Increase vnic_profile's name column to...
by Code Review 17 Aug '17

17 Aug '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80220 ) Change subject: packaging: dbscripts: Increase vnic_profile's name column to 256 bytes. ...................................................................... packaging: dbscripts: Increase vnic_profile's name column to 256 bytes. By default vnic profiles are named after its underlying network. With the recent change to network names where networks are no longer restricted to 15 ASCII characters, vnic profile names must follow suit. Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1477569 Change-Id: I73dcabb3fd9404dc2802121d402e2c79fd5c8a75 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M packaging/dbscripts/network_sp.sql A packaging/dbscripts/upgrade/04_02_0460_increase_vnic_profile_name_size.sql 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/80220 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73dcabb3fd9404dc2802121d402e2c79fd5c8a75 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: Remove unneeded STAGE_BOOT priority
by Code Review 17 Aug '17

17 Aug '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/79570 ) Change subject: packaging: setup: Remove unneeded STAGE_BOOT priority ...................................................................... packaging: setup: Remove unneeded STAGE_BOOT priority Change-Id: I262a88959199def4e9eed77db2f3ca483fee5d23 Related-To: https://bugzilla.redhat.com/1472325 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-hosted-engine-setup.spec.in M src/plugins/gr-he-common/core/misc.py 2 files changed, 1 insertion(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/79570 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I262a88959199def4e9eed77db2f3ca483fee5d23 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: pass vdsm name over network name to vmInfo/libvirtv...
by Code Review 17 Aug '17

17 Aug '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80481 ) Change subject: backend: pass vdsm name over network name to vmInfo/libvirtvmxml ...................................................................... backend: pass vdsm name over network name to vmInfo/libvirtvmxml The actual interface's name libvirt needs to make use of is vdsm_name and not the network's name which is to be used by engine. Pass vdsm_name to vmInfo and libvirt vm's xml instead of network name. Change-Id: Ie53dcf8cc81da8cb83b42d215e753f40cf1b727a Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1478806 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtils.java 2 files changed, 8 insertions(+), 5 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/80481 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie53dcf8cc81da8cb83b42d215e753f40cf1b727a Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: ovn: Minor text cleanup
by Code Review 17 Aug '17

17 Aug '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/80621 ) Change subject: packaging: setup: ovn: Minor text cleanup ...................................................................... packaging: setup: ovn: Minor text cleanup Change-Id: If156a6fc8e9ec11a171c3ea6a1d89ff54ed98170 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/network/ovirtproviderovn.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Marcin Mirecki: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/80621 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If156a6fc8e9ec11a171c3ea6a1d89ff54ed98170 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: frontend: Add updated size validation to network names.
by Code Review 17 Aug '17

17 Aug '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80666 ) Change subject: frontend: Add updated size validation to network names. ...................................................................... frontend: Add updated size validation to network names. Maximum allowed network name size is now 256 characters; it is not completely unlimited. Re-add size validations for network names with the new appropriate size (256). Change-Id: Ia01ed8969910a3499d7b08169a798bf460ff07f6 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java 1 file changed, 18 insertions(+), 15 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/80666 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia01ed8969910a3499d7b08169a798bf460ff07f6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: Update business entitites definitions of network re...
by Code Review 17 Aug '17

17 Aug '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80349 ) Change subject: backend: Update business entitites definitions of network related sizes ...................................................................... backend: Update business entitites definitions of network related sizes Network name maximum size was increased to 256 characters and doesn't longer match bond name and network interface name. Dedicate new size definitions for both with their previous sizes. Change-Id: I80dde91f703d726fa579d33444684fbeef754cab Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateOrUpdateBond.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntitiesDefinitions.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkInterface.java 3 files changed, 5 insertions(+), 3 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/80349 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80dde91f703d726fa579d33444684fbeef754cab Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0