- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: setup: Remove unneeded STAGE_BOOT priorities
by Code Review 17 Aug '17

17 Aug '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/79567 ) Change subject: packaging: setup: Remove unneeded STAGE_BOOT priorities ...................................................................... packaging: setup: Remove unneeded STAGE_BOOT priorities Requires otopi patch https://gerrit.ovirt.org/79566 Change-Id: Id8ed298a3073493db741ff36d666338746853876 Related-To: https://bugzilla.redhat.com/1472325 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/base/core/misc.py M packaging/setup/plugins/ovirt-engine-health/base/core/misc.py M packaging/setup/plugins/ovirt-engine-provisiondb/ovirt-engine-common/core/misc.py M packaging/setup/plugins/ovirt-engine-remove/base/core/misc.py M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/misc.py M packaging/setup/plugins/ovirt-engine-setup/base/core/misc.py 6 files changed, 0 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/79567 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8ed298a3073493db741ff36d666338746853876 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-guest-agent[master]: build: drop useless version.py
by Code Review 17 Aug '17

17 Aug '17

>From Vinzenz Feenstra <vfeenstr(a)redhat.com>: Vinzenz Feenstra has submitted this change and it was merged. ( https://gerrit.ovirt.org/80108 ) Change subject: build: drop useless version.py ...................................................................... build: drop useless version.py The module version.py is hardly used and most of the content is not outdated anyway. There is no real reason to keep it. Change-Id: I98fd82a6d5f2f8832793b28cc12b247e36326628 Signed-off-by: Tomáš Golembiovský <tgolembi(a)redhat.com> --- M Makefile.am M ovirt-guest-agent/Makefile.am M ovirt-guest-agent/setup.py D ovirt-guest-agent/version.py 4 files changed, 1 insertion(+), 26 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/80108 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98fd82a6d5f2f8832793b28cc12b247e36326628 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-guest-agent[master]: remove debian directory
by Code Review 17 Aug '17

17 Aug '17

>From Vinzenz Feenstra <vfeenstr(a)redhat.com>: Vinzenz Feenstra has submitted this change and it was merged. ( https://gerrit.ovirt.org/80098 ) Change subject: remove debian directory ...................................................................... remove debian directory Remove the directory with debian packaging. We don't use it anymore and it causes only confusion. Change-Id: I5a3f344ca33d130b4708a156ae1b1672602c732d Signed-off-by: Tomáš Golembiovský <tgolembi(a)redhat.com> --- M Makefile.am D debian/README.source D debian/changelog D debian/compat D debian/control D debian/copyright D debian/docs D debian/files D debian/ovirt-guest-agent.upstart D debian/postinst D debian/postrm D debian/preinst D debian/rules D debian/source/format M ovirt-guest-agent/Makefile.am 15 files changed, 0 insertions(+), 191 deletions(-) Approvals: Jenkins CI: Passed CI tests Vinzenz Feenstra: Looks good to me, approved Tomas Golembiovsky: Verified -- To view, visit https://gerrit.ovirt.org/80098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a3f344ca33d130b4708a156ae1b1672602c732d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-guest-agent[master]: linux: fix missing argument for lambda of list_nics
by Code Review 17 Aug '17

17 Aug '17

>From Vinzenz Feenstra <vfeenstr(a)redhat.com>: Vinzenz Feenstra has submitted this change and it was merged. ( https://gerrit.ovirt.org/80105 ) Change subject: linux: fix missing argument for lambda of list_nics ...................................................................... linux: fix missing argument for lambda of list_nics Commit a76da96 added posibility to ignore certain interfaces from list of available NICs. This change added a new argument to the function ethtool_list_nics() that handles listing when python-ethtool is available. It however did not add the argument to the lambda used when there is no python-ethtool available. Change-Id: I3235e9a95ad7accde1e7d88973dc3fe03c8c0d2b Signed-off-by: Tomáš Golembiovský <tgolembi(a)redhat.com> --- M ovirt-guest-agent/GuestAgentLinux2.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80105 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3235e9a95ad7accde1e7d88973dc3fe03c8c0d2b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: implement sass compression in ovirt brand
by Code Review 17 Aug '17

17 Aug '17

>From Greg Sheremeta <gshereme(a)redhat.com>: Greg Sheremeta has submitted this change and it was merged. ( https://gerrit.ovirt.org/80576 ) Change subject: webadmin: implement sass compression in ovirt brand ...................................................................... webadmin: implement sass compression in ovirt brand * Turn on sass compression in ovirt-brand * rename the *.css files to .scss, prefix them with '_'. This changes them to be sass partials, which are then imported into other main files. * Created webadmin.scss and welcome.scss, to do the imports and compilation for those respective applications into webadmin.css and welcome.css * Change ovirt-brand to now use webadmin.css and welcome.css, which are now the compiled output from sass. Change-Id: I5b3f576b9348c08d5324fc53adce1d51676393c6 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/brands/ovirt-brand/pom.xml M frontend/brands/ovirt-brand/src/main/resources/branding.properties R frontend/brands/ovirt-brand/src/main/sass/_branding_common.scss R frontend/brands/ovirt-brand/src/main/sass/_branding_webadmin.scss R frontend/brands/ovirt-brand/src/main/sass/_ovirt-patternfly-compat.scss R frontend/brands/ovirt-brand/src/main/sass/_ovirt.scss R frontend/brands/ovirt-brand/src/main/sass/_patternfly-ovirt-overrides.scss R frontend/brands/ovirt-brand/src/main/sass/_webadmin_legacy.scss R frontend/brands/ovirt-brand/src/main/sass/_welcome_base.scss A frontend/brands/ovirt-brand/src/main/sass/webadmin.scss A frontend/brands/ovirt-brand/src/main/sass/welcome.scss 11 files changed, 26 insertions(+), 12 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80576 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b3f576b9348c08d5324fc53adce1d51676393c6 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: move WebAdmin.css from webadmin to ovirt-brand
by Code Review 17 Aug '17

17 Aug '17

>From Greg Sheremeta <gshereme(a)redhat.com>: Greg Sheremeta has submitted this change and it was merged. ( https://gerrit.ovirt.org/80575 ) Change subject: webadmin: move WebAdmin.css from webadmin to ovirt-brand ...................................................................... webadmin: move WebAdmin.css from webadmin to ovirt-brand Move WebAdmin.css from webadmin to ovirt-brand to utilize sass and consolidate css. Change file from css to scss so it actually runs through the jsass compiler. Change-Id: Ie6c545534691ee961bff5a5aa90ef9e115e5cdd8 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/brands/ovirt-brand/src/main/resources/branding.properties R frontend/brands/ovirt-brand/src/main/sass/WebAdmin.scss M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/WebAdmin.gwt.xml 3 files changed, 1 insertion(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6c545534691ee961bff5a5aa90ef9e115e5cdd8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine / branding: introduce sass for css compilation
by Code Review 17 Aug '17

17 Aug '17

>From Greg Sheremeta <gshereme(a)redhat.com>: Greg Sheremeta has submitted this change and it was merged. ( https://gerrit.ovirt.org/80546 ) Change subject: engine / branding: introduce sass for css compilation ...................................................................... engine / branding: introduce sass for css compilation Introduce sass via libsass [1] / libsass-maven-plugin [2][3], and move ovirt.brand into a maven project in frontend/brands. Sass is a css pre-processor that brings us css compression, allows breaking up css into smaller files (called partials) without runtime performance penalties, and allows us to move away from GWT css solutions (whereby css ends up baked into generated JavaScript). Follow-up patches will convert our current css files to well- structured and organized sass files, using partials, variables, etc. [1] https://github.com/sass/libsass [2] https://mvnrepository.com/artifact/com.github.warmuuh/libsass-maven-plugin/ [3] https://github.com/warmuuh/libsass-maven-plugin libsass is platform-specific, written in C/C++. The Maven plugin uses jsass [4] to interop with libsass. jsass uses the "git submodule" feature [5] to pull in libsass code, effectively avoiding the platform-specific dependency on libsass. Therefore, jsass is self-contained Sass impl. that contains all platform-specific libs (Windows .dll, Linux .so, etc.) in its distributable JAR file. [4] https://github.com/bit3/jsass [5] https://github.com/bit3/jsass/blob/develop/.gitmodules Change-Id: I2bb197c9d4eddf2727179aeec8a358d90e3157fa Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M Makefile A frontend/brands/ovirt-brand/pom.xml R frontend/brands/ovirt-brand/src/main/resources/branding.properties R frontend/brands/ovirt-brand/src/main/resources/common.css R frontend/brands/ovirt-brand/src/main/resources/external_resources.properties R frontend/brands/ovirt-brand/src/main/resources/images/dialog/error.png R frontend/brands/ovirt-brand/src/main/resources/images/favicon-16x16.png R frontend/brands/ovirt-brand/src/main/resources/images/favicon-32x32.png R frontend/brands/ovirt-brand/src/main/resources/images/favicon.ico R frontend/brands/ovirt-brand/src/main/resources/images/oVirt_About_BG_Flat_Image.png R frontend/brands/ovirt-brand/src/main/resources/images/oVirt_Banner_solid.png R frontend/brands/ovirt-brand/src/main/resources/images/oVirt_Landing_Bottom_Left_Corner.png R frontend/brands/ovirt-brand/src/main/resources/images/oVirt_Landing_Top_Right_Corner.png R frontend/brands/ovirt-brand/src/main/resources/images/oVirt_Logo.png R frontend/brands/ovirt-brand/src/main/resources/images/ovirt_header_logo.png R frontend/brands/ovirt-brand/src/main/resources/images/ovirt_middle_logo_name.png R frontend/brands/ovirt-brand/src/main/resources/messages.properties R frontend/brands/ovirt-brand/src/main/resources/messages_de_DE.properties R frontend/brands/ovirt-brand/src/main/resources/messages_es_ES.properties R frontend/brands/ovirt-brand/src/main/resources/messages_fr_FR.properties R frontend/brands/ovirt-brand/src/main/resources/messages_it_IT.properties R frontend/brands/ovirt-brand/src/main/resources/messages_ja_JP.properties R frontend/brands/ovirt-brand/src/main/resources/messages_ko_KR.properties R frontend/brands/ovirt-brand/src/main/resources/messages_pt_BR.properties R frontend/brands/ovirt-brand/src/main/resources/messages_zh_CN.properties R frontend/brands/ovirt-brand/src/main/resources/ovirt-patternfly-compat.css R frontend/brands/ovirt-brand/src/main/resources/ovirt.css R frontend/brands/ovirt-brand/src/main/resources/patternfly-ovirt.css R frontend/brands/ovirt-brand/src/main/resources/resources.properties R frontend/brands/ovirt-brand/src/main/resources/web_admin.css R frontend/brands/ovirt-brand/src/main/resources/welcome_page.template R frontend/brands/ovirt-brand/src/main/resources/welcome_style.css A frontend/brands/pom.xml M frontend/pom.xml M ovirt-engine.spec.in M pom.xml 36 files changed, 100 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80546 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2bb197c9d4eddf2727179aeec8a358d90e3157fa Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: improve how we display urls
by Code Review 16 Aug '17

16 Aug '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80723 ) Change subject: inventory: improve how we display urls ...................................................................... inventory: improve how we display urls Instead of show full urls, use related words. Example: instead of full bugzilla url, use bz#NUMBER_ID Change-Id: I19787acb9dd6f29ef889a27a55841d4dabbfd002 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/pre-upgrade-checks 1 file changed, 12 insertions(+), 14 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80723 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19787acb9dd6f29ef889a27a55841d4dabbfd002 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: vmSnapshotListModel#setItems computeIfAbsent
by Code Review 16 Aug '17

16 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80713 ) Change subject: webadmin: vmSnapshotListModel#setItems computeIfAbsent ...................................................................... webadmin: vmSnapshotListModel#setItems computeIfAbsent Use Java 8's Map#computeIfAbsent method instead of reimplementing its logic. Change-Id: Idd51cd755eb80fd9ec9a38a66f6014606687a813 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/80713 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd51cd755eb80fd9ec9a38a66f6014606687a813 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: VmSnapshotListModel streams for statuses
by Code Review 16 Aug '17

16 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80709 ) Change subject: webadmin: VmSnapshotListModel streams for statuses ...................................................................... webadmin: VmSnapshotListModel streams for statuses Use Java 8 streams for filtering snapshots by their status in order to clean up the code and make it easier to maintain. Change-Id: Id0bb9d223a237d7268db409797d024946544660c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 1 file changed, 3 insertions(+), 33 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/80709 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0bb9d223a237d7268db409797d024946544660c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0